Re: Trivial patch for rlm_acctlog in 2.0.5
On Wednesday 13 August 2008 12:24:44 Alan DeKok wrote: Kostas Zorbadelos wrote: As we are preparing for migration to 2.X version in some of our production systems, I took a closer look at the sources and found the rlm_acctlog module that allows for the logging of various types of accounting messages in the radius logs. Moreover I saw that syslog support in 2.X is vastly improved over 1.X series. See also rlm_linelog in the current source (git.freeradius.org), and raddb/modules/linelog. It is a fully configurable module that logs one line of text to a file, based on dynamically expanded keys. I will give a look at it. Seems like a nice generalization of rlm_acctlog -:) My minor request is, could you include the following patch in later releases (so as to not maintain it internally)? Done. Thanks Alan DeKok. Kostas Zorbadelos - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
Re: Trivial patch for rlm_acctlog in 2.0.5
Kostas Zorbadelos wrote: As we are preparing for migration to 2.X version in some of our production systems, I took a closer look at the sources and found the rlm_acctlog module that allows for the logging of various types of accounting messages in the radius logs. Moreover I saw that syslog support in 2.X is vastly improved over 1.X series. See also rlm_linelog in the current source (git.freeradius.org), and raddb/modules/linelog. It is a fully configurable module that logs one line of text to a file, based on dynamically expanded keys. My minor request is, could you include the following patch in later releases (so as to not maintain it internally)? Done. Alan DeKok. - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
Trivial patch for rlm_acctlog in 2.0.5
Hello to everyone. As we are preparing for migration to 2.X version in some of our production systems, I took a closer look at the sources and found the rlm_acctlog module that allows for the logging of various types of accounting messages in the radius logs. Moreover I saw that syslog support in 2.X is vastly improved over 1.X series. My minor request is, could you include the following patch in later releases (so as to not maintain it internally)? --- rlm_acctlog.c.orig 2007-11-12 00:11:51.0 +0200 +++ rlm_acctlog.c 2008-08-08 13:54:34.0 +0300 @@ -79,7 +79,7 @@ rlm_acctlog_t *inst; VALUE_PAIR *pair; - charlogstr[MAX_STRING_LEN]; + charlogstr[1024]; int acctstatustype = 0; The idea is to have a bigger buffer than 253 characters for logging. Some old syslog implementations can have a 1024 character limit I think, so I guess that would be enough :) Thanks and keep up the good work. Kostas Zorbadelos - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
