Re: [ft-devel] Two very minor freetype patch suggestions

2007-06-01 Thread Werner LEMBERG

 1) fttypes.h contain a tab char (line 387) could it be changed to
 spaces?  VTK will not allow commits of files with tabs, and freetype
 seems to prefer spaces also.

Fixed.

 2) A compiler warning (ftsystem.c:278):
 http://www.vtk.org/Testing/Sites/hythloth.kitware/Linux-gcc295/20070531-1517-Continuous/BuildWarning.html
 
 I think changing ULONG_MAX to LONG_MAX is appropriate.

Fixed.  This is your code, BTW. :-)


Werner


___
Freetype-devel mailing list
Freetype-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/freetype-devel


Re: [ft-devel] drop-out control

2007-06-01 Thread David Turner
Hi Werner,

On Wed, 30 May 2007 07:19:50 +0200 (CEST), Werner LEMBERG [EMAIL PROTECTED] 
said:
 
 
 Almost four years ago I've written about this topic, but haven't
 received an answer:
 
 1. The argument of both the SCANTYPE amd SCANCTRL instructions (in
ttinterp.c) are parsed but never used.
 
 2. ftraster.c apparently supports TrueType drop-out control modes 1,
2, 4, and 5, but it doesn't support mode 0.  This looks very
strange.  Maybe this problem has never shown up because the mode is
always set to 2 (which is strange also).
 
Are ftraster's drop-out control modes the ones described in the
TrueType specification?
 
 3. As Top Bishop noted five years ago, FT_OUTLINE_IGNORE_DROPOUTS (in
ftimage.h) is not implemented.
 
 Now that the rasterizer behaves more or less identical to the
 implementation of Microsoft, I think it would be a good idea to close
 this last gap.
 
 David, can you shed some light on it?
 

Sorry, I though I had already answered to this. The reason why the drop-out
mode is fixed to 2, is simply because it's the only way to get decent rendering
with most TrueType fonts. Any other mode will create some ugly artefacts. At 
least
that was the case last time I tried it, and I don't think this changed at all.

so, either the Windows/Apple rasterizer don't follow the spec to the letter, or
there is something here that is either fundamentally not understood, or not
documented. Which one is which is left as an exercise to the reader.

on the other hand, FT_OUTLINE_IGNORE_DROPOUTS should be implemented, I'll take
a look at it

Regards,

- David

 
 Werner
 
 
 ___
 Freetype-devel mailing list
 Freetype-devel@nongnu.org
 http://lists.nongnu.org/mailman/listinfo/freetype-devel


___
Freetype-devel mailing list
Freetype-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/freetype-devel


Re: [ft-devel] Two very minor freetype patch suggestions

2007-06-01 Thread Sean McBride
On 2007-06-01 08:49, Werner LEMBERG said:


 1) fttypes.h contain a tab char (line 387) could it be changed to
 spaces?  VTK will not allow commits of files with tabs, and freetype
 seems to prefer spaces also.

Fixed.

 2) A compiler warning (ftsystem.c:278):
 http://www.vtk.org/Testing/Sites/hythloth.kitware/Linux-
gcc295/20070531-1517-Continuous/BuildWarning.html

 I think changing ULONG_MAX to LONG_MAX is appropriate.

Fixed.  This is your code, BTW. :-)

Yes. :)  That gave me a good laugh too. :)  Thanks for the checkin.

Today's VTK build revealed a few more warnings too, from a machine using
the Borland compiler:

http://www.vtk.org/Testing/Sites/dash19.kitware/Win32-
bcc32/20070601-0300-Nightly/BuildWarning.html

They aren't as trivial, but perhaps you'd take a look?

Cheers,

--

Sean McBride, B. Eng [EMAIL PROTECTED]
Rogue Researchwww.rogue-research.com
Mac Software Developer  Montréal, Québec, Canada




___
Freetype-devel mailing list
Freetype-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/freetype-devel


Re: [ft-devel] Two very minor freetype patch suggestions

2007-06-01 Thread mpsuzuki
Dear Sir,

Thank you for sending new patches for ftmac.c,
I will check them within 1 weeks. Please wait.

On Fri, 1 Jun 2007 11:50:53 -0400
Sean McBride [EMAIL PROTECTED] wrote:
2) HLock() and HUnlock() are nop's (and deprecated) on OS X (See
MacMemory.h) and as ftmac.c is now OS X-only, they can be removed.

3) other misc warnings fixed in ftmac.c

Regards,
mpsuzuki


___
Freetype-devel mailing list
Freetype-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/freetype-devel


Re: [ft-devel] drop-out control

2007-06-01 Thread Werner LEMBERG
 The reason why the drop-out mode is fixed to 2, is simply because
 it's the only way to get decent rendering with most TrueType fonts.

OK.  *Please* add some doc lines to ttraster.c so that innocent
viewers can recognize how to associate FreeType raster modes 1, 2, 4,
and 5 with the mode numbers in the specification (which are not
identical).

 Any other mode will create some ugly artefacts. At least that was
 the case last time I tried it, and I don't think this changed at
 all.
 
 so, either the Windows/Apple rasterizer don't follow the spec to the
 letter, or there is something here that is either fundamentally not
 understood, or not documented.

I'll send a mail to the opentype list, asking for example fonts which
actually use different scan modes.  Maybe MS or Apple guys have
something for testing, or they can give more details.


Werner


___
Freetype-devel mailing list
Freetype-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/freetype-devel


Re: [ft-devel] drop-out control

2007-06-01 Thread Werner LEMBERG

 OK.  *Please* add some doc lines to ttraster.c so that innocent
 viewers can recognize how to associate FreeType raster modes 1, 2,
 4, and 5 with the mode numbers in the specification (which are not
 identical).

BTW, they have different enumerations in the Apple and MS
specification too...


Werner


___
Freetype-devel mailing list
Freetype-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/freetype-devel