[Freevo-users] [PATCH] LCDd requires escaped backslashes
Current lcd.py emits unescaped backslashed for the audio progress indications.
Resulting in the following error in LCDd:
select(1024, [3 5 6 7], NULL, NULL, {0, 0}) = 2 (in [6 7], left {0, 0})
read(6, "widget_set P cpu0_bar 6 1 4\n", 8192) = 28
read(6, 0xbfe0c33c, 8192) = -1 EAGAIN (Resource temporarily
unavailable)
read(7, "widget_set audio_player animation_v 1 2 \"\\\"\n", 8192) = 44
| 0 77 69 64 67 65 74 5f 73 65 74 20 61 75 64 69 6f widget_s et audio |
| 00010 5f 70 6c 61 79 65 72 20 61 6e 69 6d 61 74 69 6f _player animatio |
| 00020 6e 5f 76 20 31 20 32 20 22 5c 22 0a n_v 1 2 "\". |
read(7, 0xbfe0c33c, 8192) = -1 EAGAIN (Resource temporarily
unavailable)
write(6, "success\n", 8)= 8
time(NULL) = 1263892954
send(8, "<11>Jan 19 10:22:34 LCDd: error: huh? Could not parse command\n\0",
63, MSG_NOSIGNAL) = 63
write(7, "huh? Could not parse command\n", 29) = 29
nanosleep({0, 3125}, NULL) = 0
gettimeofday({1263892954, 428432}, NULL) = 0
select(1024, [3 5 6 7], NULL, NULL, {0, 0}) = 1 (in [6], left {0, 0})
read(6, "widget_set P cpu1_bar 6 2 50\n", 8192) = 29
read(6, 0xbfe0c33c, 8192) = -1 EAGAIN (Resource temporarily
unavailable)
This patch fixes it:
--- /usr/lib/python2.6/site-packages/freevo/plugins/lcd_old.py 2010-01-19
11:00:59.0 +0100
+++ /usr/lib/python2.6/site-packages/freevo/plugins/lcd.py 2010-01-19
11:00:32.0 +0100
@@ -598,9 +598,9 @@
# Animaton-Sequence used in audio playback
# Some displays (like the CrytstalFontz) do display the \ as a /
if self.version.startswith('0.5'):
-self.animation_audioplayer_chars = ['-', '\\', '|', '/']
+self.animation_audioplayer_chars = ['-', '', '|', '/']
elif self.version.startswith('0.4'):
-self.animation_audioplayer_chars = ['-', '\\', '|', '/']
+self.animation_audioplayer_chars = ['-', '', '|', '/']
else:
self.disable = 1
self.reason = 'Unsupported LCDd version: %s' % (self.version,)
--
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
___
Freevo-users mailing list
Freevo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-users
Re: [Freevo-users] [PATCH] LCDd requires escaped backslashes
Anders Eriksson wrote:
> Current lcd.py emits unescaped backslashed for the audio progress
> indications.
> Resulting in the following error in LCDd:
>
> select(1024, [3 5 6 7], NULL, NULL, {0, 0}) = 2 (in [6 7], left {0, 0})
> read(6, "widget_set P cpu0_bar 6 1 4\n", 8192) = 28
> read(6, 0xbfe0c33c, 8192) = -1 EAGAIN (Resource temporarily
> unavailable)
> read(7, "widget_set audio_player animation_v 1 2 \"\\\"\n", 8192) = 44
> | 0 77 69 64 67 65 74 5f 73 65 74 20 61 75 64 69 6f widget_s et audio
> |
> | 00010 5f 70 6c 61 79 65 72 20 61 6e 69 6d 61 74 69 6f _player animatio
> |
> | 00020 6e 5f 76 20 31 20 32 20 22 5c 22 0a n_v 1 2 "\".
> |
> read(7, 0xbfe0c33c, 8192) = -1 EAGAIN (Resource temporarily
> unavailable)
> write(6, "success\n", 8)= 8
> time(NULL) = 1263892954
> send(8, "<11>Jan 19 10:22:34 LCDd: error: huh? Could not parse command\n\0",
> 63, MSG_NOSIGNAL) = 63
> write(7, "huh? Could not parse command\n", 29) = 29
> nanosleep({0, 3125}, NULL) = 0
> gettimeofday({1263892954, 428432}, NULL) = 0
> select(1024, [3 5 6 7], NULL, NULL, {0, 0}) = 1 (in [6], left {0, 0})
> read(6, "widget_set P cpu1_bar 6 2 50\n", 8192) = 29
> read(6, 0xbfe0c33c, 8192) = -1 EAGAIN (Resource temporarily
> unavailable)
>
>
> This patch fixes it:
>
> --- /usr/lib/python2.6/site-packages/freevo/plugins/lcd_old.py 2010-01-19
> 11:00:59.0 +0100
> +++ /usr/lib/python2.6/site-packages/freevo/plugins/lcd.py 2010-01-19
> 11:00:32.0 +0100
> @@ -598,9 +598,9 @@
> # Animaton-Sequence used in audio playback
> # Some displays (like the CrytstalFontz) do display the \ as a /
> if self.version.startswith('0.5'):
> -self.animation_audioplayer_chars = ['-', '\\', '|', '/']
> +self.animation_audioplayer_chars = ['-', '', '|', '/']
> elif self.version.startswith('0.4'):
> -self.animation_audioplayer_chars = ['-', '\\', '|', '/']
> +self.animation_audioplayer_chars = ['-', '', '|', '/']
> else:
> self.disable = 1
> self.reason = 'Unsupported LCDd version: %s' % (self.version,)
>
>
>
Hi Anders,
Thanks for the patch, can you submit it to the bug tracker to make sure
it gets included?
http://sourceforge.net/tracker/?atid=446895&group_id=46652
John
--
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
___
Freevo-users mailing list
Freevo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-users
Re: [Freevo-users] [PATCH] LCDd requires escaped backslashes
Hi John, john.molo...@gcd.ie said: > Thanks for the patch, can you submit it to the bug tracker to make sure it > gets included? I don't want to be rude, but is there any reason it cannot be applied right now? I'm not sure who has commit rights. Do you? -Anders -- Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev ___ Freevo-users mailing list Freevo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-users
Re: [Freevo-users] [PATCH] LCDd requires escaped backslashes
Anders Eriksson wrote: > Hi John, > > john.molo...@gcd.ie said: > >> Thanks for the patch, can you submit it to the bug tracker to make sure it >> gets included? >> > > I don't want to be rude, but is there any reason it cannot be applied right > now? I'm not sure who has commit rights. Do you? > > -Anders > Don't worry, it's a fair question. I can't commit no, Duncan is the maintainer of the 1.x branch and would be the one committing it. He asked a long time ago that people use the tracker for a number of reasons including crediting the user, tracking the bugs and feature requests and to make sure that patches don't get lost in the list archives if he doesn't get around to applying them quickly. There were probably a few others too, sourceforge statistics at a guess. As it happens he's been pretty busy lately and is only getting back to spending some time on the 1.x branch now after a long break. It's handy for him to be able to browse the trackers and know exactly what's outstanding rather than having to trawl through every single post to the users and devel lists to get up to speed. John -- Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev ___ Freevo-users mailing list Freevo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-users
Re: [Freevo-users] [PATCH] LCDd requires escaped backslashes
john.molo...@gcd.ie said: > As it happens he's been pretty busy lately and is only getting back to > spending some time on the 1.x branch now after a long break. It's handy for > him to be able to browse the trackers and know exactly what's outstanding > rather than having to trawl through every single post to the users and devel > lists to get up to speed. Done: https://sourceforge.net/tracker/?func=detail&aid=2935152&group_id=46652&atid=446895 -- Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev ___ Freevo-users mailing list Freevo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-users
