Re: [Freevo-users] mplayer.py bug with playlist url (.pls)

2008-05-04 Thread Jim Duda
Forgot to mention this is version 1.8.0

Jim

Jim Duda wrote:
> I found a bug in the mplayer.py plugin when attempting to play a network 
> url which is a playlist.  Mplayer needs a -playlist argument for these 
> url's and it wasn't getting it.
> 
> An example filename in question is:
> http://www.wbur.org/listen/feed/shoutcast.pls
> 
> The is_playlist variable wasn't getting set to true because the ext 
> variable was getting loaded with:
> ext = str(os.path.splitext(filename))
> ext=(u'http://www.wbur.org/listen/feed/shoutcast', u'.pls')
> 
> I needed to add the following patch to get network playlists to work 
> properly.  I'm not a python programmer by any means, so, I don't know if 
> this is the best patch to make.
> 
> lroom# diff -u mplayer.py mplayer.py~
> 
> +++ mplayer.py 2008-05-03 14:46:05.0 -0400
> --- mplayer.py~ 2008-05-04 16:16:21.0 -0400
> 
> @@ -146,9 +146,6 @@
>   if str(filename).find(".jsp?") >= 0:
>   is_playlist = True
> 
> +if str(filename).find(".pls") >= 0:
> +is_playlist = True
> +
>   if item.network_play:
>   extra_opts += ' -cache 100'
> 
> @
> 
> 
> filename=http://www.wbur.org/listen/feed/shoutcast.pls 
> ext=(u'http://www.wbur.org/listen/feed/shoutcast', u'.pls')
> 
> Jim
> 
> 
> -
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
> Don't miss this year's exciting event. There's still time to save $100. 
> Use priority code J8TL2D2. 
> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone


-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
Freevo-users mailing list
Freevo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-users


[Freevo-users] mplayer.py bug with playlist url (.pls)

2008-05-04 Thread Jim Duda
I found a bug in the mplayer.py plugin when attempting to play a network 
url which is a playlist.  Mplayer needs a -playlist argument for these 
url's and it wasn't getting it.

An example filename in question is:
http://www.wbur.org/listen/feed/shoutcast.pls

The is_playlist variable wasn't getting set to true because the ext 
variable was getting loaded with:
ext = str(os.path.splitext(filename))
ext=(u'http://www.wbur.org/listen/feed/shoutcast', u'.pls')

I needed to add the following patch to get network playlists to work 
properly.  I'm not a python programmer by any means, so, I don't know if 
this is the best patch to make.

lroom# diff -u mplayer.py mplayer.py~

+++ mplayer.py 2008-05-03 14:46:05.0 -0400
--- mplayer.py~ 2008-05-04 16:16:21.0 -0400

@@ -146,9 +146,6 @@
  if str(filename).find(".jsp?") >= 0:
  is_playlist = True

+if str(filename).find(".pls") >= 0:
+is_playlist = True
+
  if item.network_play:
  extra_opts += ' -cache 100'

@


filename=http://www.wbur.org/listen/feed/shoutcast.pls 
ext=(u'http://www.wbur.org/listen/feed/shoutcast', u'.pls')

Jim


-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
Freevo-users mailing list
Freevo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-users