Re: [Patch] MinIconSize/MaxIconSize

2002-06-24 Thread Steve Talley
Mikhael Goikhman wrote:

 On 22 Jun 2002 16:25:27 -0600, Steve Talley wrote:

  One of the things I liked about MWM (CDE actually) was that the
  size of the icons could be limited/controlled.  In FVWM this isn't
  possible, short of specifying an icon image for each app.  The
  result is that people who use IconBox/IconGrid may have icons that
  are too big for the grid spot.  The FVWM man page mentions FVWM's
  inability to clip icons in this case.
 
  Another issue that is mildly bothersome is that the width of the
  icon title bar is determined by the width of the icon image.  So
  small icons result in a smaller area to click on.
 
  The attached patch addresses both of these issues.  It provides
  support for two new Style subcommands:
 
  MinIconSize width height
  MaxIconSize width height
 
  These allow you to limit/control the size of both user-provided
  and application-provided icon images.  Icon images that are
  smaller than MaxIconSize are clipped.  Icon images that are bigger
  than MinIconSize are padded.

 Seems like a good patch.  Some notes.

Thanks Mikhael.  I have implemented all of your suggestions in the
attached patch.  Comments inline:

 Is it possible to replace int with unsigned char? This will save 12
 * 500 = 6Kb for me.

Sure.  I just looked at a 256x256 icon on my desktop (at 1152x864),
and it was huge.  However, for *much* larger resolutions in the
future, 256x256 may not be all that big...

 Icon sizes bigger than 1/4 of screen are bad.

  Setting both MinIconSize and MaxIconSize to the same dimensions
  has the effect of enforcing a rigid size for the icon image.  For
  example:
 
  Style * MaxIconSize 64 50
  Style * MinIconSize 64 50

 Since this is the main usage, is this possible to change the syntax
 to:

   Style * IconSize x y[, x2 y2]

 where one pair means both min and max values?

Excellent idea.  Certainly simplifies the syntax.

 Another optimization would be to say that size 0 is invalid so it
 may be used to switch the feature off. Any of the following 3:

   Style * IconSize
   Style * IconSize 0 0
   Style * IconSize 0 0, 0 0

 may disable the feature completely. It would be possible to only
 partialy disable it (IconSize 0 0, 48 0). This should save another 4
 bits and seems more consistent than the logic in the patch that
 allows one integer in the pair (I don't think this should be allowed
 as ambiguous, use 0 instead).

Agreed.  However, I have made -1 the disable/default value, since 0 is
a valid maximum dimension.  Consider the setting:

Style * IconSize 64 0

This will result in something like the attached zeroheight.jpg
(IconGrid is defined) or zeroheight2.jpg (IconGrid not defined),
effectively allowing the user to specify that no image is to be shown
but still be able size the icon title.

  This results in the same behavior as MWM/CDE.  See the attached
  before/after images to see the efect of the patch and the above
  settings.  The same IconBox/IconGrid settings are used in each
  case.
 
  Please take a look at the attached patch and let me know if there
  are any questions/suggestions/etc.  It is based on the latest CVS
  snapshot.

 Regards, Mikhael.

Thanks again Mikhael.  Let me know if you have any other
suggestions/comments on the latest patch.

Steve
Index: fvwm/add_window.c
===
RCS file: /home/cvs/fvwm/fvwm/fvwm/add_window.c,v
retrieving revision 1.295
diff -u -r1.295 add_window.c
--- fvwm/add_window.c   2002/06/17 00:33:06 1.295
+++ fvwm/add_window.c   2002/06/24 04:07:02
@@ -1057,6 +1057,25 @@
return;
 }
 
+/*
+ * Copy icon size limits from window_style structure to FvwmWindow
+ * structure.
+ */
+void setup_icon_size_limits(FvwmWindow *fw, window_style *pstyle)
+{
+if (SHAS_ICON_SIZE_LIMITS(pstyle-flags)) {
+fw-min_icon_width = SGET_MIN_ICON_WIDTH(*pstyle);
+fw-min_icon_height = SGET_MIN_ICON_HEIGHT(*pstyle);
+fw-max_icon_width = SGET_MAX_ICON_WIDTH(*pstyle);
+fw-max_icon_height = SGET_MAX_ICON_HEIGHT(*pstyle);
+} else {
+fw-min_icon_width = MIN_ALLOWABLE_ICON_DIMENSION;
+fw-min_icon_height = MIN_ALLOWABLE_ICON_DIMENSION;
+fw-max_icon_width = MAX_ALLOWABLE_ICON_DIMENSION;
+fw-max_icon_height = MAX_ALLOWABLE_ICON_DIMENSION;
+}
+}
+
 Bool setup_window_placement(
FvwmWindow *fw, window_style *pstyle, rectangle *attr_g,
initial_window_options_type *win_opts)
@@ -2074,6 +2093,9 @@
 
/** border width **/
XSetWindowBorderWidth(dpy, FW_W(fw), 0);
+
+   /** icon size limits **/
+   setup_icon_size_limits(fw, style);
 
/* placement penalities */
setup_placement_penalty(fw, style);
Index: fvwm/add_window.h
===
RCS file: /home/cvs/fvwm/fvwm/fvwm/add_window.h,v
retrieving revision 1.26
diff -u -r1.26 add_window.h
--- 

Re: [Patch] MinIconSize/MaxIconSize

2002-06-24 Thread Dmitry Yu. Bolkhovityanov
On Sun, 23 Jun 2002, Steve Talley wrote:

  Since this is the main usage, is this possible to change the syntax
  to:
 
Style * IconSize x y[, x2 y2]
 
  where one pair means both min and max values?
 
 Excellent idea.  Certainly simplifies the syntax.

A small comment: IconSize suggests that icons fill be somehow
forced (shrinked/grown) to specified size.  Isn't IconSizeLimits a more
intuitive name?

_
  Dmitry Yu. Bolkhovityanov
  The Budker Institute of Nuclear Physics
  Novosibirsk, Russia

--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


Re: String encoding

2002-06-24 Thread Olivier Chapuis
On Sun, Jun 23, 2002 at 06:49:18AM +, Mikhael Goikhman wrote:
 On 13 Jun 2002 06:42:28 +0200, Olivier Chapuis wrote:
  
  BTW, the new code will be ready on Monday (at least half ready as there
  are pbs in the implementation: text conversion are done each time a
  Flocale text drawing or text width function is called, as conversion
  should be done only when the text change; I will come back on this pbs
  later). This may cause 2.5.2 release delay, if you plan to release it
  next week.
 
 Is there something left to do except for non critical optimizations?


No, I do not think so. I will come on optimization soon but this
may need discussion.

Olivier
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


Re: configure's xft2 detection broken

2002-06-24 Thread Olivier Chapuis
On Sun, Jun 23, 2002 at 04:06:59AM -0600, S. Anderson wrote:
 Hi,
 with fvwm cvs, xft2 isn't detected with the following
 [EMAIL PROTECTED] ~/src/fvwm % ./utils/configure_dev.sh 
 --prefix=/home/sa/local \
--enable-xft --with-xft-prefix=/usr/X11R6 \
--with-fontconfig-prefix=/usr/X11R6
 
 this diff fixes it,
 hth,
 sa
 
 [EMAIL PROTECTED] (1)~/src/fvwm % diff -u acinclude.m4.orig acinclude.m4
 --- acinclude.m4.orig   Sun Jun 23 03:39:41 2002
 +++ acinclude.m4Sun Jun 23 03:51:14 2002
 @@ -1159,7 +1159,7 @@
  if test x$fc_config_exec_prefix != x ; then
fc_config_args=$fc_config_args --exec-prefix=$fc_config_exec_prefix
if test x${FC_CONFIG+set} != xset ; then
 -FC_CONFIG=$fc_config_exec_prefix/bin/fontconfig-config
 +FC_CONFIG=$fc_config_exec_prefix/fontconfig-config
fi
  fi

I do not think this is correct (but I am not a configure expert).
A priori you should just use --with-fontconfig-prefix=fc_install_prefix
(if it is installed in a non standard place and you install fontconfig
with ./configure --prefix=fc_install_prefix). Now, you should
use --with-fontconfig-exec-prefix=fc_install_exec_prefix only if
fc_install_exec_prefix != fc_install_prefix and this means that
you have installed fontconfig with:
./configure [--prefix=fc_install_prefix] --exec-prefix=fc_install_prefix_exec
which then install fontconfig-config in fc_install_prefix_exec/bin and
not in fc_install_prefix_exec/
Finally, if you use the Imake method to install fontconfig, I do
not think you need arguments to fvwm configure as fontconfig is
installed in a standard place (your X tree). 
 
  if test x$fc_config_prefix != x ; then
 @@ -1349,6 +1349,7 @@
  dnl
AC_TRY_RUN([
  #include X11/Xft/Xft.h
 +#include fontconfig/fontconfig.h
  #include stdio.h
  #include stdlib.h


But in Xft2,  X11/Xft/Xft.h include fontconfig/fontconfig.h
at least with fcpackage.02-06-19.14-43. It seems to me that
for some reason the X11/Xft/Xft.h included is the one from
Xft1 (from your X install).

Can you give more info on your install: where X is installed
(with the version) and how you exactly install fcpackage.

Olivier
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


Re: configure's xft2 detection broken

2002-06-24 Thread Mikhael Goikhman
I agree with Olivier that the current acinclude.m4 should be correct for
xft detection (although I have version 1 myself). If I would write it from
scratch I would use a simple method --with-fontconfig-bindir instead of
the 2 current switches and would not pass any args to fontconfig-config,
this is redundant, it should know its own prefix itself.

But what about changes to libs/Fft.h, Are they needed? This is the only
thing that stops me from building 2.5.2 now.

Regards,
Mikhael.
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


Re: [Patch] MinIconSize/MaxIconSize

2002-06-24 Thread Mikhael Goikhman
On 23 Jun 2002 22:30:25 -0600, Steve Talley wrote:
 
 Mikhael Goikhman wrote:
 
  Another optimization would be to say that size 0 is invalid so it
  may be used to switch the feature off. Any of the following 3:
 
Style * IconSize
Style * IconSize 0 0
Style * IconSize 0 0, 0 0
 
  may disable the feature completely. It would be possible to only
  partialy disable it (IconSize 0 0, 48 0). This should save another 4
  bits and seems more consistent than the logic in the patch that
  allows one integer in the pair (I don't think this should be allowed
  as ambiguous, use 0 instead).
 
 Agreed.  However, I have made -1 the disable/default value, since 0 is
 a valid maximum dimension.  Consider the setting:
 
 Style * IconSize 64 0
 
 This will result in something like the attached zeroheight.jpg
 (IconGrid is defined) or zeroheight2.jpg (IconGrid not defined),
 effectively allowing the user to specify that no image is to be shown
 but still be able size the icon title.

Hmm, ok.

Can IconSize receive 0 arguments (not just 2 or 4) for disabling too?

Regards,
Mikhael.
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


Re: configure's xft2 detection broken

2002-06-24 Thread S. Anderson
 
 But in Xft2,  X11/Xft/Xft.h include fontconfig/fontconfig.h
 at least with fcpackage.02-06-19.14-43. It seems to me that
 for some reason the X11/Xft/Xft.h included is the one from
 Xft1 (from your X install).
 
 Can you give more info on your install: where X is installed
 (with the version) and how you exactly install fcpackage.
 
 Olivier

you are right /usr/X11R6/include/X11/Xft/Xft.h is the old version.
When I did a make install for Xft v2 the new header files didnt get
copied, It works great now.

Thanks,
sa
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


CVS migo: * minor fixes

2002-06-24 Thread FVWM CVS
CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by: migo02/06/24 05:53:07

Modified files:
docs   : FAQ 
fvwm   : fvwm.1 
libs   : FlocaleCharset.c 
utils  : make_fvwmdist.sh 

Log message:
* minor fixes

--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


CVS migo: * more documentation fixes

2002-06-24 Thread FVWM CVS
CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by: migo02/06/24 06:05:10

Modified files:
.  : ChangeLog INSTALL.fvwm 
perllib/FVWM   : Module.pm.in 

Log message:
* more documentation fixes

--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


CVS migo: * Set development version to 2.5.3.

2002-06-24 Thread FVWM CVS
CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by: migo02/06/24 06:28:44

Modified files:
.  : NEWS configure.in ChangeLog 

Log message:
* Set development version to 2.5.3.

--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


Re: 2.5.2 tarballs are uploaded

2002-06-24 Thread Jason L Tibbitts III
 MG == Mikhael Goikhman [EMAIL PROTECTED] writes:

MG 2.5.2 tarballs are uploaded.

They are in place, but docs/ANNOUNCE still says 2.5.1.

 - J
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


Re: 2.5.2 tarballs are uploaded

2002-06-24 Thread Mikhael Goikhman
On 24 Jun 2002 08:47:22 -0500, Jason L Tibbitts III wrote:
 
  MG == Mikhael Goikhman [EMAIL PROTECTED] writes:
 
 MG 2.5.2 tarballs are uploaded.
 
 They are in place, but docs/ANNOUNCE still says 2.5.1.

Not very critical for alpha releases. It may be reconstructed from NEWS.

Regards,
Mikhael.
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


CVS migo: * announce for 2.5.2

2002-06-24 Thread FVWM CVS
CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by: migo02/06/24 08:58:08

Modified files:
docs   : ANNOUNCE 

Log message:
* announce for 2.5.2

--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


Re: WindowList SortClassName (take 2)

2002-06-24 Thread Mikhael Goikhman
On 23 Jun 2002 22:47:57 -0500, David Fries wrote:
 
 Feedback appreciated.  I am now sorting based on the class first and
 then looking at the title etc based on the other flags.
 
 Now that I think about it both the Alphabetic and my version will
 nullify the work of both CurrentAtEnd and IconifiedAtEnd.  Is anyone
 interested in more code bloat to take care of this?

I think those who added these option are not interested in sorting.

 I see in the WindowList function there is a mix between defining a
 custom 'Bool' variable and using the flags with a bit mask.  Any
 feelings on standardizing on one or the other?  We do only have 16
 bits left.

We do not have WindowList maintainer, everyone adds what he wants. :)
If you may verify that your changes do not break anything, feel free to
improve the rest of the code. If you have a time you may also synchronize
window lists in FvwmWinList and FvwmGtk as well. Thank you.

 This time I did not include a SortClassNameOff, but I see there are
 'off' options for, NotAlphabetic NoGeometry NoGeometryWithInfo NoIcons
 NoNormal NoSticky based on pervious posts I wonder if I should add
 that option or remove the others.

I don't know. Probably neither of two.

Can you post another patch against cvs, this time including the man page
description?

Regards,
Mikhael.
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


Re: [Patch] MinIconSize/MaxIconSize

2002-06-24 Thread Steve Talley
Mikhael Goikhman wrote:

 On 23 Jun 2002 22:30:25 -0600, Steve Talley wrote:

  Mikhael Goikhman wrote:
 
   Another optimization would be to say that size 0 is invalid so it
   may be used to switch the feature off. Any of the following 3:
  
 Style * IconSize
 Style * IconSize 0 0
 Style * IconSize 0 0, 0 0
  
   may disable the feature completely. It would be possible to only
   partialy disable it (IconSize 0 0, 48 0). This should save another 4
   bits and seems more consistent than the logic in the patch that
   allows one integer in the pair (I don't think this should be allowed
   as ambiguous, use 0 instead).
 
  Agreed.  However, I have made -1 the disable/default value, since 0 is
  a valid maximum dimension.  Consider the setting:
 
  Style * IconSize 64 0
 
  This will result in something like the attached zeroheight.jpg
  (IconGrid is defined) or zeroheight2.jpg (IconGrid not defined),
  effectively allowing the user to specify that no image is to be shown
  but still be able size the icon title.

 Hmm, ok.

 Can IconSize receive 0 arguments (not just 2 or 4) for disabling too?

Oops.  Yes, I have added this feature to the attached patch.

Steve
Index: fvwm/add_window.c
===
RCS file: /home/cvs/fvwm/fvwm/fvwm/add_window.c,v
retrieving revision 1.295
diff -u -r1.295 add_window.c
--- fvwm/add_window.c   2002/06/17 00:33:06 1.295
+++ fvwm/add_window.c   2002/06/24 15:29:52
@@ -1057,6 +1057,25 @@
return;
 }
 
+/*
+ * Copy icon size limits from window_style structure to FvwmWindow
+ * structure.
+ */
+void setup_icon_size_limits(FvwmWindow *fw, window_style *pstyle)
+{
+if (SHAS_ICON_SIZE_LIMITS(pstyle-flags)) {
+fw-min_icon_width = SGET_MIN_ICON_WIDTH(*pstyle);
+fw-min_icon_height = SGET_MIN_ICON_HEIGHT(*pstyle);
+fw-max_icon_width = SGET_MAX_ICON_WIDTH(*pstyle);
+fw-max_icon_height = SGET_MAX_ICON_HEIGHT(*pstyle);
+} else {
+fw-min_icon_width = MIN_ALLOWABLE_ICON_DIMENSION;
+fw-min_icon_height = MIN_ALLOWABLE_ICON_DIMENSION;
+fw-max_icon_width = MAX_ALLOWABLE_ICON_DIMENSION;
+fw-max_icon_height = MAX_ALLOWABLE_ICON_DIMENSION;
+}
+}
+
 Bool setup_window_placement(
FvwmWindow *fw, window_style *pstyle, rectangle *attr_g,
initial_window_options_type *win_opts)
@@ -2074,6 +2093,9 @@
 
/** border width **/
XSetWindowBorderWidth(dpy, FW_W(fw), 0);
+
+   /** icon size limits **/
+   setup_icon_size_limits(fw, style);
 
/* placement penalities */
setup_placement_penalty(fw, style);
Index: fvwm/add_window.h
===
RCS file: /home/cvs/fvwm/fvwm/fvwm/add_window.h,v
retrieving revision 1.26
diff -u -r1.26 add_window.h
--- fvwm/add_window.h   2002/03/24 19:19:24 1.26
+++ fvwm/add_window.h   2002/06/24 15:29:53
@@ -57,6 +57,8 @@
FvwmWindow *fw);
 void setup_frame_size_limits(
FvwmWindow *fw, window_style *pstyle);
+void setup_icon_size_limits(
+   FvwmWindow *fw, window_style *pstyle);
 void increase_icon_hint_count(
FvwmWindow *fw);
 void change_icon(
Index: fvwm/fvwm.1
===
RCS file: /home/cvs/fvwm/fvwm/fvwm/fvwm.1,v
retrieving revision 1.23
diff -u -r1.23 fvwm.1
--- fvwm/fvwm.1 2002/06/21 14:32:34 1.23
+++ fvwm/fvwm.1 2002/06/24 15:30:04
@@ -5333,7 +5333,7 @@
 slashes ('/').  The last style in these groups is the default.
 .IR BorderWidth ,  HandleWidth ,
 .IR NoIcon  /  Icon ,  MiniIcon ,
-.IR IconBox ,  IconGrid ,  IconFill ,
+.IR IconBox ,  IconGrid ,  IconFill ,  IconSize ,
 .IR NoTitle  /  Title ,
 .IR TitleAtBottom  /  TitleAtLeft  /  TitleAtRight  /  TitleAtTop ,
 .IR LeftTitleRotatedCW  /  LeftTitleRotatedCCW,
@@ -5881,8 +5881,9 @@
 values for the icon grid, looking for a free space. The default
 grid is 3 by 3 pixels which gives a tightly packed appearance. To
 get a more regular appearance use a grid larger than your largest
-icon. Currently there is no way to clip an icon to a maximum
-size. An
+icon. Use the
+.I IconSize
+definition to clip an icon to a maximum size. An
 .I IconGrid
 definition must follow the
 .B IconBox
@@ -5913,6 +5914,42 @@
 .EX
 Style * IconBox -80x240-1-1, IconFill b r
 .EE
+.I IconSize
+sets limits on the size of an icon image.  Both user-provided
+and application-provided icon images are affected.
+.EX
+.RI IconSize  [  width   height  [  maxwidth   maxheight  ] ]
+.EE
+All arguments are measured in pixels.  When all four arguments are
+passed to
+.I IconSize,
+.I width
+and
+.I height
+represent the minimum size of an icon, and
+.I maxwidth
+and
+.I maxheight
+represent the maximum size of an icon.  Icon images that are smaller
+than the minimum size are padded.  Icon images that are bigger than
+the maximum size are clipped.
+
+If only two arguments are passed to
+.I 

Re: [Patch] MinIconSize/MaxIconSize

2002-06-24 Thread Steve Talley
Dmitry Yu. Bolkhovityanov wrote:

 On Sun, 23 Jun 2002, Steve Talley wrote:

   Since this is the main usage, is this possible to change the
   syntax to:
  
 Style * IconSize x y[, x2 y2]
  
   where one pair means both min and max values?
 
  Excellent idea.  Certainly simplifies the syntax.

 A small comment: IconSize suggests that icons fill be somehow
 forced (shrinked/grown) to specified size.  Isn't IconSizeLimits a
 more intuitive name?

Hi Dmitry,

When IconSize is only passed two arguments (which is likely the most
common scenario), all icons are indeed forced to the given size.  So I
think the name IconSize makes sense.

Thanks,

Steve
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


fvwm/fvwm.1 spelling fixes

2002-06-24 Thread Anders Andersson
Here is a patch against todays CVS version of fvwm.1 which fixes some
spelling errors.

-- 
Anders Andersson [EMAIL PROTECTED]
UNIX, Networking and Security consultant
+46 (0)705 87 53 35
Index: fvwm.1
===
RCS file: /home/cvs/fvwm/fvwm/fvwm/fvwm.1,v
retrieving revision 1.24
diff -u -r1.24 fvwm.1
--- fvwm.1  2002/06/24 10:53:07 1.24
+++ fvwm.1  2002/06/24 16:40:05
@@ -61,7 +61,7 @@
 .if t .sp .5
 ..
 .ta .3i .6i .9i 1.2i 1.5i 1.8i
-.TH FVWM 1 24 Juny 2002 FVWM FVWM 2.5.2
+.TH FVWM 1 24 June 2002 FVWM FVWM 2.5.2
 .UC
 .SH NAME
 
@@ -452,7 +452,7 @@
 Style * IconBox [EMAIL PROTECTED]
 .EE
 
-Xinerama support can be configured to use a primary screen.  Fwvm
+Xinerama support can be configured to use a primary screen.  Fvwm
 can be configured to place new windows and icons on this screen.
 The primary screen is screen 0 by default but can be changed with
 the
@@ -1034,7 +1034,7 @@
 .EE
 then, if either loading the Xft font fails or fvwm has no Xft support,
 fvwm loads the font -adobe-courier-bold-r-normal--14-*. This
-allows for writting portable configuration files.
+allows for writing portable configuration files.
 
 .SH FONT AND STRING ENCODING
 
@@ -1459,7 +1459,7 @@
 + I Echo $$d $[page.nx] $c
 .EE
 
-Note: If this funtion is called outside a window context, it will
+Note: If this function is called outside a window context, it will
 print $c instead of the class name.  It is usually not enough to
 have the pointer over a window to have a context window.  To force
 using the window with the focus, the
@@ -1656,7 +1656,7 @@
 $[pointer.cy]
 .in +.3i
 These return the position of the pointer in the client portion of
-th eselected window.  If the pointer is not on the screen, the
+the selected window.  If the pointer is not on the screen, the
 window is shaded or iconified or no window is selected, these
 variables are not expanded.
 
@@ -2601,7 +2601,7 @@
 requires an integer value between 51 and 100.  Normally, when the
 pointer is over a menu item with a sub menu and the pointer enters
 the area that starts at 75% of the menu width, the sub menu is
-shown immediately.  This percantage can be changed with
+shown immediately.  This percentage can be changed with
 .IR PopupActiveArea .
 Setting this value to 100 disables this kind of automatic popups
 altogether.  The default value is restored if no or an illegal
@@ -2685,7 +2685,7 @@
 .B WindowList
 navigation.  The key name is a standard X11 key name as defined in
 .IR /usr/include/X11/keysymdef.h ,
-with the leading XK_ omitted.  To disable this behaviour, omit
+with the leading XK_ omitted.  To disable this behavior, omit
 the key name.
 
 Note: Some X servers do not support KeyRelease events.
@@ -3720,7 +3720,7 @@
 .B Deschedule
 command to remove the scheduled command before it is executed.  If
 no id is given, fvwm uses negative id numbers, starting with -1
-and descreasing by one with each use of the
+and decreasing by one with each use of the
 .B Schedule
 command.
 Note that the
@@ -3911,7 +3911,7 @@
 .I CurrentAtEnd
 option the currently focused window (if any) is shown at the bottom
 of the list.  This is mostly intended for simulating the Alt-Tab
-behaviour in another GUI.
+behavior in another GUI.
 
 .I IconifiedAtEnd
 makes iconified windows be moved to the end of the list.  This is also
@@ -4813,7 +4813,7 @@
 .IR WindowShadeAlwaysLazy  and  WindowShadeBusy .
 option of the
 .B Style
-command.  Exmaples:
+command.  Examples:
 .EX
 Style * WindowShadeShrinks, WindowShadeSteps 20, WindowShadeLazy
 Mouse 1 S - WindowShade North
@@ -4888,7 +4888,7 @@
 .EE
 If the
 .I Modifiers
-arggument is the string default, fvwm reverts back to the
+argument is the string default, fvwm reverts back to the
 default value L.
 
 .I Important Note:
@@ -5034,7 +5034,7 @@
 the root window, 'W' for an application window, 'D' for a desktop
 application (as kdesktop or Nautilus desktop), 'T' for a window
 title-bar, 'S' for a window side, top, or bottom bar, '[', ']',
-\'-' and '_' for the left, rigth, top or bottom side only, 'F' for
+\'-' and '_' for the left, right, top or bottom side only, 'F' for
 a window frame (the corners), '', '^', '' and 'v' for the top
 left, top right, bottom right or bottom left corner, 'I' for an
 Icon window, or '0' through '9' for title-bar buttons, or any
@@ -5556,7 +5556,7 @@
 .IR RightTitleRotatedCCW  if  TitleAtRight
 is used.  The defaults can be restored with
 .IR LeftTitleRotatedCCW  and  RightTitleRotatedCW .
-A normal horisontal text may be rotated as well with
+A normal horizontal text may be rotated as well with
 .IR TopTitleRotated  if  TitleAtTop
 is used, and with
 .IR BottomTitleRotated  if  TitleAtBottom
@@ -5574,7 +5574,7 @@
 
 .I Color
 takes two arguments.  The first is the window-label text color and
-the second is the window decoration's normal background color. The
+the second is the window decorations normal background color. The
 two colors 

Re: [Patch] MinIconSize/MaxIconSize

2002-06-24 Thread Mikhael Goikhman
Ok, I have applied the patch with some reindentation.
Also fixed a gcc warning and an error message when disabling the feature.

Just a note, IconSize requires Recapture as of now.

Please include ChangeLog, AUTHORS and NEWS changes in the next patch.

Regards,
Mikhael.
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


Re: fvwm/fvwm.1 spelling fixes

2002-06-24 Thread Mikhael Goikhman
It seems you verified the whole man page. :)
I am sure man pages of the modules have some spelling errors too...

Sometimes in the future please do cvs diff -D 2002-02-24 -D now fvwm.1
and continue to keep it correct.

Just a small note, behaviour is a correct alternative (or even primary)
spelling by my dictionary.

Regards,
Mikhael.
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]