Re: [fw-general] How do I get my patch applied?
On 17 Jun 2008, at 14:18, Matthew Weier O'Phinney wrote: -- Carlton Gibson <[EMAIL PROTECTED]> wrote (on Tuesday, 17 June 2008, 09:31 AM +0100): I'm a beginner at the whole open source community-reviewed project thing and despite promises that "Contributing is easier than you think" am finding the ZF workflow quite hard to understand -- specifically, in this case, I understood from the wiki that I'd need to put my patch forward for review, but I can't see a link anywhere for THAT. Perhaps I've already done the right thing, but if so that's more luck than anything else -- and it's anything but clear to a newbie. Can I just ask for some advice from more seasoned pros? Carlton -- this is one area that we're still working on improving, and my apologies at how frustrating this is. Matthew -- thanks for getting back to me; I appreciate that there's masses going on with the framework and that it is a question of available resources... There might be a kind of *long tail* argument for (Zend itself even) prioritising the improvements here: despite limited lead developer time, the sum of the contributions from the tail may very quickly pay back the cost of improvements if only they could be encouraged/ captured. This would also have permanent benefits for the speed of the framework's development -- we would all benefit if lead developers were free to rush ahead knowing a whole wave of users could easily pick up any dropped fragments behind them. (Just thoughts :-) We will be reviewing issues for inclusion with 1.6 (and potentially another bugfix release of 1.5) in the coming weeks. Those that have patches are usually given higher priority as, well, quite simply, the work has been done. :-) Somebody with SVN karma will then apply the patch, and write any necessary tests to exercise it (hint, if you haven't written a test case, do so and attach it!). Test case it is then! (Thanks) Regards, Carlton
Re: [fw-general] How do I get my patch applied?
-- Carlton Gibson <[EMAIL PROTECTED]> wrote (on Tuesday, 17 June 2008, 09:31 AM +0100): > I've written a patch for an issue with Zend_Filter_Input. > ( http://framework.zend.com/issues/browse/ZF-3100 ). > > Not sure what else to do, I've uploaded it to the issue tracker. And I'm > wondering now, what next? > > I'm a beginner at the whole open source community-reviewed project thing > and despite promises that "Contributing is easier than you think" am > finding the ZF workflow quite hard to understand -- specifically, in this > case, I understood from the wiki that I'd need to put my patch forward > for review, but I can't see a link anywhere for THAT. Perhaps I've > already done the right thing, but if so that's more luck than anything > else -- and it's anything but clear to a newbie. > > Can I just ask for some advice from more seasoned pros? > > I'd like to go on and document the patch etc but I'm just sure of the > workflow -- I continually seem to spend the time I could be spending on > the ZF trying to work out what to do next/first by browsing big circles > in the issue tracker/wiki. Perhaps this is just me :) but if someone who > does this regularly could outline the steps *they would take* when > patching a simple issue, that would be a great help. Carlton -- this is one area that we're still working on improving, and my apologies at how frustrating this is. We will be reviewing issues for inclusion with 1.6 (and potentially another bugfix release of 1.5) in the coming weeks. Those that have patches are usually given higher priority as, well, quite simply, the work has been done. :-) Somebody with SVN karma will then apply the patch, and write any necessary tests to exercise it (hint, if you haven't written a test case, do so and attach it!). -- Matthew Weier O'Phinney Software Architect | [EMAIL PROTECTED] Zend Framework | http://framework.zend.com/
[fw-general] How do I get my patch applied?
Hi all, I've written a patch for an issue with Zend_Filter_Input. ( http://framework.zend.com/issues/browse/ZF-3100 ). Not sure what else to do, I've uploaded it to the issue tracker. And I'm wondering now, what next? I'm a beginner at the whole open source community-reviewed project thing and despite promises that "Contributing is easier than you think" am finding the ZF workflow quite hard to understand -- specifically, in this case, I understood from the wiki that I'd need to put my patch forward for review, but I can't see a link anywhere for THAT. Perhaps I've already done the right thing, but if so that's more luck than anything else -- and it's anything but clear to a newbie. Can I just ask for some advice from more seasoned pros? I'd like to go on and document the patch etc but I'm just sure of the workflow -- I continually seem to spend the time I could be spending on the ZF trying to work out what to do next/first by browsing big circles in the issue tracker/wiki. Perhaps this is just me :) but if someone who does this regularly could outline the steps *they would take* when patching a simple issue, that would be a great help. Thanks, Carlton
