[Ganglia-developers] Patches for Ganglia
Hi All I have been using Ganglia on a test cluster. I needed to use Ganglia to collect data to be fed to another application. This required modifications to the Ganglia source code and consequently I have been building Ganglia from source. The OS is Centos is 5.8/RHEL5. The original work was on 3.3.1. I have just upgraded to 3.4.0 and reconstituted the patches as 'git diffs'. I would like to offer them back for inclusion in the next release of Ganglia. Here are the patches: Errors: diffgit.err_dbg_attributes - added attributes to dbg and err functions (may not work on non-linux) diffgit.format_errors - fixed incorrect format revealed by the err_dbg_attributes patch including one format mismatch (bug) diffgit.hash_memory_leak - added free call to prevent memory leak diffgit.init_d_0 - specify debug level of 0 on start to prevent boot failure diffgit.missing_headers - some missing #includes diffgit.procstat_return - fix incorrect NULL return in procstat.py diffgit.static_debug_level - make debug_level static diffgit.static_init_sockaddr - make function static diffgit.unsafe_realloc - fixed unsafe use of realloc (this should be applied) Cosmetic: diffgit.diskstat_comment - incorrect comment in diskstat.py Enhancements: diffgit.cciss_c0d0 - modifies diskstat.py to cope with HP Smartarray disk devices diffgit.diskstat_sectors - added read_sectors and write_sectors metrics diffgit.dumpfile - added option to dump data to text file (requires sigterm patch) diffgit.num_sources - explicitly specify num_sources from config file diffgit.sigterm - add sane SIGTERM handling diffgit.trace_msg - add trace_msg call which allows scaled debug msgs Site specific (may not be generally applicable): diffgit.multicpu - change multicpu metric names so that they can be parsed more easily My project is coming to an end and I will not have much time to use the recommended procedure involving 'git clone' Please advise on how best to submit these. Regards Paul -- Paul Hewlett X25250 http://www.theregister.co.uk/2012/06/25/rbs_natwest_what_went_wrong/ ARM Ltd 110 Fulbourn Road, Cambridge, CB1 9NJ Tel: +44 (0)1223 405923 skype: paul-at-arm www.arm.comhttp://www.arm.com/ -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.-- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
Re: [Ganglia-developers] Patches for Ganglia
On Wed, Aug 8, 2012 at 4:44 AM, Paul Hewlett paul.hewl...@arm.com wrote: Hi All I have been using Ganglia on a test cluster. I needed to use Ganglia to collect data to be fed to another application. This required modifications to the Ganglia source code and consequently I have been building Ganglia from source. The OS is Centos is 5.8/RHEL5. The original work was on 3.3.1. I have just upgraded to 3.4.0 and reconstituted the patches as 'git diffs'. I would like to offer them back for inclusion in the next release of Ganglia. Here are the patches: Errors: diffgit.err_dbg_attributes - added attributes to dbg and err functions (may not work on non-linux) diffgit.format_errors - fixed incorrect format revealed by the err_dbg_attributes patch including one format mismatch (bug) diffgit.hash_memory_leak - added free call to prevent memory leak diffgit.init_d_0 - specify debug level of 0 on start to prevent boot failure diffgit.missing_headers - some missing #includes diffgit.procstat_return - fix incorrect NULL return in procstat.py diffgit.static_debug_level - make debug_level static diffgit.static_init_sockaddr - make function static diffgit.unsafe_realloc - fixed unsafe use of realloc (this should be applied) Cosmetic: diffgit.diskstat_comment - incorrect comment in diskstat.py Enhancements: diffgit.cciss_c0d0 - modifies diskstat.py to cope with HP Smartarray disk devices diffgit.diskstat_sectors - added read_sectors and write_sectors metrics diffgit.dumpfile - added option to dump data to text file (requires sigterm patch) diffgit.num_sources - explicitly specify num_sources from config file diffgit.sigterm - add sane SIGTERM handling diffgit.trace_msg - add trace_msg call which allows scaled debug msgs Site specific (may not be generally applicable): diffgit.multicpu - change multicpu metric names so that they can be parsed more easily My project is coming to an end and I will not have much time to use the recommended procedure involving ‘git clone’ Please advise on how best to submit these. If you don't have the time or desire to use the github pull request system, please post a unified diff to this list, and one of the maintainers will merge your changes in. Thanks, Jeff -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
[Ganglia-developers] updating git user IDs
I've just added an authors.txt file to the git repo Can people please: a) find your user ID (or IDs) from Sourceforge b) put in your real name and preferred email address c) commit your change to the file There is no technical reason for authors.txt to be in the repo, I just thought this would be a convenient way to do this. I don't think git validates it in anyway, but I think it is convenient if each user is consistent, always using the same name/email. At some point later in the month, I will try to use the git-filter-branch method to amend the repo to contain the correct author details for all past commits. For anyone who has not updated the file, I will simply use one of the following: - the name/email you use in a recent github commit - if no github commits, the name/email you last used on the public email list -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
