Re: [ping] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
On Tue, 2013-09-10 12:01:34 +1200, Maxim Kuvyrkov ma...@kugelworks.com wrote: On 7/09/2013, at 1:31 AM, Jan-Benedict Glaw wrote: This however still seems to have issues in a current build: http://toolchain.lug-owl.de/buildbot/showlog.php?id=10520mode=view Mn10300-linux does not appear to be supporting linux. Mn10300-linux target specifier expands into mn10300-unknown-linux-gnu, where *-gnu implies using Glibc library, which doesn't have mn10300 port. Uh, I would have expected an error message then (from configury), but you may well be right. I changed over to mn10300-elf for now. MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of:http://www.chiark.greenend.org.uk/~sgtatham/bugs.html the second : signature.asc Description: Digital signature
Re: [ping] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
On 7/09/2013, at 1:31 AM, Jan-Benedict Glaw wrote: On Mon, 2013-08-26 12:51:53 +0200, Jan-Benedict Glaw jbg...@lug-owl.de wrote: On Tue, 2013-08-20 11:24:31 +0400, Alexander Ivchenko aivch...@gmail.com wrote: Hi, thanks for cathing this. I certainly missed that OPTION_BIONIC is not defined for linux targets that do not include config/linux.h in their tm.h. This patch fixed build for powerpc64le-linux and mn10300-linux. linux_libc, LIBC_GLIBC, LIBC_BIONIC should be defined for all targets. [...] Seems the commit at Thu Sep 5 13:01:35 2013 (CEST) fixed most of the fallout. Thanks! mn10300-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9657mode=view This however still seems to have issues in a current build: http://toolchain.lug-owl.de/buildbot/showlog.php?id=10520mode=view Jan-Benedict, Mn10300-linux does not appear to be supporting linux. Mn10300-linux target specifier expands into mn10300-unknown-linux-gnu, where *-gnu implies using Glibc library, which doesn't have mn10300 port. Jeff, You are mn10300 maintainer, is building GCC for mn10300-unknown-linux-gnu supposed to work? Thanks, -- Maxim Kuvyrkov www.kugelworks.com
Re: [ping] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
On Mon, 2013-08-26 12:51:53 +0200, Jan-Benedict Glaw jbg...@lug-owl.de wrote: On Tue, 2013-08-20 11:24:31 +0400, Alexander Ivchenko aivch...@gmail.com wrote: Hi, thanks for cathing this. I certainly missed that OPTION_BIONIC is not defined for linux targets that do not include config/linux.h in their tm.h. This patch fixed build for powerpc64le-linux and mn10300-linux. linux_libc, LIBC_GLIBC, LIBC_BIONIC should be defined for all targets. [...] Seems the commit at Thu Sep 5 13:01:35 2013 (CEST) fixed most of the fallout. Thanks! mn10300-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9657mode=view This however still seems to have issues in a current build: http://toolchain.lug-owl.de/buildbot/showlog.php?id=10520mode=view g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I../../../../gcc/gcc -I../../../../gcc/gcc/. -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace-I. -I. -I../../../../gcc/gcc -I../../../../gcc/gcc/. -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace \ ../../../../gcc/gcc/config/linux-android.c ../../../../gcc/gcc/config/linux-android.c: In function ‘bool linux_android_libc_has_function(function_class)’: ../../../../gcc/gcc/config/linux-android.c:38:7: error: ‘OPTION_GLIBC’ was not declared in this scope if (OPTION_GLIBC) ^ ../../../../gcc/gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope if (OPTION_BIONIC) ^ make[2]: *** [linux-android.o] Error 1 MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: Träume nicht von Deinem Leben: Lebe Deinen Traum! the second : signature.asc Description: Digital signature
Re: [ping^2] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
On Mon, 2 Sep 2013, David Edelsohn wrote: On Mon, Sep 2, 2013 at 5:28 PM, Jan-Benedict Glaw jbg...@lug-owl.de wrote: Hi! On Mon, 2013-08-26 12:51:53 +0200, Jan-Benedict Glaw jbg...@lug-owl.de wrote: On Tue, 2013-08-20 11:24:31 +0400, Alexander Ivchenko aivch...@gmail.com wrote: I certainly missed that OPTION_BIONIC is not defined for linux targets that do not include config/linux.h in their tm.h. This patch fixed build for powerpc64le-linux and mn10300-linux. linux_libc, LIBC_GLIBC, LIBC_BIONIC should be defined for all targets. [...] It would be nice if somebody would review this patch. The initial commit had fallout on a few targets: alpha-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9537mode=view mn10300-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9657mode=view sparc64-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9655mode=view tic6x-uclinux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9647mode=view powerpc64le-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9638mode=view (all other PPC variants, too.) This is still broken. Today it's two weeks. Can we please have the patch ACKed or revert the patch? I agree. This is ridiculous. Would some global reviewer please approve the fix? Patch is ok. _Please_ mark patches properly and send them in a separate thread. Otherwise I just notice [buildbot] and skip the mail. A proper subject would be [PATCH] Unbreak bootstrap on XYZ Richard.
[ping^2] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
Hi! On Mon, 2013-08-26 12:51:53 +0200, Jan-Benedict Glaw jbg...@lug-owl.de wrote: On Tue, 2013-08-20 11:24:31 +0400, Alexander Ivchenko aivch...@gmail.com wrote: I certainly missed that OPTION_BIONIC is not defined for linux targets that do not include config/linux.h in their tm.h. This patch fixed build for powerpc64le-linux and mn10300-linux. linux_libc, LIBC_GLIBC, LIBC_BIONIC should be defined for all targets. [...] It would be nice if somebody would review this patch. The initial commit had fallout on a few targets: alpha-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9537mode=view mn10300-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9657mode=view sparc64-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9655mode=view tic6x-uclinux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9647mode=view powerpc64le-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9638mode=view (all other PPC variants, too.) This is still broken. Today it's two weeks. Can we please have the patch ACKed or revert the patch? MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of:If it doesn't work, force it. the second : If it breaks, it needed replacing anyway. signature.asc Description: Digital signature
Re: [ping^2] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
On Mon, Sep 2, 2013 at 5:28 PM, Jan-Benedict Glaw jbg...@lug-owl.de wrote: Hi! On Mon, 2013-08-26 12:51:53 +0200, Jan-Benedict Glaw jbg...@lug-owl.de wrote: On Tue, 2013-08-20 11:24:31 +0400, Alexander Ivchenko aivch...@gmail.com wrote: I certainly missed that OPTION_BIONIC is not defined for linux targets that do not include config/linux.h in their tm.h. This patch fixed build for powerpc64le-linux and mn10300-linux. linux_libc, LIBC_GLIBC, LIBC_BIONIC should be defined for all targets. [...] It would be nice if somebody would review this patch. The initial commit had fallout on a few targets: alpha-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9537mode=view mn10300-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9657mode=view sparc64-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9655mode=view tic6x-uclinux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9647mode=view powerpc64le-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9638mode=view (all other PPC variants, too.) This is still broken. Today it's two weeks. Can we please have the patch ACKed or revert the patch? I agree. This is ridiculous. Would some global reviewer please approve the fix? Thanks, David
[ping] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
Hi! On Tue, 2013-08-20 11:24:31 +0400, Alexander Ivchenko aivch...@gmail.com wrote: Hi, thanks for cathing this. I certainly missed that OPTION_BIONIC is not defined for linux targets that do not include config/linux.h in their tm.h. This patch fixed build for powerpc64le-linux and mn10300-linux. linux_libc, LIBC_GLIBC, LIBC_BIONIC should be defined for all targets. [...] It would be nice if somebody would review this patch. The initial commit had fallout on a few targets: alpha-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9537mode=view mn10300-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9657mode=view sparc64-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9655mode=view tic6x-uclinux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9647mode=view powerpc64le-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9638mode=view (all other PPC variants, too.) Thanks, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: http://www.eyrie.org/~eagle/faqs/questions.html the second : signature.asc Description: Digital signature
Re: [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
Hi, thanks for cathing this.
I certainly missed that OPTION_BIONIC is not defined for linux targets
that do not include config/linux.h in their tm.h.
This patch fixed build for powerpc64le-linux and mn10300-linux.
linux_libc, LIBC_GLIBC, LIBC_BIONIC should be defined for all targets.
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 56e6fd4..6bb18f8 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2013-08-20 Alexander Ivchenko alexander.ivche...@intel.com
+
+ * config/linux-android.c (linux_android_libc_has_function): Fix
+ checks for libc.
+
2013-08-20 Zhouyi Zhou yizhouz...@ict.ac.cn
* tree-ssa-ccp.c (get_default_value): Remove redundant condition
diff --git a/gcc/config/linux-android.c b/gcc/config/linux-android.c
index 4a4b48d..e9d9e9a 100644
--- a/gcc/config/linux-android.c
+++ b/gcc/config/linux-android.c
@@ -35,9 +35,9 @@ linux_android_has_ifunc_p (void)
bool
linux_android_libc_has_function (enum function_class fn_class)
{
- if (OPTION_GLIBC)
+ if (linux_libc == LIBC_GLIBC)
return true;
- if (OPTION_BIONIC)
+ if (linux_libc == LIBC_BIONIC)
if (fn_class == function_c94
|| fn_class == function_c99_misc
|| fn_class == function_sincos)
is it OK?
thanks,
Alexander
2013/8/19 Jan-Benedict Glaw jbg...@lug-owl.de:
Hi!
My build robot[1] catched this error[2] while cross-building for
powerpc64le-linux:
g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions
-fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing
-Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic
-Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common
-DHAVE_CONFIG_H -I. -I. -I../../../../gcc/gcc -I../../../../gcc/gcc/.
-I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include
-I../../../../gcc/gcc/../libdecnumber
-I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber
-I../../../../gcc/gcc/../libbacktrace-I. -I. -I../../../../gcc/gcc
-I../../../../gcc/gcc/. -I../../../../gcc/gcc/../include
-I../../../../gcc/gcc/../libcpp/include
-I../../../../gcc/gcc/../libdecnumber
-I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber
-I../../../../gcc/gcc/../libbacktrace \
../../../../gcc/gcc/config/linux-android.c
../../../../gcc/gcc/config/linux-android.c: In function ‘bool
linux_android_libc_has_function(function_class)’:
../../../../gcc/gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was
not declared in this scope
if (OPTION_BIONIC)
^
make[2]: *** [linux-android.o] Error 1
Probably introduced with r201838
(http://gcc.gnu.org/viewcvs/gcc?view=revisionrevision=201838). I
guess it's just a forgotten chunk.
MfG, JBG
[1] http://toolchain.lug-owl.de/buildbot/
[2] http://toolchain.lug-owl.de/buildbot/#job8903
--
Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481
Signature of: http://perl.plover.com/Questions.html
the second :
[buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
Hi! My build robot[1] catched this error[2] while cross-building for powerpc64le-linux: g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I../../../../gcc/gcc -I../../../../gcc/gcc/. -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace-I. -I. -I../../../../gcc/gcc -I../../../../gcc/gcc/. -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace \ ../../../../gcc/gcc/config/linux-android.c ../../../../gcc/gcc/config/linux-android.c: In function ‘bool linux_android_libc_has_function(function_class)’: ../../../../gcc/gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope if (OPTION_BIONIC) ^ make[2]: *** [linux-android.o] Error 1 Probably introduced with r201838 (http://gcc.gnu.org/viewcvs/gcc?view=revisionrevision=201838). I guess it's just a forgotten chunk. MfG, JBG [1] http://toolchain.lug-owl.de/buildbot/ [2] http://toolchain.lug-owl.de/buildbot/#job8903 -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: http://perl.plover.com/Questions.html the second : signature.asc Description: Digital signature
