[Bug other/80895] format not a string literal and no format arguments; in GCC itself

2017-05-26 Thread miloradovsky at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80895

Andrew Miloradovsky  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #8 from Andrew Miloradovsky  ---
Well, then it seems like

- the entire patch is wrong, and all those changes shouldn't be made
- inserting the comment before every diagnostic output call is not worth it
- in future, this mechanism may be changed, to filter out the warnings
- but, ATM, format-security should always be disabled when compiling GCC
- so the "bug" may be closed now; at least I learned something new; thanks

[Bug other/80895] format not a string literal and no format arguments; in GCC itself

2017-05-26 Thread miloradovsky at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80895

--- Comment #5 from Andrew Miloradovsky  ---
After all I might simply insert that comment everywhere, to reduce confusion.

[Bug other/80895] format not a string literal and no format arguments; in GCC itself

2017-05-26 Thread miloradovsky at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80895

--- Comment #4 from Andrew Miloradovsky  ---
Hmm, man printf(3) doesn't tell anything about the formats, what are they for?

[Bug other/80895] format not a string literal and no format arguments; in GCC itself

2017-05-26 Thread miloradovsky at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80895

Andrew Miloradovsky  changed:

   What|Removed |Added

  Attachment #41428|0   |1
is obsolete||

--- Comment #2 from Andrew Miloradovsky  ---
Created attachment 41429
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=41429=edit
excluding few cases

where it's said explicitly that `msgid` may be a format string

[Bug other/80895] New: format not a string literal and no format arguments; in GCC itself

2017-05-26 Thread miloradovsky at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80895

Bug ID: 80895
   Summary: format not a string literal and no format arguments;
in GCC itself
   Product: gcc
   Version: unknown
Status: UNCONFIRMED
  Severity: normal
  Priority: P3
 Component: other
  Assignee: unassigned at gcc dot gnu.org
  Reporter: miloradovsky at gmail dot com
  Target Milestone: ---

Created attachment 41428
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=41428=edit
a trivial patch

GCC couldn't be compiled with `-Werror=format-security`, now it can.
The motivation is here (although that post is somewhat outdated):

-
https://unix.stackexchange.com/questions/356232/disabling-the-security-hardening-options-for-a-nix-shell-environment