[Bug ada/115133] [15 regression] s-oslock__solaris.ads doesn't compile
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115133 Eric Botcazou changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #9 from Eric Botcazou --- Thanks for reporting the problem.
[Bug ada/115133] [15 regression] s-oslock__solaris.ads doesn't compile
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115133 --- Comment #8 from GCC Commits --- The master branch has been updated by Eric Botcazou : https://gcc.gnu.org/g:5812e1bbb1c8a7a90d995a0165cddae4d450d6cf commit r15-641-g5812e1bbb1c8a7a90d995a0165cddae4d450d6cf Author: Eric Botcazou Date: Sat May 18 00:21:56 2024 +0200 Fix Ada runtime library breakage on Solaris The recent changes made to the runtime library broke its build on Solaris because it uses Solaris threads instead of POSIX threads on this platform. gcc/ada/ PR ada/115133 * libgnarl/s-osinte__solaris.ads (mutex_t): Fix typo. * libgnarl/s-taprop__solaris.adb (Record_Lock): Add conversion. (Check_Sleep): Likewise. (Record_Wakeup): Likewise. (Check_Unlock): Likewise. * libgnarl/s-tasini.adb (Initialize_RTS_Lock): Add pragma Import on the overlaid variable. (Finalize_RTS_Lock): Likewise. (Acquire_RTS_Lock): Likewise. (Release_RTS_Lock): Likewise. * libgnarl/s-taspri__solaris.ads (To_RTS_Lock_Ptr): New instance of Ada.Unchecked_Conversion. * libgnat/s-oslock__solaris.ads: Add with clause for Ada.Unchecked_Conversion. (array_type_9): Add missing name qualification. (record_type_3): Likewise. (mutex_t): Fix formatting.
[Bug ada/115133] [15 regression] s-oslock__solaris.ads doesn't compile
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115133 --- Comment #7 from ro at CeBiTec dot Uni-Bielefeld.DE --- > --- Comment #6 from Eric Botcazou --- > Created attachment 58230 > --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58230=edit > Tentative fix > > Hopefully the final version of it. Yes, make all-target-libada completed just fine with this. Thanks!
[Bug ada/115133] [15 regression] s-oslock__solaris.ads doesn't compile
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115133 Eric Botcazou changed: What|Removed |Added Attachment #58229|0 |1 is obsolete|| --- Comment #6 from Eric Botcazou --- Created attachment 58230 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58230=edit Tentative fix Hopefully the final version of it.
[Bug ada/115133] [15 regression] s-oslock__solaris.ads doesn't compile
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115133 --- Comment #5 from ro at CeBiTec dot Uni-Bielefeld.DE --- > --- Comment #4 from Eric Botcazou --- > Created attachment 58229 > --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58229=edit > Tentative fix > > The complete version of it. Thanks. There's one issue left: s-tasini.adb:248:11: warning: default initialization of "Lock" may modify overlaid storage [-gnatwo] s-tasini.adb:248:11: warning: use pragma Import for "Lock" to suppress initialization (RM B.1(24)) [-gnatwo] s-tasini.adb:260:11: warning: default initialization of "Lock" may modify overlaid storage [-gnatwo] s-tasini.adb:260:11: warning: use pragma Import for "Lock" to suppress initialization (RM B.1(24)) [-gnatwo] s-tasini.adb:272:11: warning: default initialization of "Lock" may modify overlaid storage [-gnatwo] s-tasini.adb:272:11: warning: use pragma Import for "Lock" to suppress initialization (RM B.1(24)) [-gnatwo] s-tasini.adb:284:11: warning: default initialization of "Lock" may modify overlaid storage [-gnatwo] s-tasini.adb:284:11: warning: use pragma Import for "Lock" to suppress initialization (RM B.1(24)) [-gnatwo]
[Bug ada/115133] [15 regression] s-oslock__solaris.ads doesn't compile
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115133 Eric Botcazou changed: What|Removed |Added Attachment #58228|0 |1 is obsolete|| --- Comment #4 from Eric Botcazou --- Created attachment 58229 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58229=edit Tentative fix The complete version of it.
[Bug ada/115133] [15 regression] s-oslock__solaris.ads doesn't compile
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115133 --- Comment #3 from Eric Botcazou --- Created attachment 58228 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58228=edit Tentative fix
[Bug ada/115133] [15 regression] s-oslock__solaris.ads doesn't compile
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115133 Eric Botcazou changed: What|Removed |Added Last reconfirmed||2024-05-17 Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Eric Botcazou --- > There's a 2-space indentation instead of the expected 3 spaces. I had > to look several times to see it, though. Maybe the error could be > clearer? Style error messages are the hardest to get right, so I won't even try. ;-) > After that, I run into > > s-taprop.adb:1402:20: error: expected type "System.Os_Locks.RTS_Lock_Ptr" > s-taprop.adb:1402:20: error: found type "System.Task_Primitives.Lock_Ptr" > s-taprop.adb:1443:57: error: expected type "System.Task_Primitives.Lock_Ptr" > s-taprop.adb:1443:57: error: found type "System.Os_Locks.RTS_Lock_Ptr" > s-taprop.adb:1471:20: error: expected type "System.Os_Locks.RTS_Lock_Ptr" > s-taprop.adb:1471:20: error: found type "System.Task_Primitives.Lock_Ptr" > s-taprop.adb:1552:57: error: expected type "System.Task_Primitives.Lock_Ptr" > s-taprop.adb:1552:57: error: found type "System.Os_Locks.RTS_Lock_Ptr" > make[6]: *** [../gcc-interface/Makefile:306: s-taprop.o] Error 1 Sorry about the mess, tentative fix to be attached.
[Bug ada/115133] [15 regression] s-oslock__solaris.ads doesn't compile
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115133 --- Comment #1 from ro at CeBiTec dot Uni-Bielefeld.DE --- > until one runs into > > s-oslock.ads:83:03: (style) bad indentation [-gnaty0] > make[6]: *** [../gcc-interface/Makefile:306: a-undesu.o] Error 1 > > No idea what's wrong here, though. There's a 2-space indentation instead of the expected 3 spaces. I had to look several times to see it, though. Maybe the error could be clearer? After that, I run into s-taprop.adb:1402:20: error: expected type "System.Os_Locks.RTS_Lock_Ptr" s-taprop.adb:1402:20: error: found type "System.Task_Primitives.Lock_Ptr" s-taprop.adb:1443:57: error: expected type "System.Task_Primitives.Lock_Ptr" s-taprop.adb:1443:57: error: found type "System.Os_Locks.RTS_Lock_Ptr" s-taprop.adb:1471:20: error: expected type "System.Os_Locks.RTS_Lock_Ptr" s-taprop.adb:1471:20: error: found type "System.Task_Primitives.Lock_Ptr" s-taprop.adb:1552:57: error: expected type "System.Task_Primitives.Lock_Ptr" s-taprop.adb:1552:57: error: found type "System.Os_Locks.RTS_Lock_Ptr" make[6]: *** [../gcc-interface/Makefile:306: s-taprop.o] Error 1 but am stuck.
[Bug ada/115133] [15 regression] s-oslock__solaris.ads doesn't compile
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115133 Rainer Orth changed: What|Removed |Added Target Milestone|--- |15.0
