[Bug bootstrap/111852] [14 regression] r14-4339-geaa41a6dc127d8 breaks building with gcc 4.8.5

2023-10-18 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111852

--- Comment #6 from Jakub Jelinek  ---
In several gcc ml (or gcc-patches, don't remember) threads it was discussed
whether we should switch to C++14 as the implementation language, that would
bump to the bootstrap compiler requirement to GCC 5 (core language features,
maybe GCC 6 if we need full library side, certainly GCC 6 switched to
-std=gnu++14 by default).
Today on IRC this was discussed again, and I think Richi proposed switching
just for GCC 15, not 14.

[Bug bootstrap/111852] [14 regression] r14-4339-geaa41a6dc127d8 breaks building with gcc 4.8.5

2023-10-18 Thread seurer at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111852

--- Comment #5 from seurer at gcc dot gnu.org ---
Yup, thanks!

In another 4.8.5 breakage PR someone mentioned removing that as the minimum
required compiler level.  Has there been any more discussion of that?

[Bug bootstrap/111852] [14 regression] r14-4339-geaa41a6dc127d8 breaks building with gcc 4.8.5

2023-10-18 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111852

Jakub Jelinek  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #4 from Jakub Jelinek  ---
Should be worked around now.

[Bug bootstrap/111852] [14 regression] r14-4339-geaa41a6dc127d8 breaks building with gcc 4.8.5

2023-10-18 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111852

--- Comment #3 from CVS Commits  ---
The master branch has been updated by Jakub Jelinek :

https://gcc.gnu.org/g:bc4bd69faf986326f6b0fd0400cdd6871577afd1

commit r14-4722-gbc4bd69faf986326f6b0fd0400cdd6871577afd1
Author: Jakub Jelinek 
Date:   Wed Oct 18 17:01:26 2023 +0200

cse: Workaround GCC < 5 bug in cse_insn [PR111852]

Before the r5-3834 commit for PR63362, GCC 4.8-4.9 refuses to compile
cse.cc which contains a variable with rtx_def type, because rtx_def
contains a union with poly_uint16 element.  poly_int template has
defaulted default constructor and a variadic template constructor which
could have empty parameter pack. GCC < 5 treated it as non-trivially
constructible class and deleted rtunion and rtx_def default constructors.

For the cse_insn purposes, all we need is a variable with size and
alignment
of rtx_def, not necessarily rtx_def itself, which we then memset to 0 and
fill in like rtx is normally allocated from heap, so this patch for
GCC_VERSION < 5000 uses an unsigned char array of the right size/alignment.

2023-10-18  Jakub Jelinek  

PR bootstrap/111852
* cse.cc (cse_insn): Add workaround for GCC 4.8-4.9, instead of
using rtx_def type for memory_extend_buf, use unsigned char
arrayy with size of rtx_def and its alignment.

[Bug bootstrap/111852] [14 regression] r14-4339-geaa41a6dc127d8 breaks building with gcc 4.8.5

2023-10-18 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111852

Jakub Jelinek  changed:

   What|Removed |Added

 CC||jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek  ---
Reduced testcase
struct poly_int {
  poly_int() = default;
  template  poly_int();
};
union rtunion {
  poly_int rt_subregrt_rtx;
};
struct rtx_def {
  rtunion fld;
};
void cse_insn() { rtx_def memory_extend_buf; }
which got fixed with r5-3834 as part of PR63362 fix.

[Bug bootstrap/111852] [14 regression] r14-4339-geaa41a6dc127d8 breaks building with gcc 4.8.5

2023-10-18 Thread rguenth at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111852

Richard Biener  changed:

   What|Removed |Added

 CC||sayle at gcc dot gnu.org
   Target Milestone|--- |14.0

--- Comment #1 from Richard Biener  ---
There's a duplicate and a patch floating around.