[Bug bootstrap/36918] [4.4 regression] Bootstrap failure on sparc: assertion failure in options.c

2008-12-27 Thread pinskia at gcc dot gnu dot org 


-- 

pinskia at gcc dot gnu dot org changed:

   What|Removed |Added

 CC||pinskia at gcc dot gnu dot
   ||org
   Target Milestone|--- |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36918

[Bug bootstrap/36918] [4.4 regression] Bootstrap failure on sparc: assertion failure in options.c

2008-08-06 Thread andreast at gcc dot gnu dot org 


--- Comment #8 from andreast at gcc dot gnu dot org  2008-08-06 20:22 
---
Fixed.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36918

[Bug bootstrap/36918] [4.4 regression] Bootstrap failure on sparc: assertion failure in options.c

2008-08-06 Thread andreast at gcc dot gnu dot org 


--- Comment #9 from andreast at gcc dot gnu dot org  2008-08-06 20:23 
---
Fixed. Should set the state too 


-- 

andreast at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36918

[Bug bootstrap/36918] [4.4 regression] Bootstrap failure on sparc: assertion failure in options.c

2008-07-25 Thread andreast at gcc dot gnu dot org 


--- Comment #7 from andreast at gcc dot gnu dot org  2008-07-25 15:59 
---
Subject: Bug 36918

Author: andreast
Date: Fri Jul 25 15:59:12 2008
New Revision: 138145

URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=138145
Log:
2008-07-25  Andreas Tobler  [EMAIL PROTECTED]

PR bootstrap/36918
* config/sparc/sparc.h (DEFAULT_PCC_STRUCT_RETURN): Define
DEFAULT_PCC_STRUCT_RETURN to 127.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/sparc/sparc.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36918

[Bug bootstrap/36918] [4.4 regression] Bootstrap failure on sparc: assertion failure in options.c

2008-07-24 Thread ro at gcc dot gnu dot org 


--- Comment #1 from ro at gcc dot gnu dot org  2008-07-24 17:21 ---
Michael, could you have a look?  This seems to have been introduced by this
change:

2008-07-23  Michael Meissner  [EMAIL PROTECTED]
Karthik Kumar  [EMAIL PROTECTED]
[...]
* optc-gen.awk: Add support for TargetSave to allow a back end to
declare new fields that need to be saved when using function
specific options.  Include flags.h and target.h in the options.c
source.  Add support for Save to indicate which options can be set
for individual functions.  Generate cl_optimize_save,
cl_optimize_restore, cl_optimize_print, cl_target_option_save,
cl_target_option_restore, cl_target_option_print functions to
allow functions to use different optimization or target options.

and sparc-sun-solaris2.10 is primary platform for 4.4.


-- 

ro at gcc dot gnu dot org changed:

   What|Removed |Added

 CC||gnu at the-meissners dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36918

[Bug bootstrap/36918] [4.4 regression] Bootstrap failure on sparc: assertion failure in options.c

2008-07-24 Thread gnu at the-meissners dot org 


--- Comment #2 from gnu at the-meissners dot org  2008-07-24 18:26 ---
Subject: Re:  [4.4 regression] Bootstrap failure on
sparc: assertion failure in options.c

On Thu, Jul 24, 2008 at 05:21:10PM -, ro at gcc dot gnu dot org wrote:
 
 
 --- Comment #1 from ro at gcc dot gnu dot org  2008-07-24 17:21 ---
 Michael, could you have a look?  This seems to have been introduced by this
 change:
 
 2008-07-23  Michael Meissner  [EMAIL PROTECTED]
 Karthik Kumar  [EMAIL PROTECTED]
 [...]
 * optc-gen.awk: Add support for TargetSave to allow a back end to
 declare new fields that need to be saved when using function
 specific options.  Include flags.h and target.h in the options.c
 source.  Add support for Save to indicate which options can be set
 for individual functions.  Generate cl_optimize_save,
 cl_optimize_restore, cl_optimize_print, cl_target_option_save,
 cl_target_option_restore, cl_target_option_print functions to
 allow functions to use different optimization or target options.
 
 and sparc-sun-solaris2.10 is primary platform for 4.4.
 
 
 -- 
 
 ro at gcc dot gnu dot org changed:
 
What|Removed |Added
 
  CC||gnu at the-meissners dot org
 
 
 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36918
 
 --- You are receiving this mail because: ---
 You are on the CC list for the bug, or are watching someone who is.

This is due to DEFAULT_PCC_STRUCT_RETURN being defined as -1.  The code to
store and restore optimization options is trying to use smaller amount of
space, and so it stores the flag values into an unsigned byte instead of an
int.  The code in question is doing an assert to make sure that the value is in
range, so that when the value is restored, it get the same value.

Three possible solutions exist:
1) In sparc.h change DEFAULT_PCC_STRUCT_RETURN to be 2 instead of -1;
2) Change the default space to be signed bytes instead of unsigned;
3) Save ints instead of bytes and don't try to save space.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36918

[Bug bootstrap/36918] [4.4 regression] Bootstrap failure on sparc: assertion failure in options.c

2008-07-24 Thread andreast at gcc dot gnu dot org 


--- Comment #3 from andreast at gcc dot gnu dot org  2008-07-24 18:36 
---
I bootstrapped choice 1. No regressions.

I also prefer to save space where possible. So I'd like to avoid choice 3.

Can we also use 255 or 127 as value for DEFAULT_PCC_STRUCT_RETURN?


-- 

andreast at gcc dot gnu dot org changed:

   What|Removed |Added

 CC||andreast at gcc dot gnu dot
   ||org
 AssignedTo|unassigned at gcc dot gnu   |andreast at gcc dot gnu dot
   |dot org |org
 Status|UNCONFIRMED |ASSIGNED
 Ever Confirmed|0   |1
   Last reconfirmed|-00-00 00:00:00 |2008-07-24 18:36:20
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36918

[Bug bootstrap/36918] [4.4 regression] Bootstrap failure on sparc: assertion failure in options.c

2008-07-24 Thread gnu at the-meissners dot org 


--- Comment #5 from gnu at the-meissners dot org  2008-07-24 18:49 ---
Subject: Re:  [4.4 regression] Bootstrap failure on
sparc: assertion failure in options.c

On Thu, Jul 24, 2008 at 06:36:20PM -, andreast at gcc dot gnu dot org
wrote:
 
 
 --- Comment #3 from andreast at gcc dot gnu dot org  2008-07-24 18:36 
 ---
 I bootstrapped choice 1. No regressions.
 
 I also prefer to save space where possible. So I'd like to avoid choice 3.
 
 Can we also use 255 or 127 as value for DEFAULT_PCC_STRUCT_RETURN?

Just to echo what I said in IRC for bugzilla, right now you can use 255 or 127.
Using 127 is perhaps better in case the default is changed to use signed bytes
in the future, and 127 will work either way.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36918

[Bug bootstrap/36918] [4.4 regression] Bootstrap failure on sparc: assertion failure in options.c

2008-07-24 Thread andreast at gcc dot gnu dot org 


--- Comment #6 from andreast at gcc dot gnu dot org  2008-07-24 19:50 
---
Patch:
http://gcc.gnu.org/ml/gcc-patches/2008-07/msg01916.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36918