[Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on Darwin: config/darwin.c:3665:1: error: control reaches end of non-void function [-Werror=return-type]
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541 Dominique d'Humieres changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #14 from Dominique d'Humieres --- Closing as FIXED. Thanks for the patch.
[Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on Darwin: config/darwin.c:3665:1: error: control reaches end of non-void function [-Werror=return-type]
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541 Dominique d'Humieres changed: What|Removed |Added CC||juergen.reuter at desy dot de --- Comment #13 from Dominique d'Humieres --- *** Bug 59688 has been marked as a duplicate of this bug. ***
[Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on Darwin: config/darwin.c:3665:1: error: control reaches end of non-void function [-Werror=return-type]
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541 --- Comment #12 from Iain Sandoe --- Author: iains Date: Sun Jan 5 21:47:43 2014 New Revision: 206348 URL: http://gcc.gnu.org/viewcvs?rev=206348&root=gcc&view=rev Log: gcc: PR bootstrap/59541 * config/darwin.c (darwin_function_section): Adjust return values to correspond to optimisation changes made in r206070. Modified: trunk/gcc/ChangeLog trunk/gcc/config/darwin.c
[Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541 Dominique d'Humieres changed: What|Removed |Added CC||burnus at gcc dot gnu.org --- Comment #11 from Dominique d'Humieres --- *** Bug 59663 has been marked as a duplicate of this bug. ***
[Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541 --- Comment #10 from Dominique d'Humieres --- > Hello, > thank you for the hotfix that repaired switch/case missing return value. Nothing has been committed yet to fix darwin bootstrap!-(
[Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541 --- Comment #9 from Martin Liška --- Hello, thank you for the hotfix that repaired switch/case missing return value. Actually I was told by Jan to reproduce the functionality from varasm.c that I was able to bootstrap and test. The idea of reordering pass is to order all functions that are seen during instrumentation run and are executed during start-up of an application. So that, we do not build separate sections for .text, .text.hot and .text.startup. On the other hand: any execute function should not live in .text.unlikely and .text.startup. If so, it means that we miss profile info and these functions can be identified during debugging process. I am not familiar with darwin format, Jan do you know what could cause problem?
[Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541 --- Comment #8 from Dominique d'Humieres --- > > could someone please point me at the original post for this patch? > > I have the same question. I have finally found the answer: final patch at http://gcc.gnu.org/ml/gcc-patches/2013-12/msg01368.html OKed by Jan Hubicka at http://gcc.gnu.org/ml/gcc-patches/2013-12/msg01379.html
[Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541 --- Comment #7 from Dominique d'Humieres --- Note that on x86_64-apple-darwin10 the test gcc.dg/tree-prof/cold_partition_label.c has started to fail (compilation, -fprofile-use -D_PROFILE_USE) between r204856 (OK) and r205324 (fail). This is fixed at 206120 with the faulty part of 206070 reverted.
[Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541 Dominique d'Humieres changed: What|Removed |Added CC||jh at suse dot cz, ||marxin at gcc dot gnu.org, ||mjambor at suse dot cz --- Comment #6 from Dominique d'Humieres --- > could someone please point me at the original post for this patch? I have the same question.
[Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541 --- Comment #5 from Dominique d'Humieres --- The failure of FAIL: gcc.dg/tree-prof/crossmodule-indircall-1.c is due to the first part of http://gcc.gnu.org/viewcvs/gcc/trunk/gcc/config/darwin.c?r1=206070&r2=206069&pathrev=206070&sortby=date&view=patch.
[Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541 Iain Sandoe changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed||2013-12-19 Ever confirmed|0 |1 --- Comment #4 from Iain Sandoe --- could someone please point me at the original post for this patch? The darwin_function_section() stuff seems to be inconsistent. Is the intention to say: if not reordering functions - return the default. If doing_lto && flag_profile_values ; ignore frequencies (i.e. return the default)? why is the action applied to startup and unlikely (but no test for weak) and not exit and unlikely .. and not "general and unlikely" perhaps this is all explained in the original patch - but I couldn't find it on a quick search.
[Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541 Richard Biener changed: What|Removed |Added Priority|P3 |P1 Target Milestone|--- |4.9.0
[Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541 --- Comment #3 from Dominique d'Humieres --- > The new failing tests are still there. I was wrong: gcc.dg/tree-prof/crossmodule-indircall-1.c passes.
[Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541 --- Comment #2 from Dominique d'Humieres --- I have reverted the changes in gcc/config/darwin.c done by r 206070 and bootstrap went fine. The new failing tests are still there.
[Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541 --- Comment #1 from Dominique d'Humieres --- Comparing the test suite results between r206040 and r206072+my_fix, the test gcc.dg/tree-prof/pr52027.c (see pr52794) passes now, but the tests g++.dg/tree-prof/partition1.C gcc.dg/tree-prof/20041218-1.c gcc.dg/tree-prof/crossmodule-indircall-1.c gcc.dg/tree-prof/pr49299-1.c gcc.dg/tree-prof/pr49299-2.c fails with -m64. The typical failure is spawn /opt/gcc/build_w/gcc/testsuite/g++/../../xg++ -B/opt/gcc/build_w/gcc/testsuite/g++/../../ /opt/gcc/work/gcc/testsuite/g++.dg/tree-prof/pr57451.C -fno-diagnostics-show-caret -fdiagnostics-color=never -nostdinc++ -I/opt/gcc/build_w/x86_64-apple-darwin13.0.0/libstdc++-v3/include/x86_64-apple-darwin13.0.0 -I/opt/gcc/build_w/x86_64-apple-darwin13.0.0/libstdc++-v3/include -I/opt/gcc/work/libstdc++-v3/libsupc++ -I/opt/gcc/work/libstdc++-v3/include/backward -I/opt/gcc/work/libstdc++-v3/testsuite/util -fmessage-length=0 -O2 -freorder-blocks-and-partition -g -fprofile-use -L/opt/gcc/build_w/x86_64-apple-darwin13.0.0/./libstdc++-v3/src/.libs -B/opt/gcc/build_w/x86_64-apple-darwin13.0.0/./libstdc++-v3/src/.libs -L/opt/gcc/build_w/x86_64-apple-darwin13.0.0/./libstdc++-v3/src/.libs -multiply_defined suppress -lm -m64 -o /opt/gcc/build_w/gcc/testsuite/g++/pr57451.x02^M /pr57451.C ld: Assertion failed: (cfiStartsArray[i] != cfiStartsArray[i-1]), function parse, file /SourceCache/ld64/ld64-224.1/src/ld/parsers/macho_relocatable_file.cpp, line 1639.^M collect2: error: ld returned 1 exit status^M compiler exited with status 1 output is: 0 0x10f507724 __assert_rtn + 144^M 1 0x10f52a55c mach_o::relocatable::Parser::parse(mach_o::relocatable::ParserOptions const&) + 1476^M 2 0x10f5113b6 mach_o::relocatable::Parser::parse(unsigned char const*, unsigned long long, char const*, long, ld::File::Ordinal, mach_o::relocatable::ParserOptions const&) + 328^M 3 0x10f50d776 mach_o::relocatable::parse(unsigned char const*, unsigned long long, char const*, long, ld::File::Ordinal, mach_o::relocatable::ParserOptions const&) + 310^M 4 0x10f54dd83 ld::tool::InputFiles::makeFile(Options::FileInfo const&, bool) + 571^M 5 0x10f54fa33 ld::tool::InputFiles::parseWorkerThread() + 285^M 6 0x7fff8d911899 _pthread_body + 138^M 7 0x7fff8d91172a _pthread_struct_init + 0^M A linker snapshot was created at:^M /tmp/pr57451.x02-2013-11-18-085025.ld-snapshot^M ld: Assertion failed: (cfiStartsArray[i] != cfiStartsArray[i-1]), function parse, file /SourceCache/ld64/ld64-224.1/src/ld/parsers/macho_relocatable_file.cpp, line 1639.^M collect2: error: ld returned 1 exit status^M FAIL: g++.dg/tree-prof/pr57451.C compilation, -fprofile-use UNRESOLVED: g++.dg/tree-prof/pr57451.C execution,-fprofile-use At this point I cannot say if these new failures are due to may fix or to some recent commit.
