[Bug bootstrap/98338] [10/11 Regression] profiledbootstrap failure on x86_64-linux
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98338 --- Comment #26 from CVS Commits --- The releases/gcc-10 branch has been updated by Jan Hubicka : https://gcc.gnu.org/g:62125ef043e19c58780bc06d0e2f2221bbbf28f6 commit r10-9401-g62125ef043e19c58780bc06d0e2f2221bbbf28f6 Author: Jan Hubicka Date: Mon Mar 1 14:36:11 2021 +0100 Fix ICE in compute_fn_summary PR ipa/98338 * ipa-fnsummary.c (compute_fn_summary): Fix sanity check. (cherry picked from commit 150bde36c119eff4b8a74667c9d728d6a8a5e8a1)
[Bug bootstrap/98338] [10/11 Regression] profiledbootstrap failure on x86_64-linux
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98338 Jan Hubicka changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #25 from Jan Hubicka --- Fixed. Sorry for the delay - next time I should not commit into a private branch :(
[Bug bootstrap/98338] [10/11 Regression] profiledbootstrap failure on x86_64-linux
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98338 --- Comment #24 from CVS Commits --- The master branch has been updated by Jan Hubicka : https://gcc.gnu.org/g:150bde36c119eff4b8a74667c9d728d6a8a5e8a1 commit r11-7440-g150bde36c119eff4b8a74667c9d728d6a8a5e8a1 Author: Jan Hubicka Date: Mon Mar 1 14:36:11 2021 +0100 Fix ICE in compute_fn_summary PR ipa/98338 * ipa-fnsummary.c (compute_fn_summary): Fix sanity check.
[Bug bootstrap/98338] [10/11 Regression] profiledbootstrap failure on x86_64-linux
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98338 --- Comment #23 from Jakub Jelinek --- The make check results also looked ok on all 3 arches.
[Bug bootstrap/98338] [10/11 Regression] profiledbootstrap failure on x86_64-linux
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98338 --- Comment #22 from Jakub Jelinek --- Yes. https://kojipkgs.fedoraproject.org//work/tasks/2451/62722451/build.log is the failed i686 bootstrap and https://kojipkgs.fedoraproject.org//work/tasks/2553/62722553/build.log is one with your patch.
[Bug bootstrap/98338] [10/11 Regression] profiledbootstrap failure on x86_64-linux
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98338
--- Comment #21 from Jan Hubicka ---
> FYI, I have today bootstrapped it as well in rpm build on
> {x86_64,i686,powerpc64le}-linux, both your patch and just trunk without the
> workaround I've been using before. The latter failed to bootstrap on i686
> and passed it on x86_64 and powerpc64le, the former passed bootstrap on all
> arches. make check is still ongoing...
Good, so it fixes i686 bootstrap, right?
Honza
Re: [Bug bootstrap/98338] [10/11 Regression] profiledbootstrap failure on x86_64-linux
> FYI, I have today bootstrapped it as well in rpm build on
> {x86_64,i686,powerpc64le}-linux, both your patch and just trunk without the
> workaround I've been using before. The latter failed to bootstrap on i686
> and passed it on x86_64 and powerpc64le, the former passed bootstrap on all
> arches. make check is still ongoing...
Good, so it fixes i686 bootstrap, right?
Honza
[Bug bootstrap/98338] [10/11 Regression] profiledbootstrap failure on x86_64-linux
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98338
--- Comment #20 from Jakub Jelinek ---
FYI, I have today bootstrapped it as well in rpm build on
{x86_64,i686,powerpc64le}-linux, both your patch and just trunk without the
workaround I've been using before. The latter failed to bootstrap on i686
and passed it on x86_64 and powerpc64le, the former passed bootstrap on all
arches. make check is still ongoing...
[Bug bootstrap/98338] [10/11 Regression] profiledbootstrap failure on x86_64-linux
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98338 --- Comment #19 from Jan Hubicka --- > Honza, any progress with this? > If you want, I can test the patch too... Sorry, it bootstrapped, so I will commit it. Honza
[Bug bootstrap/98338] [10/11 Regression] profiledbootstrap failure on x86_64-linux
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98338 --- Comment #18 from Jakub Jelinek --- Honza, any progress with this? If you want, I can test the patch too...
[Bug bootstrap/98338] [10/11 Regression] profiledbootstrap failure on x86_64-linux
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98338
--- Comment #17 from Jan Hubicka ---
I am testing
diff --git a/gcc/ipa-fnsummary.c b/gcc/ipa-fnsummary.c
index e32e69cd3ad..612880240dc 100644
--- a/gcc/ipa-fnsummary.c
+++ b/gcc/ipa-fnsummary.c
@@ -3137,11 +3137,18 @@ compute_fn_summary (struct cgraph_node *node, bool
early)
info->estimated_stack_size = size_info->estimated_self_stack_size;
/* Code above should compute exactly the same result as
- ipa_update_overall_fn_summary but because computation happens in
- different order the roundoff errors result in slight changes. */
+ ipa_update_overall_fn_summary except for case when speculative
+ edges are present since these are accounted to size but not
+ self_size. Do not compare time since different order the roundoff
+ errors result in slight changes. */
ipa_update_overall_fn_summary (node);
- /* In LTO mode we may have speculative edges set. */
- gcc_assert (in_lto_p || size_info->size == size_info->self_size);
+ if (flag_checking)
+{
+ for (e = node->indirect_calls; e; e = e->next_callee)
+ if (e->speculative)
+ break;
+ gcc_assert (e || size_info->size == size_info->self_size);
+}
}
[Bug bootstrap/98338] [10/11 Regression] profiledbootstrap failure on x86_64-linux
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98338 Martin Liška changed: What|Removed |Added Summary|[11 Regression] |[10/11 Regression] |profiledbootstrap failure |profiledbootstrap failure |on x86_64-linux |on x86_64-linux Known to work|10.2.0 | Known to fail||10.2.0 --- Comment #16 from Martin Liška --- > I will check tomorrow if it makes code to compile. Honza, can you please take a look?
