[Bug bootstrap/98412] libcody does not compile with older GCC versions

2020-12-22 Thread nathan at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98412

--- Comment #10 from Nathan Sidwell  ---
Gerald got their first:
* 7e63d383b89 2020-12-22 | c++: Fix build with clang

[Bug bootstrap/98412] libcody does not compile with older GCC versions

2020-12-21 Thread nikhil.benesch at gmail dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98412

Nikhil Benesch  changed:

   What|Removed |Added

 CC||nikhil.benesch at gmail dot com

--- Comment #9 from Nikhil Benesch  ---
Looks like the same fix needs to be applied to cp/module.cc. See
https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562404.html.

[Bug bootstrap/98412] libcody does not compile with older GCC versions

2020-12-21 Thread nathan at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98412

Nathan Sidwell  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #8 from Nathan Sidwell  ---
1467a5c5ab0 2020-12-21 | bootstrap: std:stoul non-portable [PR 98412]

[Bug bootstrap/98412] libcody does not compile with older GCC versions

2020-12-21 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98412

--- Comment #7 from CVS Commits  ---
The master branch has been updated by Nathan Sidwell :

https://gcc.gnu.org/g:1467a5c5ab0dfbae3175b4a326467f939864dadb

commit r11-6289-g1467a5c5ab0dfbae3175b4a326467f939864dadb
Author: Nathan Sidwell 
Date:   Mon Dec 21 09:16:48 2020 -0800

bootstrap: std:stoul non-portable [PR 98412]

Fix some more system-specific issues.  Not everyone's C++11 is the same :(

PR bootstrap/98412
libcody/
* client.cc: Include cstdlib.
* server.cc: Include cstdlib.
gcc/cp/
* mapper-client.cc: INCLUDE_STRING, INCLUDE_VECTOR.
(module_client::open_module_client): Avoid std::stoul.
* mapper-resolver.cc: INCLUDE_STRING, INCLUDE_VECTOR.

[Bug bootstrap/98412] libcody does not compile with older GCC versions

2020-12-21 Thread ebotcazou at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98412

--- Comment #6 from Eric Botcazou  ---
> Can you try this?  I guess we're finding the limitations of 'requires C++11'

Yes, this fixes all the compilation failures, thanks!

[Bug bootstrap/98412] libcody does not compile with older GCC versions

2020-12-21 Thread nathan at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98412

--- Comment #5 from Nathan Sidwell  ---
Created attachment 49822
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49822&action=edit
test patch

Can you try this?  I guess we're finding the limitations of 'requires C++11' :)

[Bug bootstrap/98412] libcody does not compile with older GCC versions

2020-12-21 Thread ebotcazou at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98412

Eric Botcazou  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Last reconfirmed||2020-12-21
 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #4 from Eric Botcazou  ---
Another one:

/homes/botcazou/gcc-head/src/gcc/cp/mapper-client.cc: In static member function
'static module_client* module_client::open_module_client(location_t, const
char*, void (*)(const char*), const char*)':
/homes/botcazou/gcc-head/src/gcc/cp/mapper-client.cc:176:35: error: 'stoul' is
not a member of 'std'
fd_from = std::stoul (from, &pos, 10);
   ^
/homes/botcazou/gcc-head/src/gcc/cp/mapper-client.cc:193:33: error: 'stoul' is
not a member of 'std'
fd_to = std::stoul (to, &pos, 10);
 ^
gmake[3]: *** [cp/mapper-client.o] Error 1

[Bug bootstrap/98412] libcody does not compile with older GCC versions

2020-12-21 Thread ebotcazou at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98412

--- Comment #3 from Eric Botcazou  ---
Thanks.  The next errors are:

/homes/botcazou/gcc-head/src/libcody/client.cc: In function 'Cody::Packet
Cody::ConnectResponse(std::vector >&)':
/homes/botcazou/gcc-head/src/libcody/client.cc:217:64: error: 'strtoul' was not
declared in this scope
   unsigned long val = strtoul (words[1].c_str (), &eptr, 10);
^
mv -f .deps/libz_a-trees.Tpo .deps/libz_a-trees.Po
/homes/botcazou/gcc-head/src/libcody/server.cc: In function 'unsigned int
Cody::ParseUnsigned(std::string&)':
/homes/botcazou/gcc-head/src/libcody/server.cc:164:55: error: 'strtoul' was not
declared in this scope
   unsigned long val = strtoul (str.c_str (), &eptr, 10);

and are fixed by adding

#include 

to both files.

[Bug bootstrap/98412] libcody does not compile with older GCC versions

2020-12-21 Thread nathan at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98412

Nathan Sidwell  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Nathan Sidwell  ---
Fixed 119d7478d1a

[Bug bootstrap/98412] libcody does not compile with older GCC versions

2020-12-21 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98412

Jakub Jelinek  changed:

   What|Removed |Added

 CC||jakub at gcc dot gnu.org,
   ||nathan at gcc dot gnu.org

--- Comment #1 from Jakub Jelinek  ---
We should support GCC 4.8 and later as the system compiler.