[Bug bootstrap/98696] [11 Regression] ICE when build x86_64-elf-cross compiler with MinGW-w64

2021-01-15 Thread dmalcolm at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98696

David Malcolm  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from David Malcolm  ---
Thanks for confirming the fix; marking this as resolved.

[Bug bootstrap/98696] [11 Regression] ICE when build x86_64-elf-cross compiler with MinGW-w64

2021-01-15 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98696

--- Comment #5 from CVS Commits  ---
The master branch has been updated by David Malcolm :

https://gcc.gnu.org/g:a3128bf01289a243a9e0ebb4e34c23bcb04cb938

commit r11-6730-ga3128bf01289a243a9e0ebb4e34c23bcb04cb938
Author: David Malcolm 
Date:   Fri Jan 15 13:26:39 2021 -0500

bootstrap: fix failing diagnostic selftest on Windows [PR98696]

In one of the selftests in g:f10960558540636800cf5d3d6355969621fbc17e
I didn't consider that paths can contain backslashes, which happens
for the tempfiles on Windows hosts.

gcc/ChangeLog:
PR bootstrap/98696
* diagnostic.c
(selftest::test_print_parseable_fixits_bytes_vs_display_columns):
Escape the tempfile name when constructing the expected output.

[Bug bootstrap/98696] [11 Regression] ICE when build x86_64-elf-cross compiler with MinGW-w64

2021-01-15 Thread unlvsur at live dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98696

--- Comment #4 from cqwrteur  ---
(In reply to David Malcolm from comment #3)
> Created attachment 49976 [details]
> Patch to fix the failing selftest
> 
> Does the attached patch fix the build on Windows hosts?

Thank you it is working now. You can commit it to main.

[Bug bootstrap/98696] [11 Regression] ICE when build x86_64-elf-cross compiler with MinGW-w64

2021-01-15 Thread dmalcolm at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98696

--- Comment #3 from David Malcolm  ---
Created attachment 49976
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49976&action=edit
Patch to fix the failing selftest

Does the attached patch fix the build on Windows hosts?

[Bug bootstrap/98696] [11 Regression] ICE when build x86_64-elf-cross compiler with MinGW-w64

2021-01-15 Thread dmalcolm at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98696

David Malcolm  changed:

   What|Removed |Added

   Last reconfirmed||2021-01-15
 Ever confirmed|0   |1
   Assignee|unassigned at gcc dot gnu.org  |dmalcolm at gcc dot 
gnu.org
 Status|UNCONFIRMED |ASSIGNED

--- Comment #2 from David Malcolm  ---
Sorry, I introduced this in g:f10960558540636800cf5d3d6355969621fbc17e.

I didn't consider that paths can contain backslashes, and these are being
correctly escaped in the output, but fname is not escaped when building the
expected output in the selftest.

I'm working on a fix for the selftest - though I don't have a windows machine
handy to test it on.

[Bug bootstrap/98696] [11 Regression] ICE when build x86_64-elf-cross compiler with MinGW-w64

2021-01-15 Thread rguenth at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98696

Richard Biener  changed:

   What|Removed |Added

Summary|ICE when build  |[11 Regression] ICE when
   |x86_64-elf-cross compiler   |build x86_64-elf-cross
   |with MinGW-w64  |compiler with MinGW-w64
   Target Milestone|--- |11.0
   Priority|P3  |P1
 CC||dmalcolm at gcc dot gnu.org

--- Comment #1 from Richard Biener  ---
Likely an issue with the selftest itself which is new.