[Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements used uninitialized

[pinskia at gcc dot gnu dot org]

--- Comment #13 from pinskia at gcc dot gnu dot org  2006-11-26 01:44 
---
I am going to test RTH's patch and fix all the fall outs.


-- 

pinskia at gcc dot gnu dot org changed:

   What|Removed |Added

 AssignedTo|gdr at gcc dot gnu dot org  |pinskia at gcc dot gnu dot
   ||org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329

[Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements used uninitialized

[pinskia at gcc dot gnu dot org]

--- Comment #14 from pinskia at gcc dot gnu dot org  2006-11-26 18:25 
---
The problem with RTH's patch was the use of t which shadowed the variable in
the function which is used for setting the locus.  I am testing the corrected
patch now.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329

[Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements used uninitialized

[pinskia at gcc dot gnu dot org]

--- Comment #15 from pinskia at gcc dot gnu dot org  2006-11-27 05:46 
---
(In reply to comment #14)
> The problem with RTH's patch was the use of t which shadowed the variable in
> the function which is used for setting the locus.  I am testing the corrected
> patch now.

That fixed most of the failures but there are still some ICEs that need to be
fixed.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329

[Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements used uninitialized

[pinskia at gmail dot com]

--- Comment #16 from pinskia at gmail dot com  2006-11-27 05:51 ---
Subject: Re:  [tree-ssa] badly formatted warnings for SRA
replacements used uninitialized

On Mon, 2006-11-27 at 05:46 +, pinskia at gcc dot gnu dot org wrote:
> That fixed most of the failures but there are still some ICEs that need to be
> fixed.

I have a fix for those ICEs, it is just checking for DECL_P.

-- Pinski


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329

[Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements used uninitialized

[pinskia at gcc dot gnu dot org]

--- Comment #17 from pinskia at gcc dot gnu dot org  2006-11-27 06:41 
---
Here is the patch which passes the C++ testsuite, I have to do a full
bootstrap/testsuite run still but I am happy with it currrently which is why I
am pasting it here:
Index: error.c
===
--- error.c (revision 119217)
+++ error.c (working copy)
@@ -2337,7 +2337,22 @@ cp_printer (pretty_printer *pp, text_inf
 {
 case 'A': result = args_to_string (next_tree, verbose);break;
 case 'C': result = code_to_string (next_tcode);break;
-case 'D': result = decl_to_string (next_tree, verbose);break;
+case 'D':
+  {
+   tree temp = next_tree;
+   if (DECL_P (temp)
+   && DECL_DEBUG_EXPR_IS_FROM (temp) && DECL_DEBUG_EXPR (temp))
+ {
+   temp = DECL_DEBUG_EXPR (temp);
+   if (!DECL_P (temp))
+ {
+   result = expr_to_string (temp);
+   break;
+ }
+ }
+   result = decl_to_string (temp, verbose);
+  }
+  break;
 case 'E': result = expr_to_string (next_tree); break;
 case 'F': result = fndecl_to_string (next_tree, verbose);  break;
 case 'L': result = language_to_string (next_lang); break;


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329

[Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements used uninitialized

[pinskia at gcc dot gnu dot org]

--- Comment #18 from pinskia at gcc dot gnu dot org  2006-12-04 02:24 
---
Subject: Bug 14329

Author: pinskia
Date: Mon Dec  4 02:24:42 2006
New Revision: 119478

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=119478
Log:
2006-12-03  Richard Henderson  <[EMAIL PROTECTED]>
Andrew Pinski  <[EMAIL PROTECTED]>

PR C++/14329
* error.c (cp_printer) <'D'>: Handle DECL_DEBUG_EXPR.

2006-12-03  Richard Henderson  <[EMAIL PROTECTED]>
Andrew Pinski  <[EMAIL PROTECTED]>

PR C++/14329
* g++.dg/warn/unit-1.C: New test.




Added:
trunk/gcc/testsuite/g++.dg/warn/unit-1.C
Modified:
trunk/gcc/cp/ChangeLog
trunk/gcc/cp/error.c
trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14329

Re: [Bug c++/14329] [tree-ssa] badly formatted warnings for SRA replacements used uninitialized

[Andrew Pinski]

On Mon, 2006-11-27 at 05:46 +, pinskia at gcc dot gnu dot org wrote:
> That fixed most of the failures but there are still some ICEs that need to be
> fixed.

I have a fix for those ICEs, it is just checking for DECL_P.

-- Pinski