[Bug c++/56346] FAIL: g++.dg/tls/thread_local3.C -std=gnu++11 (test for excess errors)

2013-03-14 Thread jason at gcc dot gnu.org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56346



--- Comment #8 from Jason Merrill jason at gcc dot gnu.org 2013-03-14 
13:08:42 UTC ---

Author: jason

Date: Thu Mar 14 13:08:36 2013

New Revision: 196657



URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=196657

Log:

PR c++/56346

* decl.c (register_dtor_fn): Pass null to __cxa_thread_atexit

dso_handle parm on targets without __cxa_atexit.



Modified:

trunk/gcc/cp/ChangeLog

trunk/gcc/cp/decl.c


[Bug c++/56346] FAIL: g++.dg/tls/thread_local3.C -std=gnu++11 (test for excess errors)

2013-03-14 Thread jason at gcc dot gnu.org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56346



Jason Merrill jason at gcc dot gnu.org changed:



   What|Removed |Added



 Status|UNCONFIRMED |RESOLVED

 Resolution||FIXED

   Target Milestone|--- |4.8.0



--- Comment #9 from Jason Merrill jason at gcc dot gnu.org 2013-03-14 
20:38:02 UTC ---

Fixed.


[Bug c++/56346] FAIL: g++.dg/tls/thread_local3.C -std=gnu++11 (test for excess errors)

2013-03-13 Thread jason at gcc dot gnu.org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56346



Jason Merrill jason at gcc dot gnu.org changed:



   What|Removed |Added



  Attachment #29638|0   |1

is obsolete||



--- Comment #6 from Jason Merrill jason at gcc dot gnu.org 2013-03-13 
14:41:54 UTC ---

Created attachment 29663

  -- http://gcc.gnu.org/bugzilla/attachment.cgi?id=29663

patch 2



That's odd, the change seems unlikely to have changed the flow analysis.  But

anyway, this patch always initializes addr.  Better?


[Bug c++/56346] FAIL: g++.dg/tls/thread_local3.C -std=gnu++11 (test for excess errors)

2013-03-13 Thread dave.anglin at bell dot net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56346



--- Comment #7 from dave.anglin at bell dot net 2013-03-13 15:23:11 UTC ---

On 3/13/2013 10:42 AM, jason at gcc dot gnu.org wrote:

 That's odd, the change seems unlikely to have changed the flow analysis.  But



 anyway, this patch always initializes addr.  Better?

I hacked the original patch to avoid the error. Change fixed

the test failures, so approach looks good. Will test new patch.


[Bug c++/56346] FAIL: g++.dg/tls/thread_local3.C -std=gnu++11 (test for excess errors)

2013-03-12 Thread danglin at gcc dot gnu.org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56346



--- Comment #5 from John David Anglin danglin at gcc dot gnu.org 2013-03-12 
14:28:22 UTC ---

With patch, build fails with following error:



/test/gnu/gcc/objdir1/./prev-gcc/xg++ -B/test/gnu/gcc/objdir1/./prev-gcc/

-B/opt

/gnu/gcc/gcc-4.8/hppa2.0w-hp-hpux11.11/bin/ -nostdinc++

-B/test/gnu/gcc/objdir1/

prev-hppa2.0w-hp-hpux11.11/libstdc++-v3/src/.libs

-B/test/gnu/gcc/objdir1/prev-h

ppa2.0w-hp-hpux11.11/libstdc++-v3/libsupc++/.libs

-I/test/gnu/gcc/objdir1/prev-h

ppa2.0w-hp-hpux11.11/libstdc++-v3/include/hppa2.0w-hp-hpux11.11

-I/test/gnu/gcc/

objdir1/prev-hppa2.0w-hp-hpux11.11/libstdc++-v3/include

-I/test/gnu/gcc/gcc/libs

tdc++-v3/libsupc++

-L/test/gnu/gcc/objdir1/prev-hppa2.0w-hp-hpux11.11/libstdc++-

v3/src/.libs

-L/test/gnu/gcc/objdir1/prev-hppa2.0w-hp-hpux11.11/libstdc++-v3/lib

supc++/.libs -c  -DIN_GCC_FRONTEND -DIN_GCC_FRONTEND -g -O2 -DIN_GCC  

-fno-exce

ptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing

-Wwrite-st

rings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long

-Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common 

-DHAVE_CONFIG_H -I. -Icp -I../../gcc/gcc -I../../gcc/gcc/cp

-I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include

-I/opt/gnu/gcc/gmp/include  -I../../gcc/gcc/../libdecnumber

-I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber

-I../../gcc/gcc/../libbacktrace../../gcc/gcc/cp/pt.c -o cp/pt.o

../../gcc/gcc/cp/decl.c: In function 'tree_node* register_dtor_fn(tree)':

../../gcc/gcc/cp/decl.c:6864:38: error: 'addr' may be used uninitialized in

this function [-Werror=maybe-uninitialized]

   arg0, arg1, arg2, NULL_TREE);

  ^

cc1plus: all warnings being treated as errors


[Bug c++/56346] FAIL: g++.dg/tls/thread_local3.C -std=gnu++11 (test for excess errors)

2013-03-11 Thread jason at gcc dot gnu.org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56346



--- Comment #4 from Jason Merrill jason at gcc dot gnu.org 2013-03-11 
16:33:18 UTC ---

Created attachment 29638

  -- http://gcc.gnu.org/bugzilla/attachment.cgi?id=29638

tentative patch



__cxa_thread_atexit is in libstdc++; the default implementation doesn't do

anything with the dso_handle parm, so I think it makes sense to just pass NULL

on targets without __cxa_atexit.  Does this patch fix the failure for you?


[Bug c++/56346] FAIL: g++.dg/tls/thread_local3.C -std=gnu++11 (test for excess errors)

2013-03-09 Thread danglin at gcc dot gnu.org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56346



--- Comment #3 from John David Anglin danglin at gcc dot gnu.org 2013-03-09 
21:30:13 UTC ---

Created attachment 29631

  -- http://gcc.gnu.org/bugzilla/attachment.cgi?id=29631

.s file



Target doesn't have __cxa_thread_atexit or __cxa_atexit, so it won't help

to implement __dso_handle.  In auto-host.h, we have:



#ifndef USED_FOR_TARGET

/* #undef DEFAULT_USE_CXA_ATEXIT */

#endif



Currently, constructors and destructors are assembled by collect2.  Linker

options are used to run the constructors/destructors when applications or

shared libraries are loaded/unloaded.


[Bug c++/56346] FAIL: g++.dg/tls/thread_local3.C -std=gnu++11 (test for excess errors)

2013-02-15 Thread jakub at gcc dot gnu.org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56346



Jakub Jelinek jakub at gcc dot gnu.org changed:



   What|Removed |Added



 CC||jakub at gcc dot gnu.org



--- Comment #1 from Jakub Jelinek jakub at gcc dot gnu.org 2013-02-15 
15:44:45 UTC ---

 Target doesn't use crtstuff.c.



Why?  That looks like the bug to me.


[Bug c++/56346] FAIL: g++.dg/tls/thread_local3.C -std=gnu++11 (test for excess errors)

2013-02-15 Thread dave.anglin at bell dot net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56346



--- Comment #2 from dave.anglin at bell dot net 2013-02-15 15:55:07 UTC ---

On 2013-02-15 9:44 AM, jakub at gcc dot gnu.org wrote:



 Target doesn't use crtstuff.c.

 Why?  That looks like the bug to me.

It only supports ELF and COFF file formats, and not SOM.