[Bug c++/83808] [7/8 Regression] "internal compiler error" for invalid input
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83808 --- Comment #7 from Jason Merrill --- Author: jason Date: Thu Apr 5 17:17:11 2018 New Revision: 259138 URL: https://gcc.gnu.org/viewcvs?rev=259138&root=gcc&view=rev Log: PR c++/83808 - ICE with VLA initialization. * typeck2.c (process_init_constructor_array): Don't require a VLA initializer to have VLA type. Added: trunk/gcc/testsuite/g++.dg/ext/vla19.C Modified: trunk/gcc/cp/ChangeLog trunk/gcc/cp/typeck2.c
[Bug c++/83808] [7/8 Regression] "internal compiler error" for invalid input
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83808 Bug 83808 depends on bug 69487, which changed state. Bug 69487 Summary: Unexpected VLA initialization of char[] from "" https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69487 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED
[Bug c++/83808] [7/8 Regression] "internal compiler error" for invalid input
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83808 Jason Merrill changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|unassigned at gcc dot gnu.org |jason at gcc dot gnu.org
[Bug c++/83808] [7/8 Regression] "internal compiler error" for invalid input
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83808 Jakub Jelinek changed: What|Removed |Added Priority|P3 |P2
[Bug c++/83808] [7/8 Regression] "internal compiler error" for invalid input
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83808 Richard Biener changed: What|Removed |Added Target Milestone|7.3 |7.4 --- Comment #6 from Richard Biener --- GCC 7.3 is being released, adjusting target milestone.
[Bug c++/83808] [7/8 Regression] "internal compiler error" for invalid input
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83808
--- Comment #5 from Jakub Jelinek ---
Another case:
struct R { int r; };
void baz (char *, char *, char *, char *);
void
foo ()
{
const R a = { 12 };
char b[1][a.r] = { { "12345678901" } };
char c[a.r] = { "12345678901" };
char d[1][a.r] = { { '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1',
'\0' } };
char e[a.r] = { '1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '1', '\0'
};
baz (b[0], c, d[0], e);
}
plus perhaps we want a runtime test that checks what happens if the VLA sizes
will be too small.
[Bug c++/83808] [7/8 Regression] "internal compiler error" for invalid input
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83808
--- Comment #4 from Jakub Jelinek ---
--- gcc/cp/tree.c.jj2018-01-17 11:54:08.669802704 +0100
+++ gcc/cp/tree.c 2018-01-17 13:11:08.524278851 +0100
@@ -1044,11 +1044,14 @@ array_of_runtime_bound_p (tree t)
if (!t || TREE_CODE (t) != ARRAY_TYPE)
return false;
tree dom = TYPE_DOMAIN (t);
- if (!dom)
-return false;
- tree max = TYPE_MAX_VALUE (dom);
- return (!potential_rvalue_constant_expression (max)
- || (!value_dependent_expression_p (max) && !TREE_CONSTANT (max)));
+ if (dom)
+{
+ tree max = TYPE_MAX_VALUE (dom);
+ if (!potential_rvalue_constant_expression (max)
+ || (!value_dependent_expression_p (max) && !TREE_CONSTANT (max)))
+ return true;
+}
+ return array_of_runtime_bound_p (TREE_TYPE (t));
}
/* Return a reference type node referring to TO_TYPE. If RVAL is
isn't sufficient either though.
[Bug c++/83808] [7/8 Regression] "internal compiler error" for invalid input
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83808 --- Comment #3 from Jakub Jelinek --- Seems one of the issues is that array_of_runtime_bound_p only looks at the toplevel array. Shall it look at all the nested ARRAY_TYPEs and return true if any of them is of runtime bound? Or shall we have another predicate which would do that? There is always variably_modified_type_p predicate, but it doesn't probably work too well with dependent types.
[Bug c++/83808] [7/8 Regression] "internal compiler error" for invalid input
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83808
Jakub Jelinek changed:
What|Removed |Added
CC||jakub at gcc dot gnu.org
--- Comment #2 from Jakub Jelinek ---
Slightly adjusted testcase:
struct R { int r; };
void
foo ()
{
const R a = { 12 };
char b[1][a.r] = { { "12345678901" } };
char c[a.r] = { "12345678901" };
}
It isn't enough to just comment out the assertion, for c we generate runtime
code to check that the string fits in, but not for b[0].
[Bug c++/83808] [7/8 Regression] "internal compiler error" for invalid input
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83808 Richard Biener changed: What|Removed |Added Target Milestone|--- |7.3
[Bug c++/83808] [7/8 Regression] "internal compiler error" for invalid input
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83808 Martin Sebor changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed||2018-01-13 CC||jason at gcc dot gnu.org, ||msebor at gcc dot gnu.org Known to work||6.4.0 Summary|"internal compiler error" |[7/8 Regression] "internal |for invalid input |compiler error" for invalid ||input Ever confirmed|0 |1 Known to fail||7.2.0, 8.0 --- Comment #1 from Martin Sebor --- Confirmed. Bisection points to r246662 (introduced in gcc 7.0.1): r246662 | jason | 2017-04-03 17:15:36 -0400 (Mon, 03 Apr 2017) | 7 lines PR sanitizer/79993 - ICE with VLA initialization from string PR c++/69487 - wrong VLA initialization from string * init.c (finish_length_check): Split out from build_vec_init. (build_vec_init): Handle STRING_CST. * typeck2.c (split_nonconstant_init): Handle STRING_CST. (digest_init_r): Don't give a STRING_CST VLA type.
