[Bug c++/86993] [6/7/8/9 Regression] assignment of read-only variable error reported at wrong location
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86993 Jakub Jelinek changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Target Milestone|6.5 |9.0 --- Comment #4 from Jakub Jelinek --- Fixed on the trunk, not going to backport.
[Bug c++/86993] [6/7/8/9 Regression] assignment of read-only variable error reported at wrong location
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86993 --- Comment #3 from Jakub Jelinek --- Author: jakub Date: Mon Aug 27 18:36:23 2018 New Revision: 263891 URL: https://gcc.gnu.org/viewcvs?rev=263891=gcc=rev Log: PR c++/86993 * cp-tree.h (cxx_readonly_error): Add location_t argument. * typeck2.c (cxx_readonly_error): Add LOC argument, pass it to ERROR_FOR_ASSIGNMENT macro and readonly_error. Add LOC argument to ERROR_FOR_ASSIGNMENT macro, use error_at instead of error and pass LOC to it. Formatting fixes. * typeck.c (cp_build_unary_op): Pass location to cxx_readonly_error. (cp_build_modify_expr): Pass loc to cxx_readonly_error. * semantics.c (finish_asm_stmt): Pass input_location to cxx_readonly_error. * g++.dg/diagnostic/pr86993.C: New test. Added: trunk/gcc/testsuite/g++.dg/diagnostic/pr86993.C Modified: trunk/gcc/ChangeLog trunk/gcc/cp/ChangeLog trunk/gcc/cp/cp-tree.h trunk/gcc/cp/semantics.c trunk/gcc/cp/typeck.c trunk/gcc/cp/typeck2.c trunk/gcc/testsuite/ChangeLog
[Bug c++/86993] [6/7/8/9 Regression] assignment of read-only variable error reported at wrong location
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86993 Jakub Jelinek changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org --- Comment #2 from Jakub Jelinek --- Created attachment 44588 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=44588=edit gcc9-pr86993.patch Untested fix, maybe some tests in the testsuite will need small adjustments too.
[Bug c++/86993] [6/7/8/9 Regression] assignment of read-only variable error reported at wrong location
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86993 Richard Biener changed: What|Removed |Added Priority|P3 |P2 Target Milestone|--- |6.5
[Bug c++/86993] [6/7/8/9 Regression] assignment of read-only variable error reported at wrong location
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86993 Jonathan Wakely changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed||2018-08-17 CC||dmalcolm at gcc dot gnu.org Ever confirmed|0 |1 --- Comment #1 from Jonathan Wakely --- Started with r231293 C++ FE: expression ranges gcc/ChangeLog: * convert.c (convert_to_real_1): When converting from a REAL_TYPE, preserve the location of EXPR in the result. * tree.c (get_pure_location): Make non-static. (set_source_range): Return the resulting location_t. (make_location): New function. * tree.h (get_pure_location): New decl. (get_finish): New inline function. (set_source_range): Convert return type from void to location_t. (make_location): New decl. ...
