[Bug c++/90449] No way to turn off warning about inaccessible base

2019-06-11 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90449

Marek Polacek  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Marek Polacek  ---
Fixed in GCC 10 by a patch from Matthew.

[Bug c++/90449] No way to turn off warning about inaccessible base

2019-06-11 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90449

--- Comment #6 from Marek Polacek  ---
Author: mpolacek
Date: Tue Jun 11 15:03:21 2019
New Revision: 272157

URL: https://gcc.gnu.org/viewcvs?rev=272157=gcc=rev
Log:
   PR c++/90449 - add -Winaccessible-base option.
   * doc/invoke.texi (Winaccessible-base): Document.

   * c.opt (Winaccessible-base): Added new option.

   * class.c (warn_about_ambiguous_bases): Changed name to:
   maybe_warn_about_inaccessible_bases.
   (maybe_warn_about_inaccessible_bases):  Implemented new
   Winaccessible-base warning option for both direct and virtual
   base warnings.
   (layout_class_type): Call to warn_about_ambiguous_bases changed to fit
   new name.

* g++.dg/warn/Winaccessible-base-1.C: New file.
* g++.dg/warn/Winaccessible-base-2.C: New file.
* g++.dg/warn/Winaccessible-virtual-base-1.C: New file.
* g++.dg/warn/Winaccessible-virtual-base-2.C: New file.

Added:
trunk/gcc/testsuite/g++.dg/warn/Winaccessible-base-1.C
trunk/gcc/testsuite/g++.dg/warn/Winaccessible-base-2.C
trunk/gcc/testsuite/g++.dg/warn/Winaccessible-virtual-base-1.C
trunk/gcc/testsuite/g++.dg/warn/Winaccessible-virtual-base-2.C
Modified:
trunk/gcc/ChangeLog
trunk/gcc/c-family/ChangeLog
trunk/gcc/c-family/c.opt
trunk/gcc/cp/ChangeLog
trunk/gcc/cp/class.c
trunk/gcc/doc/invoke.texi
trunk/gcc/testsuite/ChangeLog

[Bug c++/90449] No way to turn off warning about inaccessible base

2019-06-07 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90449

Eric Gallager  changed:

   What|Removed |Added

   Keywords||patch
URL||https://gcc.gnu.org/ml/gcc-
   ||patches/2019-06/msg00471.ht
   ||ml
   See Also||https://gcc.gnu.org/bugzill
   ||a/show_bug.cgi?id=90764

--- Comment #5 from Eric Gallager  ---
thread for a patch: https://gcc.gnu.org/ml/gcc-patches/2019-06/msg00471.html

[Bug c++/90449] No way to turn off warning about inaccessible base

2019-06-05 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90449

--- Comment #4 from Marek Polacek  ---
(In reply to Marek Polacek from comment #3)
> The testcase in the godbolt link even ICEs with current trunk.  I'll open a
> separate PR.

PR90764

[Bug c++/90449] No way to turn off warning about inaccessible base

2019-06-05 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90449

--- Comment #3 from Marek Polacek  ---
The testcase in the godbolt link even ICEs with current trunk.  I'll open a
separate PR.

[Bug c++/90449] No way to turn off warning about inaccessible base

2019-05-13 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90449

Marek Polacek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mpolacek at gcc dot gnu.org
   Assignee|unassigned at gcc dot gnu.org  |mpolacek at gcc dot 
gnu.org

[Bug c++/90449] No way to turn off warning about inaccessible base

2019-05-13 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90449

Eric Gallager  changed:

   What|Removed |Added

 CC||egallager at gcc dot gnu.org
 Blocks||44209

--- Comment #2 from Eric Gallager  ---
falls under the meta-bug of bug 44209


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44209
[Bug 44209] [meta-bug] Some warnings are not linked to diagnostics options

[Bug c++/90449] No way to turn off warning about inaccessible base

2019-05-13 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90449

Jonathan Wakely  changed:

   What|Removed |Added

   Keywords||diagnostic
 Status|UNCONFIRMED |NEW
   Last reconfirmed||2019-05-13
 Ever confirmed|0   |1

--- Comment #1 from Jonathan Wakely  ---
Confirmed, all warnings should be controlled by *some* -Wxxx flag, even if it's
shared with other related warnings. -Winaccessible-base seems as good a name as
any.