[Bug c/19315] document undocumented extension that allows code where variable is not emitted in the asm

2017-07-24 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=19315

Eric Gallager  changed:

   What|Removed |Added

   Keywords||documentation
 CC||egallager at gcc dot gnu.org
Summary|variable is not emitted in  |document undocumented
   |the asm |extension that allows code
   ||where variable is not
   ||emitted in the asm

--- Comment #5 from Eric Gallager  ---
(In reply to Andrew Pinski from comment #4)
> This looks like one of those undocumented extensions.

I guess the solution then would be to document it; adding "documentation"
keyword

[Bug c/19315] document undocumented extension that allows code where variable is not emitted in the asm

2018-07-25 Thread pinskia at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=19315

Andrew Pinski  changed:

   What|Removed |Added

 CC||iains at gcc dot gnu.org

--- Comment #6 from Andrew Pinski  ---
*** Bug 86670 has been marked as a duplicate of this bug. ***

[Bug c/19315] document undocumented extension that allows code where variable is not emitted in the asm

2018-07-25 Thread iains at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=19315

--- Comment #7 from Iain Sandoe  ---

IMHO (as you say in c#3) this is "surprising behaviour" 
 * if there's any case you'd want it - then maybe you should have to ask for
it.
   (so if it's intentional it should be behind some flag?)
 * it ought to warn by default (not require '-pedantic').
 * as Richi commented in 86670, it means grokdeclarator has conflicting storage
classes which doesn't seem like a useful idea for maintenance.

 I guess the point is "what do we want the behaviour to be?".

 Documenting it doesn't seem to really make it less surprising (if it's an
'extension' then one ought to be able to identify a sensible use-case and put
it in the test-suite).

[Bug c/19315] document undocumented extension that allows code where variable is not emitted in the asm

2018-07-25 Thread rguenther at suse dot de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=19315

--- Comment #8 from rguenther at suse dot de  ---
On July 25, 2018 5:50:40 PM GMT+02:00, "egallager at gcc dot gnu.org"
 wrote:
>https://gcc.gnu.org/bugzilla/show_bug.cgi?id=19315
>
>Eric Gallager  changed:
>
>   What|Removed |Added
>
>CC||rguenth at gcc dot gnu.org,
>||schwab at gcc dot gnu.org

Just remove the extension and see where in the testsuite it fails. If it
doesn't, simply remove it.

[Bug c/19315] document undocumented extension that allows code where variable is not emitted in the asm

2018-07-26 Thread iains at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=19315

Iain Sandoe  changed:

   What|Removed |Added

 CC||dominiq at lps dot ens.fr

--- Comment #9 from Iain Sandoe  ---
*** Bug 72864 has been marked as a duplicate of this bug. ***

[Bug c/19315] document undocumented extension that allows code where variable is not emitted in the asm

2018-08-15 Thread iains at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=19315

--- Comment #10 from Iain Sandoe  ---
Author: iains
Date: Wed Aug 15 11:45:44 2018
New Revision: 263556

URL: https://gcc.gnu.org/viewcvs?rev=263556&root=gcc&view=rev
Log:
Don't make unsized objects into extern.

2018-08-15  Iain Sandoe 

gcc/c:

PR c/19315
* c-decl.c (finish_decl): Don't add the 'extern' storage class to
objects of unknown size.

gcc/testsuite:

PR c/19315
gcc.dg/graphite/pr82451.c: Make array 'a' an extern.
gcc.dg/redecl-10.c: Expect warnings for the static vars with unknown
size.


Modified:
trunk/gcc/c/ChangeLog
trunk/gcc/c/c-decl.c
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gcc.dg/graphite/pr82451.c
trunk/gcc/testsuite/gcc.dg/redecl-10.c

[Bug c/19315] document undocumented extension that allows code where variable is not emitted in the asm

2018-08-16 Thread iains at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=19315

Iain Sandoe  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #11 from Iain Sandoe  ---
fixed on trunk