[Bug c/30552] gcc crashes when compiling examples with GNU statement expressions in VLAs (also involved: nested functions declared K)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30552 Andrew Pinski changed: What|Removed |Added CC||mpolacek at gcc dot gnu.org --- Comment #14 from Andrew Pinski --- *** Bug 60085 has been marked as a duplicate of this bug. ***
[Bug c/30552] gcc crashes when compiling examples with GNU statement expressions in VLAs (also involved: nested functions declared K)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30552 Andrew Pinski changed: What|Removed |Added Target Milestone|--- |9.0
[Bug c/30552] gcc crashes when compiling examples with GNU statement expressions in VLAs (also involved: nested functions declared K)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30552 Dave Pagan changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #13 from Dave Pagan --- Fixed with patch noted in comments: https://gcc.gnu.org/ml/gcc-patches/2018-03/msg00621.html
[Bug c/30552] gcc crashes when compiling examples with GNU statement expressions in VLAs (also involved: nested functions declared K)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30552 --- Comment #12 from Dave Pagan --- Yes, it did. I had assumed the bug status would get updated, but it wasn't. I'll set it to resolved.
[Bug c/30552] gcc crashes when compiling examples with GNU statement expressions in VLAs (also involved: nested functions declared K)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30552 --- Comment #11 from Eric Gallager --- (In reply to Jeffrey A. Law from comment #10) > Author: law > Date: Wed May 2 17:22:26 2018 > New Revision: 259849 > > URL: https://gcc.gnu.org/viewcvs?rev=259849=gcc=rev > Log: > PR c/30552 > * c-decl.c (old_style_parameter_scope): New function. > * c-parser.c (c_parser_postfix_expression): Check for statement > expressions in old-style function parameter list declarations. > * c-parser.h (old_style_parameter_scope): New extern declaration. > > PR c/30552 > * gcc.dg/noncompile/pr30552-1.c: New test. > * gcc.dg/noncompile/pr30552-2.c: New test. > * gcc.dg/noncompile/pr30552-3.c: New test. > * gcc.dg/noncompile/pr30552-4.c: New test. > > Added: > trunk/gcc/testsuite/gcc.dg/noncompile/pr30552-1.c > trunk/gcc/testsuite/gcc.dg/noncompile/pr30552-2.c > trunk/gcc/testsuite/gcc.dg/noncompile/pr30552-3.c > trunk/gcc/testsuite/gcc.dg/noncompile/pr30552-4.c > Modified: > trunk/gcc/c/ChangeLog > trunk/gcc/c/c-decl.c > trunk/gcc/c/c-parser.c > trunk/gcc/c/c-parser.h > trunk/gcc/testsuite/ChangeLog So did this fix it?
[Bug c/30552] gcc crashes when compiling examples with GNU statement expressions in VLAs (also involved: nested functions declared K)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30552 --- Comment #10 from Jeffrey A. Law --- Author: law Date: Wed May 2 17:22:26 2018 New Revision: 259849 URL: https://gcc.gnu.org/viewcvs?rev=259849=gcc=rev Log: PR c/30552 * c-decl.c (old_style_parameter_scope): New function. * c-parser.c (c_parser_postfix_expression): Check for statement expressions in old-style function parameter list declarations. * c-parser.h (old_style_parameter_scope): New extern declaration. PR c/30552 * gcc.dg/noncompile/pr30552-1.c: New test. * gcc.dg/noncompile/pr30552-2.c: New test. * gcc.dg/noncompile/pr30552-3.c: New test. * gcc.dg/noncompile/pr30552-4.c: New test. Added: trunk/gcc/testsuite/gcc.dg/noncompile/pr30552-1.c trunk/gcc/testsuite/gcc.dg/noncompile/pr30552-2.c trunk/gcc/testsuite/gcc.dg/noncompile/pr30552-3.c trunk/gcc/testsuite/gcc.dg/noncompile/pr30552-4.c Modified: trunk/gcc/c/ChangeLog trunk/gcc/c/c-decl.c trunk/gcc/c/c-parser.c trunk/gcc/c/c-parser.h trunk/gcc/testsuite/ChangeLog
[Bug c/30552] gcc crashes when compiling examples with GNU statement expressions in VLAs (also involved: nested functions declared K)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30552 Eric Gallager changed: What|Removed |Added Keywords||patch --- Comment #9 from Eric Gallager --- (In reply to Dave Pagan from comment #8) > Patch submitted for review: > > https://gcc.gnu.org/ml/gcc-patches/2018-03/msg00621.html thanks; adding "patch" keyword
[Bug c/30552] gcc crashes when compiling examples with GNU statement expressions in VLAs (also involved: nested functions declared K)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30552 --- Comment #8 from Dave Pagan --- Patch submitted for review: https://gcc.gnu.org/ml/gcc-patches/2018-03/msg00621.html
[Bug c/30552] gcc crashes when compiling examples with GNU statement expressions in VLAs (also involved: nested functions declared K)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30552 Paolo Carlini changed: What|Removed |Added Status|NEW |ASSIGNED CC|dave.pagan at oracle dot com, |paolo.carlini at oracle dot com |gcc-bugs at gcc dot gnu.org| Assignee|unassigned at gcc dot gnu.org |dave.pagan at oracle dot com --- Comment #7 from Paolo Carlini --- Dave on it, then.
[Bug c/30552] gcc crashes when compiling examples with GNU statement expressions in VLAs (also involved: nested functions declared K)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30552 --- Comment #6 from Dave Pagan --- (In reply to Eric Gallager from comment #5) > (In reply to Dave Pagan from comment #4) > > It appears this is a case where ICEs are the result of poor error > > detection/recovery with statement expressions in these contexts. Has anyone > > else looked into this? If not, I'd like to investigate it further to verify > > what I'm seeing and come up with a solution. > > Not that I know of; please go ahead! Great. Thanks for the quick response, Eric.
[Bug c/30552] gcc crashes when compiling examples with GNU statement expressions in VLAs (also involved: nested functions declared K)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30552 Eric Gallager changed: What|Removed |Added Keywords|ice-on-valid-code |error-recovery, ||ice-on-invalid-code --- Comment #5 from Eric Gallager --- (In reply to Dave Pagan from comment #4) > It appears this is a case where ICEs are the result of poor error > detection/recovery with statement expressions in these contexts. Has anyone > else looked into this? If not, I'd like to investigate it further to verify > what I'm seeing and come up with a solution. Not that I know of; please go ahead!
[Bug c/30552] gcc crashes when compiling examples with GNU statement expressions in VLAs (also involved: nested functions declared K)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30552 Dave Pagan changed: What|Removed |Added CC||dave.pagan at oracle dot com --- Comment #4 from Dave Pagan --- It appears this is a case where ICEs are the result of poor error detection/recovery with statement expressions in these contexts. Has anyone else looked into this? If not, I'd like to investigate it further to verify what I'm seeing and come up with a solution.
[Bug c/30552] gcc crashes when compiling examples with GNU statement expressions in VLAs (also involved: nested functions declared K)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30552 Eric Gallager changed: What|Removed |Added Last reconfirmed|2008-12-29 14:22:53 |2017-7-30 CC||egallager at gcc dot gnu.org Summary|gcc crashed when compiling |gcc crashes when compiling |an example |examples with GNU statement ||expressions in VLAs (also ||involved: nested functions ||declared K) Known to fail||8.0 --- Comment #3 from Eric Gallager --- Confirmed that gcc still ICEs, although I'm not sure if the code is valid or not... I'll leave the "ice-on-valid-code" keyword for now; someone else more knowledgeable than me can change it if necessary.
