[Bug c/65083] Can not indirectly call some C11 atomic library functions

2016-04-22 Thread joseph at codesourcery dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65083

--- Comment #6 from joseph at codesourcery dot com  ---
It's basically a matter of whether you consider adding a new symbol 
version to be appropriate in a backport.

[Bug c/65083] Can not indirectly call some C11 atomic library functions

2016-04-14 Thread chris.quenelle at oracle dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65083

Chris Quenelle  changed:

   What|Removed |Added

 CC||chris.quenelle at oracle dot 
com

--- Comment #5 from Chris Quenelle  ---
How hard would it be for someone to backport this to an earlier gcc release?
Could we cherry pick this backwards for a Solaris update if we wanted to, or
does it depend on other GCC 6 changes?

[Bug c/65083] Can not indirectly call some C11 atomic library functions

2015-11-18 Thread jsm28 at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65083

Joseph S. Myers  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Target Milestone|--- |6.0

--- Comment #4 from Joseph S. Myers  ---
Fixed for GCC 6.

[Bug c/65083] Can not indirectly call some C11 atomic library functions

2015-11-18 Thread jsm28 at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65083

--- Comment #3 from Joseph S. Myers  ---
Author: jsm28
Date: Wed Nov 18 22:13:44 2015
New Revision: 230578

URL: https://gcc.gnu.org/viewcvs?rev=230578&root=gcc&view=rev
Log:
Add out-of-line versions of some  functions (PR c/65083).

PR c/65083 notes that some functions in  are normal
functions, not generic functions, and so need to have out-of-line
copies that can be called when macro expansion is suppressed (unlike
the generic functions where DR#419 makes it undefined if you suppress
a macro expansion).

This patch adds such out-of-line definitions in libatomic for those
six functions, at a new LIBATOMIC_1.2 symbol version, as trivial
wrappers to the  macros, along with declarations of those
functions in .  Tests are added that are based on the
corresponding tests for the macros, but with parentheses around the
function names to force the out-of-line functions to be used.

Bootstrapped with no regressions on x86_64-pc-linux-gnu.

gcc:
* ginclude/stdatomic.h (atomic_thread_fence, atomic_signal_fence)
(atomic_flag_test_and_set, atomic_flag_test_and_set_explicit)
(atomic_flag_clear, atomic_flag_clear_explicit): Declare as
functions before defining as macros.

gcc/testsuite:
* gcc.dg/atomic/stdatomic-fence-2.c,
gcc.dg/atomic/stdatomic-flag-2.c: New tests.

libatomic:
* fence.c, flag.c: New files.
* Makefile.am (libatomic_la_SOURCES): Add fence.c and flag.c.
* Makefile.in: Regenerate.
* configure.ac (libtool_VERSION): Change to 3:0:2.
* configure: Regenerate.
* libatomic.map (LIBATOMIC_1.2): New symbol version.

Added:
trunk/gcc/testsuite/gcc.dg/atomic/stdatomic-fence-2.c
trunk/gcc/testsuite/gcc.dg/atomic/stdatomic-flag-2.c
trunk/libatomic/fence.c
trunk/libatomic/flag.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/ginclude/stdatomic.h
trunk/gcc/testsuite/ChangeLog
trunk/libatomic/ChangeLog
trunk/libatomic/Makefile.am
trunk/libatomic/Makefile.in
trunk/libatomic/configure
trunk/libatomic/configure.ac
trunk/libatomic/libatomic.map

[Bug c/65083] Can not indirectly call some C11 atomic library functions

2015-11-13 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65083

Marek Polacek  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2015-11-13
 CC||mpolacek at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #2 from Marek Polacek  ---
Confirmed; Joseph has posted a patch.

[Bug c/65083] Can not indirectly call some C11 atomic library functions

2015-02-17 Thread joseph at codesourcery dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65083

--- Comment #1 from joseph at codesourcery dot com  ---
Presumably libatomic should get trivial wrappers for the macros, and 
stdatomic.h should add corresponding function declarations.