[Bug c/68657] [6 Regression] "gcc -Werror=sign-conversion test.i" shows invalid: -Wsign-conversion is not an option that controls warnings

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68657

Jakub Jelinek  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #14 from Jakub Jelinek  ---
Fixed for 6.2+.

[Bug c/68657] [6 Regression] "gcc -Werror=sign-conversion test.i" shows invalid: -Wsign-conversion is not an option that controls warnings

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68657

--- Comment #13 from Jakub Jelinek  ---
Author: jakub
Date: Tue Jun 14 14:44:28 2016
New Revision: 237448

URL: https://gcc.gnu.org/viewcvs?rev=237448=gcc=rev
Log:
Backported from mainline
2016-06-10  Jakub Jelinek  

PR c/68657
* c.opt (Wpsabi): Add Warning flag.

* gcc.target/i386/pr68657.c: New test.

Added:
branches/gcc-6-branch/gcc/testsuite/gcc.target/i386/pr68657.c
Modified:
branches/gcc-6-branch/gcc/c-family/ChangeLog
branches/gcc-6-branch/gcc/c-family/c.opt
branches/gcc-6-branch/gcc/testsuite/ChangeLog

[Bug c/68657] [6 Regression] "gcc -Werror=sign-conversion test.i" shows invalid: -Wsign-conversion is not an option that controls warnings

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68657

--- Comment #12 from Jakub Jelinek  ---
Author: jakub
Date: Fri Jun 10 19:46:13 2016
New Revision: 237316

URL: https://gcc.gnu.org/viewcvs?rev=237316=gcc=rev
Log:
PR c/68657
* c.opt (Wpsabi): Add Warning flag.

* gcc.target/i386/pr68657.c: New test.

Added:
trunk/gcc/testsuite/gcc.target/i386/pr68657.c
Modified:
trunk/gcc/c-family/ChangeLog
trunk/gcc/c-family/c.opt
trunk/gcc/testsuite/ChangeLog

[Bug c/68657] [6 Regression] "gcc -Werror=sign-conversion test.i" shows invalid: -Wsign-conversion is not an option that controls warnings

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68657

--- Comment #11 from Jakub Jelinek  ---
Created attachment 38672
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=38672=edit
gcc7-pr68657.patch

Untested fix.  With -Werror we even suggest in diagnostic -Werror=psabi, which
doesn't actually work.  That said, this should have been filed as a separate
PR, rather than hijacking an already fixed one.

[Bug c/68657] [6 Regression] "gcc -Werror=sign-conversion test.i" shows invalid: -Wsign-conversion is not an option that controls warnings

[manu at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68657

Manuel López-Ibáñez  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #10 from Manuel López-Ibáñez  ---
(In reply to npl from comment #9)
> test.c:1:32: warning: '-Wpsabi' is not an option that controls warnings
> [-Wpragmas]
>  #pragma GCC diagnostic ignored "-Wpsabi"
> ^

Same problem. It needs to add "Warning" to gcc/c-family/c.opt

[Bug c/68657] [6 Regression] "gcc -Werror=sign-conversion test.i" shows invalid: -Wsign-conversion is not an option that controls warnings

[npl at chello dot at]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68657

npl at chello dot at changed:

   What|Removed |Added

 CC||npl at chello dot at

--- Comment #9 from npl at chello dot at ---
I am using gcc 6.1 and I have the same problem with disabling -Wpsabi


echo '#pragma GCC diagnostic ignored "-Wpsabi"' >test.c
gcc -c test.c


test.c:1:32: warning: '-Wpsabi' is not an option that controls warnings
[-Wpragmas]
 #pragma GCC diagnostic ignored "-Wpsabi"
^

[Bug c/68657] [6 Regression] "gcc -Werror=sign-conversion test.i" shows invalid: -Wsign-conversion is not an option that controls warnings

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68657

--- Comment #7 from Jakub Jelinek  ---
Author: jakub
Date: Tue Dec  8 13:26:35 2015
New Revision: 231406

URL: https://gcc.gnu.org/viewcvs?rev=231406=gcc=rev
Log:
PR c/48088
PR c/68657
* common.opt (Wframe-larger-than=): Add Warning.
* opts.h (control_warning_option): Add ARG argument.
* opts-common.c (cmdline_handle_error): New function.
(read_cmdline_option): Use it.
(control_warning_option): Likewise.  Add ARG argument.
If non-NULL, decode it if needed and pass through
to handle_generated_option.  Handle CLVC_ENUM like
CLVC_BOOLEAN.
* opts.c (common_handle_option): Adjust control_warning_option
caller.
(enable_warning_as_error): Likewise.
c-family/
* c.opt (Wfloat-conversion, Wsign-conversion): Add Warning.
* c-pragma.c (handle_pragma_diagnostic): Adjust
control_warning_option caller.
ada/
* gcc-interface/trans.c (Pragma_to_gnu): Adjust
control_warning_option caller.
testsuite/
* c-c++-common/pr68657-1.c: New test.
* c-c++-common/pr68657-2.c: New test.
* c-c++-common/pr68657-3.c: New test.
* gcc.dg/cpp/warn-normalized-3.c: Use
-Werror=normalized=nfc instead of -Werror=normalized=
in dg-options.

Added:
trunk/gcc/testsuite/c-c++-common/pr68657-1.c
trunk/gcc/testsuite/c-c++-common/pr68657-2.c
trunk/gcc/testsuite/c-c++-common/pr68657-3.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/ada/ChangeLog
trunk/gcc/ada/gcc-interface/trans.c
trunk/gcc/c-family/ChangeLog
trunk/gcc/c-family/c-pragma.c
trunk/gcc/c-family/c.opt
trunk/gcc/common.opt
trunk/gcc/opts-common.c
trunk/gcc/opts.c
trunk/gcc/opts.h
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gcc.dg/cpp/warn-normalized-3.c

[Bug c/68657] [6 Regression] "gcc -Werror=sign-conversion test.i" shows invalid: -Wsign-conversion is not an option that controls warnings

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68657

Jakub Jelinek  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Jakub Jelinek  ---
Should be fixed now.

[Bug c/68657] [6 Regression] "gcc -Werror=sign-conversion test.i" shows invalid: -Wsign-conversion is not an option that controls warnings

[manu at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68657

--- Comment #6 from Manuel López-Ibáñez  ---
(In reply to Manuel López-Ibáñez from comment #5)
> (In reply to Jakub Jelinek from comment #4)
> > I run also into issues with -Werror=joined-warn-option=arg
> > when testing that, so I've fixed it too.
> 
> For the reference, that is PR48088, as far as I can tell.

And if it gets fixed, I think it deserves a mention in
https://gcc.gnu.org/gcc-6/changes.html (which is quite empty right now). I have
seen many comments in forums and mailing lists complaining that those options
don't work with -Werror= or #pragmas.

[Bug c/68657] [6 Regression] "gcc -Werror=sign-conversion test.i" shows invalid: -Wsign-conversion is not an option that controls warnings

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68657

Jakub Jelinek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|unassigned at gcc dot gnu.org  |jakub at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek  ---
Created attachment 36913
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36913=edit
gcc6-pr68657.patch

Untested fix.  I run also into issues with -Werror=joined-warn-option=arg
when testing that, so I've fixed it too.
Haven't touched java.opt, because all the warning options in there are ignored
(unless jc1 takes them from the driver).

[Bug c/68657] [6 Regression] "gcc -Werror=sign-conversion test.i" shows invalid: -Wsign-conversion is not an option that controls warnings

[manu at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68657

--- Comment #5 from Manuel López-Ibáñez  ---
(In reply to Jakub Jelinek from comment #4)
> I run also into issues with -Werror=joined-warn-option=arg
> when testing that, so I've fixed it too.

For the reference, that is PR48088, as far as I can tell.

[Bug c/68657] [6 Regression] "gcc -Werror=sign-conversion test.i" shows invalid: -Wsign-conversion is not an option that controls warnings

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68657

Tobias Burnus  changed:

   What|Removed |Added

 CC||manu at gcc dot gnu.org

--- Comment #2 from Tobias Burnus  ---
Due to commit r228094 (2015-09-24), which started checking using CL_WARNING.

[Bug c/68657] [6 Regression] "gcc -Werror=sign-conversion test.i" shows invalid: -Wsign-conversion is not an option that controls warnings

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68657

Tobias Burnus  changed:

   What|Removed |Added

   Keywords||diagnostic
   Target Milestone|--- |6.0

--- Comment #1 from Tobias Burnus  ---
Seems as if "Warning" is missing in the second line of the *.opt.

Also affected seem to be:

c-family/c.opt:Wpsabi
c-family/c.opt-C ObjC C++ ObjC++ LTO Var(warn_psabi) Init(1) Undocumented
LangEnabledBy(C ObjC C++ ObjC++,Wabi)

c-family/c.opt:Wfloat-conversion
c-family/c.opt-C ObjC C++ ObjC++ Var(warn_float_conversion) LangEnabledBy(C
ObjC C++ ObjC++,Wconversion)

java/lang.opt:Wdeprecated
java/lang.opt-Java Var(warn_deprecated)

java/lang.opt:Wextraneous-semicolon
java/lang.opt-Java Var(flag_extraneous_semicolon)

java/lang.opt:Wout-of-date
java/lang.opt-Java Var(flag_newer) Init(1)

java/lang.opt:Wredundant-modifiers
java/lang.opt-Java Var(flag_redundant)

[Bug c/68657] [6 Regression] "gcc -Werror=sign-conversion test.i" shows invalid: -Wsign-conversion is not an option that controls warnings

[manu at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68657

Manuel López-Ibáñez  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2015-12-02
 Ever confirmed|0   |1

--- Comment #3 from Manuel López-Ibáñez  ---
The bug is indeed the missing "Warning" in the *.opt files. It will also affect
other things like --help=warnings.

I think sending a patch that fixes all cases at once should be ok. If you have
time, I would appreciate if you could do that. Unfortunately, my free time is
very limited these days.