[Bug c/70475] -Wmisleading-indentation quetionable in Eigen

2017-03-17 Thread msebor at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70475

Martin Sebor  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||msebor at gcc dot gnu.org
 Resolution|--- |WONTFIX

--- Comment #6 from Martin Sebor  ---
Based on comment #2 and comment #3, and since the bug hasn't been confirmed in
a year, resolving as won't fix.

[Bug c/70475] -Wmisleading-indentation quetionable in Eigen

2016-04-05 Thread manu at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70475

Manuel López-Ibáñez  changed:

   What|Removed |Added

 CC||manu at gcc dot gnu.org

--- Comment #5 from Manuel López-Ibáñez  ---
(In reply to Markus Trippelsdorf from comment #2)
> (In reply to Markus Trippelsdorf from comment #1)
> > See discussion in PR69415.
> 
> Sorry wrong bug number. 
> IMHO it is OK to warn for the code above.

I also agree with this and I think the warning seems appropriate. An even
clearer case:

   if (a) not_error();
  goto everything_ok;
   goto error;


or what about:

if (a)
   not_error();
   goto everything_ok;
goto error;

This is not Python! :-)

Note that you can easily silence the warning with explicit braces.

I think we discussed adding a heuristic for column 1 such that we would not
warn for:

else
do_stuff();
more_stuff();
if (a)  do_stuff();
more_stuff();

However, I'm not sure it was ever added.

[Bug c/70475] -Wmisleading-indentation quetionable in Eigen

2016-04-05 Thread ppalka at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70475

Patrick Palka  changed:

   What|Removed |Added

 Status|ASSIGNED|UNCONFIRMED
   Assignee|ppalka at gcc dot gnu.org  |unassigned at gcc dot 
gnu.org
 Ever confirmed|1   |0

--- Comment #4 from Patrick Palka  ---
The fix to PR c/68187 made resolving this PR a bit more complicated.  I'll let
David handle it :)

[Bug c/70475] -Wmisleading-indentation quetionable in Eigen

2016-04-05 Thread ppalka at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70475

Patrick Palka  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Last reconfirmed||2016-04-05
   Assignee|unassigned at gcc dot gnu.org  |ppalka at gcc dot 
gnu.org
 Ever confirmed|0   |1

--- Comment #3 from Patrick Palka  ---
It doesn't make much sense that we warn for:

if (a) do_stuff();
   do_other_stuff();

but not for

if (a) do_stuff();
do_other_stuff();

or for

if (a) do_stuff();
  do_other_stuff();

So I agree that the warning is questionable.  I'll propose a patch.

[Bug c/70475] -Wmisleading-indentation quetionable in Eigen

2016-03-31 Thread trippels at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70475

--- Comment #2 from Markus Trippelsdorf  ---
(In reply to Markus Trippelsdorf from comment #1)
> See discussion in PR69415.

Sorry wrong bug number. 
IMHO it is OK to warn for the code above.

[Bug c/70475] -Wmisleading-indentation quetionable in Eigen

2016-03-31 Thread trippels at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70475

Markus Trippelsdorf  changed:

   What|Removed |Added

 CC||trippels at gcc dot gnu.org

--- Comment #1 from Markus Trippelsdorf  ---
See discussion in PR69415.