[Bug c/81544] attribute noreturn and warn_unused_result on the same function accepted

2017-12-11 Thread msebor at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81544

--- Comment #5 from Martin Sebor  ---
Author: msebor
Date: Mon Dec 11 23:21:55 2017
New Revision: 27

URL: https://gcc.gnu.org/viewcvs?rev=27=gcc=rev
Log:
PR c/81544 - attribute noreturn and warn_unused_result on the same function
accepted 

Add tests missed in r255469.


Added:
trunk/gcc/testsuite/c-c++-common/Wattributes-2.c
trunk/gcc/testsuite/c-c++-common/Wattributes.c
trunk/gcc/testsuite/g++.dg/Wattributes-2.C
trunk/gcc/testsuite/gcc.dg/Wattributes-6.c
trunk/gcc/testsuite/gcc.dg/Wattributes-7.c
Modified:
trunk/gcc/testsuite/ChangeLog

[Bug c/81544] attribute noreturn and warn_unused_result on the same function accepted

2017-12-07 Thread msebor at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81544

Martin Sebor  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
   Assignee|mpolacek at gcc dot gnu.org|msebor at gcc dot 
gnu.org

--- Comment #4 from Martin Sebor  ---
Fixed via 255469.

[Bug c/81544] attribute noreturn and warn_unused_result on the same function accepted

2017-12-07 Thread msebor at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81544

--- Comment #3 from Martin Sebor  ---
Author: msebor
Date: Thu Dec  7 16:32:03 2017
New Revision: 255469

URL: https://gcc.gnu.org/viewcvs?rev=255469=gcc=rev
Log:
PR c/81544 - attribute noreturn and warn_unused_result on the same function
accepted
PR c/81566 - invalid attribute aligned accepted on functions

gcc/ada/ChangeLog:

PR c/81544
* gcc-interface/utils.c (gnat_internal_attribute_table): Initialize
new member of struct attribute_spec.

gcc/c/ChangeLog:

PR c/81544
* c-decl.c (c_decl_attributes): Look up existing declaration and
pass it to decl_attributes.

gcc/c-family/ChangeLog:

PR c/81544
PR c/81566
* c-attribs.c (attr_aligned_exclusions): New array.
(attr_alloc_exclusions, attr_cold_hot_exclusions): Same.
(attr_common_exclusions, attr_const_pure_exclusions): Same.
(attr_gnu_inline_exclusions, attr_inline_exclusions): Same.
(attr_noreturn_exclusions, attr_returns_twice_exclusions): Same.
(attr_warn_unused_result_exclusions): Same.
(handle_hot_attribute, handle_cold_attribute): Simplify.
(handle_const_attribute): Warn on function returning void.
(handle_pure_attribute): Same.
(handle_aligned_attribute): Diagnose conflicting attribute
specifications.
* c-warn.c (diagnose_mismatched_attributes): Simplify.

gcc/cp/ChangeLog:

PR c/81544
* cp-tree.h (decls_match): Add default argument.
* decl.c (decls_match): Avoid calling into the target back end
and triggering an error.
* decl2.c (cplus_decl_attributes): Look up existing declaration and
pass it to decl_attributes.
* tree.c (cxx_attribute_table): Initialize new member of struct
attribute_spec.

gcc/fortran/ChangeLog:

PR c/81544
* f95-lang.c (gfc_attribute_table): Initialize new member of struct
attribute_spec.

gcc/lto/ChangeLog:

PR c/81544
* lto-lang.c (lto_attribute_table): Initialize new member of struct
attribute_spec.

gcc/ChangeLog:

PR c/81544
* attribs.c (empty_attribute_table): Initialize new member of
struct attribute_spec.
(decl_attributes): Add argument.  Handle mutually exclusive
combinations of attributes.
(selftests::test_attribute_exclusions): New function.
(selftests::attribute_c_tests): Ditto.
* attribs.h (decl_attributes): Add default argument.
* selftest.h (attribute_c_tests): Declare.
* selftest-run-tests.c (selftest::run_tests): Call attribute_c_tests.
* tree-core.h (attribute_spec::exclusions, exclude): New type and
member.
* doc/extend.texi (Common Function Attributes): Update const and pure.

gcc/testsuite/ChangeLog:

PR c/81544
* c-c++-common/Wattributes-2.c: New test.
* c-c++-common/Wattributes.c: New test.
* c-c++-common/attributes-3.c: Adjust.
* gcc.dg/Wattributes-6.c: New test.
* gcc.dg/Wattributes-7.c: New test.
* gcc.dg/attr-noinline.c
* gcc.dg/pr44964.c: Same.
* gcc.dg/torture/pr42363.c: Same.
* gcc.dg/tree-ssa/ssa-ccp-2.c: Same.


Modified:
trunk/gcc/ChangeLog
trunk/gcc/ada/ChangeLog
trunk/gcc/ada/gcc-interface/utils.c
trunk/gcc/attribs.c
trunk/gcc/attribs.h
trunk/gcc/brig/brig-lang.c
trunk/gcc/c-family/ChangeLog
trunk/gcc/c-family/c-attribs.c
trunk/gcc/c-family/c-warn.c
trunk/gcc/c/ChangeLog
trunk/gcc/c/c-decl.c
trunk/gcc/config/alpha/alpha.c
trunk/gcc/config/arc/arc.c
trunk/gcc/config/arm/arm.c
trunk/gcc/config/avr/avr.c
trunk/gcc/config/bfin/bfin.c
trunk/gcc/config/cr16/cr16.c
trunk/gcc/config/epiphany/epiphany.c
trunk/gcc/config/h8300/h8300.c
trunk/gcc/config/i386/i386.c
trunk/gcc/config/ia64/ia64.c
trunk/gcc/config/m32c/m32c.c
trunk/gcc/config/m32r/m32r.c
trunk/gcc/config/m68k/m68k.c
trunk/gcc/config/mcore/mcore.c
trunk/gcc/config/microblaze/microblaze.c
trunk/gcc/config/mips/mips.c
trunk/gcc/config/msp430/msp430.c
trunk/gcc/config/nds32/nds32.c
trunk/gcc/config/nvptx/nvptx.c
trunk/gcc/config/powerpcspe/powerpcspe.c
trunk/gcc/config/rl78/rl78.c
trunk/gcc/config/rs6000/rs6000.c
trunk/gcc/config/rx/rx.c
trunk/gcc/config/s390/s390.c
trunk/gcc/config/sh/sh.c
trunk/gcc/config/sparc/sparc.c
trunk/gcc/config/spu/spu.c
trunk/gcc/config/stormy16/stormy16.c
trunk/gcc/config/v850/v850.c
trunk/gcc/config/visium/visium.c
trunk/gcc/cp/ChangeLog
trunk/gcc/cp/cp-tree.h
trunk/gcc/cp/decl.c
trunk/gcc/cp/decl2.c
trunk/gcc/cp/tree.c
trunk/gcc/doc/extend.texi
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/f95-lang.c
trunk/gcc/lto/ChangeLog
trunk/gcc/lto/lto-lang.c
trunk/gcc/selftest-run-tests.c
trunk/gcc/selftest.h

[Bug c/81544] attribute noreturn and warn_unused_result on the same function accepted

2017-08-08 Thread msebor at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81544

Martin Sebor  changed:

   What|Removed |Added

   Keywords||patch

--- Comment #2 from Martin Sebor  ---
Patch posted for review:
  https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00602.html

This general solution is intended to supersed Marek's more targeted fix
previously posted here:
  https://gcc.gnu.org/ml/gcc-patches/2017-07/msg01590.html

[Bug c/81544] attribute noreturn and warn_unused_result on the same function accepted

2017-07-25 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81544

Marek Polacek  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Last reconfirmed||2017-07-25
 CC||mpolacek at gcc dot gnu.org
   Assignee|unassigned at gcc dot gnu.org  |mpolacek at gcc dot 
gnu.org
 Ever confirmed|0   |1

[Bug c/81544] attribute noreturn and warn_unused_result on the same function accepted

2017-07-24 Thread msebor at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81544

--- Comment #1 from Martin Sebor  ---
An example of how conflicting attributes could be handled is the mutually
exclusive pair of attributes always_inline and noinline:

$ cat b.c && gcc -O2 -S -Wall -Wextra -Wpedantic b.c
void __attribute__ ((noinline)) f (void);
void __attribute__ ((always_inline)) f (void);

void __attribute__ ((always_inline)) g (void);
void __attribute__ ((noinline)) g (void);

b.c:2:38: warning: declaration of ‘f’ with attribute ‘always_inline’ follows
declaration with attribute ‘noinline’ [-Wattributes]
 void __attribute__ ((always_inline)) f (void);
  ^
b.c:1:33: note: previous declaration of ‘f’ was here
 void __attribute__ ((noinline)) f (void);
 ^
b.c:5:33: warning: declaration of ‘g’ with attribute ‘noinline’ follows
declaration with attribute ‘always_inline’ [-Wattributes]
 void __attribute__ ((noinline)) g (void);
 ^
b.c:4:38: note: previous declaration of ‘g’ was here
 void __attribute__ ((always_inline)) g (void);
  ^