[Bug driver/112759] [13/14 regression] mips -march=native detection broken with gcc 13+ since r13-3178-g66c48be23e0fa5
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112759 YunQiang Su changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #9 from YunQiang Su --- It should be fixed now, and back ported to gcc13. And we may should add some more detections: 1. hwcap 2. getauxval(AT_PLATFORM) 3. more cpuinfo parsing
[Bug driver/112759] [13/14 regression] mips -march=native detection broken with gcc 13+ since r13-3178-g66c48be23e0fa5
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112759 --- Comment #8 from GCC Commits --- The releases/gcc-13 branch has been updated by YunQiang Su : https://gcc.gnu.org/g:63df799074351e9b3ab90f5b3031ba2691385af8 commit r13-8175-g63df799074351e9b3ab90f5b3031ba2691385af8 Author: YunQiang Su Date: Tue Dec 19 07:36:52 2023 +0800 MIPS: Put the ret to the end of args of reconcat [PR112759] The function `reconcat` cannot append string(s) to NULL, as the concat process will stop at the first NULL. Let's always put the `ret` to the end, as it may be NULL. We keep use reconcat here, due to that reconcat can make it easier if we add more hardware features detecting, for example by hwcap. gcc/ PR target/112759 * config/mips/driver-native.cc (host_detect_local_cpu): Put the ret to the end of args of reconcat.
[Bug driver/112759] [13/14 regression] mips -march=native detection broken with gcc 13+ since r13-3178-g66c48be23e0fa5
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112759 --- Comment #7 from GCC Commits --- The master branch has been updated by YunQiang Su : https://gcc.gnu.org/g:384dbb0b4e751e6eb7ba3f9993a6cce466743926 commit r14-6811-g384dbb0b4e751e6eb7ba3f9993a6cce466743926 Author: YunQiang Su Date: Tue Dec 19 07:36:52 2023 +0800 MIPS: Put the ret to the end of args of reconcat [PR112759] The function `reconcat` cannot append string(s) to NULL, as the concat process will stop at the first NULL. Let's always put the `ret` to the end, as it may be NULL. We keep use reconcat here, due to that reconcat can make it easier if we add more hardware features detecting, for example by hwcap. gcc/ PR target/112759 * config/mips/driver-native.cc (host_detect_local_cpu): Put the ret to the end of args of reconcat.
[Bug driver/112759] [13/14 regression] mips -march=native detection broken with gcc 13+ since r13-3178-g66c48be23e0fa5
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112759
--- Comment #6 from YunQiang Su ---
ohh, it should be concat(" ", NULL);
[Bug driver/112759] [13/14 regression] mips -march=native detection broken with gcc 13+ since r13-3178-g66c48be23e0fa5
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112759
--- Comment #5 from YunQiang Su ---
It's my fault.
I misunderstanding `reconcat`:
if `optr` is NULL, it cannot work as the `s1` at the sametime.
If so, the return string will be empty.
So, let's define and initial ret like this:
char *ret = concat(" ");
Any idea?
