[Bug fortran/17283] UNPACK issues
-- What|Removed |Added Target Milestone|--- |4.0.1 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17283
[Bug fortran/17283] UNPACK issues
--- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-05-26 06:26 --- Subject: Bug 17283 CVSROOT:/cvs/gcc Module name:gcc Changes by: [EMAIL PROTECTED] 2005-05-26 06:26:18 Modified files: libgfortran: ChangeLog libgfortran/intrinsics: unpack_generic.c gcc/testsuite : ChangeLog gcc/testsuite/gfortran.fortran-torture/execute: intrinsic_unpack.f90 Log message: 2005-05-26 Thomas Koenig [EMAIL PROTECTED] PR libfortran/17283 * gfortran.fortran-torture/execute/intrinsic_unpack.f90: Test callee-allocated memory with write statements. 2005-05-26 Thomas Koenig [EMAIL PROTECTED] PR libfortran/17283 * intrinsics/unpack_generic.c: Fix name of routine on top. Update copyright years. (unpack1): Remove const from return array descriptor. rs: New variable, for calculating return sizes. Populate return array descriptor if ret-data is NULL. Patches: http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gccr1=1.228r2=1.229 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/intrinsics/unpack_generic.c.diff?cvsroot=gccr1=1.6r2=1.7 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gccr1=1.5529r2=1.5530 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.fortran-torture/execute/intrinsic_unpack.f90.diff?cvsroot=gccr1=1.2r2=1.3 -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17283
[Bug fortran/17283] UNPACK issues
--- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-05-26 06:40 --- Subject: Bug 17283 CVSROOT:/cvs/gcc Module name:gcc Branch: gcc-4_0-branch Changes by: [EMAIL PROTECTED] 2005-05-26 06:40:42 Modified files: libgfortran: ChangeLog libgfortran/intrinsics: unpack_generic.c gcc/testsuite : ChangeLog gcc/testsuite/gfortran.fortran-torture/execute: intrinsic_unpack.f90 Log message: 2005-05-26 Thomas Koenig [EMAIL PROTECTED] PR libfortran/17283 * gfortran.fortran-torture/execute/intrinsic_unpack.f90: Test callee-allocated memory with write statements. 2005-05-26 Thomas Koenig [EMAIL PROTECTED] PR libfortran/17283 * intrinsics/unpack_generic.c: Fix name of routine on top. Update copyright years. (unpack1): Remove const from return array descriptor. rs: New variable, for calculating return sizes. Populate return array descriptor if ret-data is NULL. Patches: http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcconly_with_tag=gcc-4_0-branchr1=1.163.2.41r2=1.163.2.42 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/intrinsics/unpack_generic.c.diff?cvsroot=gcconly_with_tag=gcc-4_0-branchr1=1.6r2=1.6.12.1 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcconly_with_tag=gcc-4_0-branchr1=1.5084.2.198r2=1.5084.2.199 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.fortran-torture/execute/intrinsic_unpack.f90.diff?cvsroot=gcconly_with_tag=gcc-4_0-branchr1=1.2r2=1.2.46.1 -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17283
[Bug fortran/17283] UNPACK issues
--- Additional Comments From tkoenig at gcc dot gnu dot org 2005-05-26 09:41 --- A scalar mask is invalid for unpack, so the error message is correct. The memory allocation issue has been fixed for 4.0 and mainline. Closing this bug. -- What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17283
[Bug fortran/17283] UNPACK issues
--- Additional Comments From tkoenig at gcc dot gnu dot org 2005-05-24 21:26 --- (In reply to comment #4) as a note: UNPACK also has issues with as scalar mask, maybe also with memory allocation I have just submitted a patch for the memory allocation issue. A scalar mask for unpack is invalid, AFAIR. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17283
[Bug fortran/17283] UNPACK issues
--- Additional Comments From tkoenig at gcc dot gnu dot org 2005-05-23 16:00 --- Looks like there is another memory allocation issue: $ cat unpack.f90 program main real, dimension(5) :: a a = (/(real(i),i=1,5)/) print *, unpack(a(:), a(:)0, 0.) end $ gfortran unpack.f90 $ ./a.out Segmentation fault $ gfortran -v Using built-in specs. Target: i686-pc-linux-gnu Configured with: ../gcc-4.0/configure --prefix=/home/ig25 --enable-languages=c,f95 : (reconfigured) ../gcc-4.0/configure --prefix=/home/ig25 --with-gcc-version-trigger=/home/ig25/gcc-4.0/gcc/version.c --enable-languages=c,f95 --no-create --no-recursion Thread model: posix gcc version 4.0.1 20050518 (prerelease) -- What|Removed |Added CC||tkoenig at gcc dot gnu dot ||org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17283
[Bug fortran/17283] UNPACK issues
-- What|Removed |Added Keywords|wrong-code |rejects-valid Last reconfirmed|2004-09-08 18:46:43 |2005-03-23 03:10:23 date|| http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17283
[Bug fortran/17283] UNPACK issues
--- Additional Comments From Thomas dot Koenig at online dot de 2004-12-22 16:52 --- The issues with PACK are fixed, keeping this open as a reminder that UNPACK still has issues as pointed out in #4 Test case for the scalar case: $ cat unpack.f90 program main real, dimension(3) :: a, b a = (/ 3., 2., 1./) b = unpack(a,.true.,0.) print *,b end program main $ gfortran unpack.f90 In file unpack.f90:4 b = unpack(a,.true.,0.) 1 Error: 'mask' argument of 'unpack' intrinsic at (1) must be an array $ gfortran -v Using built-in specs. Configured with: ../gcc/configure --prefix=/home/ig25 --enable-languages=c,c++,f95 : (reconfigured) ../gcc/configure --prefix=/home/ig25 --enable-languages=c,c++,f95 Thread model: posix gcc version 4.0.0 20041221 (experimental) -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17283
