[Bug fortran/25486] [4.1/4.2 Regression] fortran fixed-form literal character constant not padded.
--- Comment #16 from aldot at gcc dot gnu dot org 2006-01-13 22:19 --- Fix confirmed by Steve Kargl, closing. -- aldot at gcc dot gnu dot org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25486
[Bug fortran/25486] [4.1/4.2 Regression] fortran fixed-form literal character constant not padded.
--- Comment #15 from aldot at gcc dot gnu dot org 2006-01-12 12:28 --- Subject: Bug 25486 Author: aldot Date: Thu Jan 12 12:28:00 2006 New Revision: 109640 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=109640 Log: 2006-01-12 Bernhard Fischer [EMAIL PROTECTED] * gcc/ChangeLog: Move ChangeLog entry for PR fortran/25486 from here... * gcc/fortran/ChangeLog: ... to here. Modified: branches/gcc-4_1-branch/gcc/ChangeLog branches/gcc-4_1-branch/gcc/fortran/ChangeLog -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25486
[Bug fortran/25486] [4.1/4.2 Regression] fortran fixed-form literal character constant not padded.
--- Comment #9 from aldot at gcc dot gnu dot org 2006-01-11 16:07 --- I had trouble with the testcase: I wanted to have only one .F file with three dg-options but this didn't work out. I'm about to check the patch in during the next few hours. Really sorry for the long delay (flu). -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25486
[Bug fortran/25486] [4.1/4.2 Regression] fortran fixed-form literal character constant not padded.
--- Comment #10 from aldot at gcc dot gnu dot org 2006-01-11 16:38 --- Subject: Bug 25486 Author: aldot Date: Wed Jan 11 16:38:42 2006 New Revision: 109591 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=109591 Log: gcc/fortran: 2006-01-11 Bernhard Fischer [EMAIL PROTECTED] PR fortran/25486 * scanner.c (load_line): use maxlen to determine the line-length used for padding lines in fixed form. gcc/testsuite: 2006-01-10 Bernhard Fischer [EMAIL PROTECTED] PR fortran/25486 * gfortran.dg/literal_character_constant_1_x.F: New test. * gfortran.dg/literal_character_constant_1_y.F: Ditto. * gfortran.dg/literal_character_constant_1_z.F: Ditto. * gfortran.dg/literal_character_constant_1.inc: Helper for new tests. Added: trunk/gcc/testsuite/gfortran.dg/literal_character_constant_1.inc trunk/gcc/testsuite/gfortran.dg/literal_character_constant_1_x.F trunk/gcc/testsuite/gfortran.dg/literal_character_constant_1_y.F trunk/gcc/testsuite/gfortran.dg/literal_character_constant_1_z.F Modified: trunk/gcc/fortran/ChangeLog trunk/gcc/fortran/scanner.c trunk/gcc/testsuite/ChangeLog -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25486
[Bug fortran/25486] [4.1/4.2 Regression] fortran fixed-form literal character constant not padded.
--- Comment #11 from aldot at gcc dot gnu dot org 2006-01-11 17:06 --- Subject: Bug 25486 Author: aldot Date: Wed Jan 11 17:06:44 2006 New Revision: 109592 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=109592 Log: gcc/fortran: 2006-01-11 Bernhard Fischer [EMAIL PROTECTED] PR fortran/25486 * scanner.c (load_line): use maxlen to determine the line-length used for padding lines in fixed form. gcc/testsuite: 2006-01-10 Bernhard Fischer [EMAIL PROTECTED] PR fortran/25486 * gfortran.dg/literal_character_constant_1_x.F: New test. * gfortran.dg/literal_character_constant_1_y.F: Ditto. * gfortran.dg/literal_character_constant_1_z.F: Ditto. * gfortran.dg/literal_character_constant_1.inc: Helper for new tests. Added: branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/literal_character_constant_1.inc branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/literal_character_constant_1_x.F branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/literal_character_constant_1_y.F branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/literal_character_constant_1_z.F Modified: branches/gcc-4_1-branch/gcc/fortran/scanner.c branches/gcc-4_1-branch/gcc/testsuite/ChangeLog -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25486
[Bug fortran/25486] [4.1/4.2 Regression] fortran fixed-form literal character constant not padded.
--- Comment #12 from aldot at gcc dot gnu dot org 2006-01-11 17:08 --- Subject: Bug 25486 Author: aldot Date: Wed Jan 11 17:07:55 2006 New Revision: 109593 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=109593 Log: 2006-01-11 Bernhard Fischer [EMAIL PROTECTED] PR fortran/25486 * scanner.c (load_line): use maxlen to determine the line-length used for padding lines in fixed form. Modified: branches/gcc-4_1-branch/gcc/ChangeLog -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25486
[Bug fortran/25486] [4.1/4.2 Regression] fortran fixed-form literal character constant not padded.
--- Comment #13 from steven at gcc dot gnu dot org 2006-01-11 21:18 --- Bernhard, thanks for fixing this, but you have put your ChangeLog entries in the wrong ChangeLog. They should be in gcc/fortran/ChangeLog, and they are in gcc/ChangeLog. Could you please fix that? -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25486
[Bug fortran/25486] [4.1/4.2 Regression] fortran fixed-form literal character constant not padded.
--- Comment #14 from aldot at gcc dot gnu dot org 2006-01-11 21:37 --- Sure, will fix the changelog tomorrow, sorry! -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25486
[Bug fortran/25486] [4.1/4.2 Regression] fortran fixed-form literal character constant not padded.
--- Comment #7 from steven at gcc dot gnu dot org 2006-01-10 22:00 --- The patch does look reasonable to me at first sight. Steve, are you going to look at the patch? It'd be nice to have this fixed in GCC 4.1. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25486
[Bug fortran/25486] [4.1/4.2 Regression] fortran fixed-form literal character constant not padded.
--- Comment #8 from sgk at troutmask dot apl dot washington dot edu 2006-01-11 01:45 --- Subject: Re: [4.1/4.2 Regression] fortran fixed-form literal character constant not padded. On Tue, Jan 10, 2006 at 10:00:34PM -, steven at gcc dot gnu dot org wrote: The patch does look reasonable to me at first sight. Steve, are you going to look at the patch? It'd be nice to have this fixed in GCC 4.1. I thought I had already looked at this patch. I'll look it over tomorrow (ie in about 12 hours). -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25486
[Bug fortran/25486] [4.1/4.2 Regression] fortran fixed-form literal character constant not padded.
--- Comment #5 from aldot at gcc dot gnu dot org 2005-12-27 13:15 ---
I'm bootstrapping and will test the patch below (gcc.gfortran.pr25486.0.diff).
I'm uncertain on the expected results of the testcase above for
-ffixed-line-length-none, so i'm not changing the behaviour for this case (i.e.
no padding).
2005-12-27
PR fortran/25486
* scanner.c (load_line): use maxlen to determine the line-length used
for padding lines in fixed form.
Index: gcc/fortran/scanner.c
===
--- gcc/fortran/scanner.c (revision 109080)
+++ gcc/fortran/scanner.c (working copy)
@@ -809,11 +809,13 @@ load_line (FILE * input, char **pbuf, in
/* Pad lines to the selected line length in fixed form. */
if (gfc_current_form == FORM_FIXED
- gfc_option.fixed_line_length 0
+ gfc_option.fixed_line_length != 0
!preprocessor_flag
c != EOF)
-while (i++ gfc_option.fixed_line_length)
- *buffer++ = ' ';
+{
+ while (i++ maxlen)
+ *buffer++ = ' ';
+}
*buffer = '\0';
*pbuflen = buflen;
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25486
[Bug fortran/25486] [4.1/4.2 Regression] fortran fixed-form literal character constant not padded.
--- Comment #6 from aldot at gcc dot gnu dot org 2005-12-27 14:54 --- The patch does fix it, the behaviour of line-length-none is documented and expected. trunk with the patch gives: $ gfortran-4.2-HEAD -o pr25486 gfortran.pr25486.f $ ./pr25486 1234567 890 $ gfortran-4.2-HEAD -ffixed-line-length-0 -o pr25486 gfortran.pr25486.f $ ./pr25486 1234567890 -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25486
[Bug fortran/25486] [4.1/4.2 Regression] fortran fixed-form literal character constant not padded.
--- Comment #4 from mmitchel at gcc dot gnu dot org 2005-12-19 19:37 --- Fortran bugs are never release critical: P5. -- mmitchel at gcc dot gnu dot org changed: What|Removed |Added Priority|P3 |P5 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25486
[Bug fortran/25486] [4.1/4.2 Regression] fortran fixed-form literal character constant not padded.
-- pinskia at gcc dot gnu dot org changed: What|Removed |Added Keywords||wrong-code Summary|[4.1 and 4.2 Regression]|[4.1/4.2 Regression] fortran |fortran fixed-form literal |fixed-form literal character |character constant not |constant not padded. |padded. | Target Milestone|--- |4.1.0 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25486
[Bug fortran/25486] [4.1/4.2 Regression] fortran fixed-form literal character constant not padded.
--- Comment #2 from kargl at gcc dot gnu dot org 2005-12-19 04:33 --- This regression is caused by svn update -r 107850 on 4.1 svn update -r 107745 on trunk. This a patch I committed, but until my hard drive is replaced I won't be able to revert without too much pain. If anyone else wants to revert the patch, please do so. We should also alert blindvt (Bernhard Fischer) to the problem. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25486
[Bug fortran/25486] [4.1/4.2 Regression] fortran fixed-form literal character constant not padded.
--- Comment #3 from fxcoudert at gcc dot gnu dot org 2005-12-19 06:52 --- Confirmed and added Bernard as Cc. -- fxcoudert at gcc dot gnu dot org changed: What|Removed |Added CC||aldot at gcc dot gnu dot org Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Last reconfirmed|-00-00 00:00:00 |2005-12-19 06:52:25 date|| http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25486
