[Bug fortran/33539] Too much noise for zero-length character strings

[tkoenig at gcc dot gnu dot org]

--- Comment #3 from tkoenig at gcc dot gnu dot org  2007-10-04 20:27 ---
Fixed on trunk.


-- 

tkoenig at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33539

[Bug fortran/33539] Too much noise for zero-length character strings

[tkoenig at gcc dot gnu dot org]

--- Comment #2 from tkoenig at gcc dot gnu dot org  2007-10-04 20:26 ---
Subject: Bug 33539

Author: tkoenig
Date: Thu Oct  4 20:26:24 2007
New Revision: 129022

URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=129022
Log:
2007-10-04  Thomas Koenig  [EMAIL PROTECTED]

PR fortran/33539
* resolve.c: Only warn if the string length is
less than zero.

2007-10-04  Thomas Koenig  [EMAIL PROTECTED]

PR fortran/33539
* zero_length_2.f90:  Omit warning for zero-length string.
* repeat_2.f90:  Likewise.
* repeat_4.f90:  Likewise.
* char_length_2.f90:  Likewise.


Modified:
trunk/gcc/fortran/resolve.c
trunk/gcc/testsuite/gfortran.dg/char_length_2.f90
trunk/gcc/testsuite/gfortran.dg/repeat_2.f90
trunk/gcc/testsuite/gfortran.dg/repeat_4.f90
trunk/gcc/testsuite/gfortran.dg/zero_length_2.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33539

[Bug fortran/33539] Too much noise for zero-length character strings

[tkoenig at gcc dot gnu dot org]

--- Comment #1 from tkoenig at gcc dot gnu dot org  2007-10-03 18:51 ---
This may work:

$ svn diff
Index: resolve.c
===
--- resolve.c   (revision 128885)
+++ resolve.c   (working copy)
@@ -6563,7 +6563,7 @@ resolve_charlen (gfc_charlen *cl)

   /* If the character length parameter value evaluates to a negative
  value, the length of character entities declared is zero.  */
-  if (cl-length  !gfc_extract_int (cl-length, i)  i = 0)
+  if (cl-length  !gfc_extract_int (cl-length, i)  i  0)
 {
   gfc_warning_now (CHARACTER variable has zero length at %L,
   cl-length-where);

(I do want a warning for a length that's less than zero, but
exactly zero seems to be OK).


-- 

tkoenig at gcc dot gnu dot org changed:

   What|Removed |Added

 CC||tkoenig at gcc dot gnu dot
   ||org
   Severity|normal  |enhancement


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33539

[Bug fortran/33539] Too much noise for zero-length character strings

[fxcoudert at gcc dot gnu dot org]

-- 

fxcoudert at gcc dot gnu dot org changed:

   What|Removed |Added

 CC||fxcoudert at gcc dot gnu dot
   ||org
 Status|UNCONFIRMED |NEW
 Ever Confirmed|0   |1
   GCC host triplet|i686-pc-linux-gnu   |
   Keywords||diagnostic
   Last reconfirmed|-00-00 00:00:00 |2007-10-01 00:07:51
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33539