[Bug fortran/35745] Divide incorrectly extracted from WHERE block?; run time abort

2008-05-17 Thread pault at gcc dot gnu dot org 


--- Comment #4 from pault at gcc dot gnu dot org  2008-05-17 07:11 ---
Subject: Bug 35745

Author: pault
Date: Sat May 17 07:10:13 2008
New Revision: 135461

URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=135461
Log:
2008-05-17  Paul Thomas  [EMAIL PROTECTED]

Backport from mainline:
PR fortran/35756
PR fortran/35759
* trans-stmt.c (gfc_trans_where): Tighten up the dependency
check for calling gfc_trans_where_3.

PR fortran/35743
* trans-stmt.c (gfc_trans_where_2): Set the mask size to zero
if it is calculated to be negative.

PR fortran/35745
* trans-stmt.c (gfc_trans_where_3, gfc_trans_where_assign): Set
ss-where for scalar right hand sides.
* trans-array.c (gfc_add_loop_ss_code): If ss-where is set do
not evaluate scalars outside the loop.  Clean up whitespace.
* trans.h : Add a bitfield 'where' to gfc_ss.

   PR fortran/36233
   * interface.c (compare_actual_formal): Do not check sizes if the
   actual is BT_PROCEDURE.

2008-05-17  Paul Thomas  [EMAIL PROTECTED]

Backport from mainline:
PR fortran/35756
PR fortran/35759
* gfortran.dg/where_1.f90: New test.

PR fortran/35743
PR fortran/35745
* gfortran.dg/where_2.f90: New test.

   PR fortran/36233
   * gfortran.dg/actual_procedure_1.f90: New test

Added:
branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/actual_procedure_1.f90
branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/where_1.f90
branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/where_2.f90
Modified:
branches/gcc-4_3-branch/gcc/fortran/ChangeLog
branches/gcc-4_3-branch/gcc/fortran/interface.c
branches/gcc-4_3-branch/gcc/fortran/trans-array.c
branches/gcc-4_3-branch/gcc/fortran/trans-stmt.c
branches/gcc-4_3-branch/gcc/fortran/trans.h
branches/gcc-4_3-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35745

[Bug fortran/35745] Divide incorrectly extracted from WHERE block?; run time abort

2008-05-17 Thread pault at gcc dot gnu dot org 


--- Comment #5 from pault at gcc dot gnu dot org  2008-05-17 07:17 ---
Fixed on trunk and 4.3.

Thanks for the report.

Paul


-- 

pault at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35745

[Bug fortran/35745] Divide incorrectly extracted from WHERE block?; run time abort

2008-05-16 Thread pault at gcc dot gnu dot org 


--- Comment #3 from pault at gcc dot gnu dot org  2008-05-16 21:12 ---
Subject: Bug 35745

Author: pault
Date: Fri May 16 21:12:04 2008
New Revision: 135443

URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=135443
Log:
2008-05-16  Paul Thomas  [EMAIL PROTECTED]

PR fortran/35756
PR fortran/35759
* trans-stmt.c (gfc_trans_where): Tighten up the dependency
check for calling gfc_trans_where_3.

PR fortran/35743
* trans-stmt.c (gfc_trans_where_2): Set the mask size to zero
if it is calculated to be negative.

PR fortran/35745
* trans-stmt.c (gfc_trans_where_3, gfc_trans_where_assign): Set
ss-where for scalar right hand sides.
* trans-array.c (gfc_add_loop_ss_code): If ss-where is set do
not evaluate scalars outside the loop.  Clean up whitespace.
* trans.h : Add a bitfield 'where' to gfc_ss.

2008-05-16  Paul Thomas  [EMAIL PROTECTED]

PR fortran/35756
PR fortran/35759
* gfortran.dg/where_1.f90: New test.

PR fortran/35743
PR fortran/35745
* gfortran.dg/where_2.f90: New test.

Added:
trunk/gcc/testsuite/gfortran.dg/where_1.f90
trunk/gcc/testsuite/gfortran.dg/where_2.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/trans-array.c
trunk/gcc/fortran/trans-stmt.c
trunk/gcc/fortran/trans.h
trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35745

[Bug fortran/35745] Divide incorrectly extracted from WHERE block?; run time abort

2008-04-01 Thread pault at gcc dot gnu dot org 


-- 

pault at gcc dot gnu dot org changed:

   What|Removed |Added

 AssignedTo|unassigned at gcc dot gnu   |pault at gcc dot gnu dot org
   |dot org |
 Status|NEW |ASSIGNED
   Last reconfirmed|2008-03-28 22:05:10 |2008-04-01 07:24:30
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35745

[Bug fortran/35745] Divide incorrectly extracted from WHERE block?; run time abort

2008-03-29 Thread burnus at gcc dot gnu dot org 


--- Comment #2 from burnus at gcc dot gnu dot org  2008-03-29 15:52 ---
See also PR 35756.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35745

[Bug fortran/35745] Divide incorrectly extracted from WHERE block?; run time abort

2008-03-28 Thread burnus at gcc dot gnu dot org 


--- Comment #1 from burnus at gcc dot gnu dot org  2008-03-28 22:05 ---
Confirm.

Valgrind shows:

Process terminating with default action of signal 8 (SIGFPE): dumping core
  Integer divide by zero at address 0x40274EADB
at 0x4008C6: MAIN__ (ghfhgk.f90:15)

 Divide incorrectly extracted from WHERE block?
Yes and no. The compiler essentially transforms (as -fdump-tree-original shows)

  WHERE (RDA  -15.0)
IDA = 1/NF0 + 2
  ENDWHERE

into

  TMP = 1/NF0 + 2
  WHERE (RDA  -15.0)
IDA = TMP
  ENDWHERE

which is the reason for the integer divide by zero and shows that moving
constant expressions out of a loop is not always a good idea.


-- 

burnus at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever Confirmed|0   |1
   Keywords||wrong-code
   Last reconfirmed|-00-00 00:00:00 |2008-03-28 22:05:10
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35745