[Bug fortran/58989] [Regression] internal compiler error when using reshape function

2013-11-05 Thread kargl at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58989

kargl at gcc dot gnu.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from kargl at gcc dot gnu.org ---
Fixed on trunk and 4.8 branch.  Closing.
Thanks for the bug report.


[Bug fortran/58989] [Regression] internal compiler error when using reshape function

2013-11-05 Thread kargl at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58989

--- Comment #4 from kargl at gcc dot gnu.org ---
Author: kargl
Date: Tue Nov  5 22:44:42 2013
New Revision: 204425

URL: http://gcc.gnu.org/viewcvs?rev=204425&root=gcc&view=rev
Log:
2013-11-05  Steven G. Kargl 

PR fortran/58989
* check.c (gfc_check_reshape): ensure that shape is a constant
expression.

2013-11-05  Steven G. Kargl 

PR fortran/58989
* gfortran.dg/reshape_6.f90: New test.

Added:
branches/gcc-4_8-branch/gcc/testsuite/gfortran.dg/reshape_6.f90
Modified:
branches/gcc-4_8-branch/gcc/fortran/ChangeLog
branches/gcc-4_8-branch/gcc/fortran/check.c
branches/gcc-4_8-branch/gcc/testsuite/ChangeLog


[Bug fortran/58989] [Regression] internal compiler error when using reshape function

2013-11-05 Thread kargl at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58989

--- Comment #3 from kargl at gcc dot gnu.org ---
Author: kargl
Date: Tue Nov  5 20:02:43 2013
New Revision: 204419

URL: http://gcc.gnu.org/viewcvs?rev=204419&root=gcc&view=rev
Log:
2013-11-05  Steven G. Kargl 

PR fortran/58989
* check.c (gfc_check_reshape): ensure that shape is a constant
expression.

2013-11-05  Steven G. Kargl 

PR fortran/58989
* gfortran.dg/reshape_6.f90: New test.

Added:
trunk/gcc/testsuite/gfortran.dg/reshape_6.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/check.c
trunk/gcc/testsuite/ChangeLog


[Bug fortran/58989] [Regression] internal compiler error when using reshape function

2013-11-04 Thread sgk at troutmask dot apl.washington.edu
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58989

--- Comment #2 from Steve Kargl  ---
On Mon, Nov 04, 2013 at 09:40:39PM +, kargl at gcc dot gnu.org wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58989
> 
> kargl at gcc dot gnu.org changed:
> 
>What|Removed |Added
> 
>  Status|UNCONFIRMED |NEW
>Last reconfirmed||2013-11-04
>  CC||kargl at gcc dot gnu.org
>   Known to work||4.2.5, 4.3.6, 4.4.7
> Summary|internal compiler error |[Regression] internal
>|when using reshape function |compiler error when using
>||reshape function
>  Ever confirmed|0   |1
>   Known to fail||4.5.4, 4.6.4, 4.7.4, 4.8.2,
>||4.9.0
> 
> --- Comment #1 from kargl at gcc dot gnu.org ---
> Confirmed.
> 

This appears to fix the issue.  I'm running the testsuite
now.


Index: check.c
===
--- check.c(revision 204372)
+++ check.c(working copy)
@@ -3277,7 +3277,7 @@ gfc_check_reshape (gfc_expr *source, gfc
  "than %d elements", &shape->where, GFC_MAX_DIMENSIONS);
   return false;
 }
-  else if (shape->expr_type == EXPR_ARRAY)
+  else if (shape->expr_type == EXPR_ARRAY && gfc_is_constant_expr (shape))
 {
   gfc_expr *e;
   int i, extent;


[Bug fortran/58989] [Regression] internal compiler error when using reshape function

2013-11-04 Thread kargl at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58989

kargl at gcc dot gnu.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2013-11-04
 CC||kargl at gcc dot gnu.org
  Known to work||4.2.5, 4.3.6, 4.4.7
Summary|internal compiler error |[Regression] internal
   |when using reshape function |compiler error when using
   ||reshape function
 Ever confirmed|0   |1
  Known to fail||4.5.4, 4.6.4, 4.7.4, 4.8.2,
   ||4.9.0

--- Comment #1 from kargl at gcc dot gnu.org ---
Confirmed.