[Bug fortran/68676] ICE in gfc_match_formal_arglist when compiling gfortran.dg/submodule_10.f08

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68676

--- Comment #6 from Paul Thomas  ---
Author: pault
Date: Sat Dec  5 17:10:33 2015
New Revision: 231319

URL: https://gcc.gnu.org/viewcvs?rev=231319=gcc=rev
Log:
2015-12-05  Paul Thomas  

PR fortran/68676
* decl.c (gfc_match_formal_arglist): Correct error, where 'sym'
was used instead of 'progname'.



Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/decl.c

[Bug fortran/68676] ICE in gfc_match_formal_arglist when compiling gfortran.dg/submodule_10.f08

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68676

Paul Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Paul Thomas  ---
Fixed.

Thanks for the report.

Paul

[Bug fortran/68676] ICE in gfc_match_formal_arglist when compiling gfortran.dg/submodule_10.f08

[paul.richard.thomas at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68676

--- Comment #5 from paul.richard.thomas at gmail dot com  ---
As promised, I am working to fix this. Thanks for your contributions.

Paul

On 4 December 2015 at 10:59, ubizjak at gmail dot com
 wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68676
>
> --- Comment #4 from Uroš Bizjak  ---
> (In reply to Dominique d'Humieres from comment #1)
>> See the thread starting at
>> https://gcc.gnu.org/ml/fortran/2015-12/msg00030.html.
>>
>> Note that I don't see these failures on x86_64-apple-darwin14 (no valgrind
>> error).
>
> Please try the following patch. Using this patch, the compiler crashes 
> reliably
> for me, even on x86_64-linux where it didn't crash before.
>
> --cut here--
> Index: decl.c
> ===
> --- decl.c  (revision 231250)
> +++ decl.c  (working copy)
> @@ -4692,7 +4692,7 @@ gfc_match_formal_arglist (gfc_symbol *progname, in
>  {
>gfc_formal_arglist *head, *tail, *p, *q;
>char name[GFC_MAX_SYMBOL_LEN + 1];
> -  gfc_symbol *sym;
> +  gfc_symbol *sym = NULL;
>match m;
>gfc_formal_arglist *formal = NULL;
>
> --cut here--
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

[Bug fortran/68676] ICE in gfc_match_formal_arglist when compiling gfortran.dg/submodule_10.f08

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68676

--- Comment #4 from Uroš Bizjak  ---
(In reply to Dominique d'Humieres from comment #1)
> See the thread starting at
> https://gcc.gnu.org/ml/fortran/2015-12/msg00030.html.
> 
> Note that I don't see these failures on x86_64-apple-darwin14 (no valgrind
> error).

Please try the following patch. Using this patch, the compiler crashes reliably
for me, even on x86_64-linux where it didn't crash before.

--cut here--
Index: decl.c
===
--- decl.c  (revision 231250)
+++ decl.c  (working copy)
@@ -4692,7 +4692,7 @@ gfc_match_formal_arglist (gfc_symbol *progname, in
 {
   gfc_formal_arglist *head, *tail, *p, *q;
   char name[GFC_MAX_SYMBOL_LEN + 1];
-  gfc_symbol *sym;
+  gfc_symbol *sym = NULL;
   match m;
   gfc_formal_arglist *formal = NULL;

--cut here--

[Bug fortran/68676] ICE in gfc_match_formal_arglist when compiling gfortran.dg/submodule_10.f08

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68676

Dominique d'Humieres  changed:

   What|Removed |Added

 Target|alphaev68-linux-gnu |alphaev68-linux-gnu
   ||i386-*-freebsd
 Status|UNCONFIRMED |NEW
   Last reconfirmed||2015-12-03
 CC||kargl at gcc dot gnu.org,
   ||pault at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #1 from Dominique d'Humieres  ---
See the thread starting at
https://gcc.gnu.org/ml/fortran/2015-12/msg00030.html.

Note that I don't see these failures on x86_64-apple-darwin14 (no valgrind
error).

[Bug fortran/68676] ICE in gfc_match_formal_arglist when compiling gfortran.dg/submodule_10.f08

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68676

--- Comment #2 from Steve Kargl  ---
On Thu, Dec 03, 2015 at 01:02:02PM +, dominiq at lps dot ens.fr wrote:
> --- Comment #1 from Dominique d'Humieres  ---
> See the thread starting at
> https://gcc.gnu.org/ml/fortran/2015-12/msg00030.html.
> 
> Note that I don't see these failures on x86_64-apple-darwin14 (no valgrind
> error).
> 

Note, I see the problem on i386-*-freebsd, and I do not
see the problem on x86_64-*-freebsd.  So, it appears to
a 32-bit vs 64-bit pointer issue (ie., someone is stomping
on someone else's memory).  Paul's code may in fact be
correct, but it may be exposing a latent bug. :(

[Bug fortran/68676] ICE in gfc_match_formal_arglist when compiling gfortran.dg/submodule_10.f08

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68676

--- Comment #3 from Uroš Bizjak  ---
(In reply to Steve Kargl from comment #2)

> Note, I see the problem on i386-*-freebsd, and I do not
> see the problem on x86_64-*-freebsd.  So, it appears to
> a 32-bit vs 64-bit pointer issue (ie., someone is stomping
> on someone else's memory).  Paul's code may in fact be
> correct, but it may be exposing a latent bug. :(

alpha-linux-gnu is a pure 64bit target, and the report was with the
crosscompiler from x86_64-linux-gnu (also 64-bit) to alpha-linux-gnu, so IMO
the 32-bit vs 64-bit observation is questionable.