[Bug fortran/78670] [F03] Incorrect file position with namelist read under DTIO
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78670 Jerry DeLisle changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #9 from Jerry DeLisle --- I think this is now fixed. Closing
[Bug fortran/78670] [F03] Incorrect file position with namelist read under DTIO
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78670 --- Comment #8 from Jerry DeLisle --- Author: jvdelisle Date: Wed Mar 29 21:37:45 2017 New Revision: 246576 URL: https://gcc.gnu.org/viewcvs?rev=246576&root=gcc&view=rev Log: 2017-03-29 Jerry DeLisle PR libgfortran/78670 * io/list_read.c (nml_get_obj_data): Delete code which calls the child read procedure. (nml_read_obj): Insert the code which calls the child procedure. Don't need to touch nodes if using dtio since parent will not be traversing the components. PR libgfortran/78670 * gfortran.dg/dtio_25.f90: Use 'a1' format when trying to read a character of length 1. Update test for success. * gfortran.dg/dtio_28.f03: New test. * gfortran.dg/dtio_4.f90: Update to open test file with status = 'scratch' to delete the file when done. Added: trunk/gcc/testsuite/gfortran.dg/dtio_28.f03 Modified: trunk/gcc/testsuite/ChangeLog trunk/gcc/testsuite/gfortran.dg/dtio_25.f90 trunk/gcc/testsuite/gfortran.dg/dtio_4.f90 trunk/libgfortran/ChangeLog trunk/libgfortran/io/list_read.c
[Bug fortran/78670] [F03] Incorrect file position with namelist read under DTIO
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78670 Bug 78670 depends on bug 78661, which changed state. Bug 78661 Summary: [OOP] Namelist output missing object designator under DTIO https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78661 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED
[Bug fortran/78670] [F03] Incorrect file position with namelist read under DTIO
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78670 --- Comment #7 from Jerry DeLisle --- Good news, I have this sorted out and working now with Janus patch for the namelist write portion. We were calling the child procedure too early in nml_get_obj_data when we should have called it in nml_read_obj, after nml_get_obj_data has parsed '=' and other variable qualifiers as with any other namelist. I will post the patch to list after Janus commits the other portion.
[Bug fortran/78670] [F03] Incorrect file position with namelist read under DTIO
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78670 --- Comment #6 from Jerry DeLisle --- (In reply to janus from comment #5) > (In reply to Jerry DeLisle from comment #4) > > Janus, the fix for this bug depends on your patch for pr78661. I would like > > to incorporate yours into the solution to this PR if ok with you. > > Sure, go ahead. If you think the last version is ok, I can also commit it, > so that you have it out of your back ... yes, OK to commit it if you can adjust the test case appropriately. I will then be working on adjusting the namelist read things to make make it work. Please send a note to gfortran list that you have committed per my approval.
[Bug fortran/78670] [F03] Incorrect file position with namelist read under DTIO
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78670 --- Comment #5 from janus at gcc dot gnu.org --- (In reply to Jerry DeLisle from comment #4) > Janus, the fix for this bug depends on your patch for pr78661. I would like > to incorporate yours into the solution to this PR if ok with you. Sure, go ahead. If you think the last version is ok, I can also commit it, so that you have it out of your back ...
[Bug fortran/78670] [F03] Incorrect file position with namelist read under DTIO
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78670 Jerry DeLisle changed: What|Removed |Added CC||janus at gcc dot gnu.org Depends on||78661 --- Comment #4 from Jerry DeLisle --- Janus, the fix for this bug depends on your patch for pr78661. I would like to incorporate yours into the solution to this PR if ok with you. Referenced Bugs: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78661 [Bug 78661] [OOP] Namelist output missing object designator under DTIO
[Bug fortran/78670] [F03] Incorrect file position with namelist read under DTIO
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78670 --- Comment #3 from Jerry DeLisle --- With latest patches on trunk, I get this: $ ./a.out Got ' ' Got '=' At line 72 of file pr78670.f03 Fortran runtime error: End of file A minor problem with the test case is IF (ch /= '') THEN should be IF (ch /= ' ') THEN Still investigating.
[Bug fortran/78670] [F03] Incorrect file position with namelist read under DTIO
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78670 --- Comment #2 from Jerry DeLisle --- Preliminary patch given in PR78854
[Bug fortran/78670] [F03] Incorrect file position with namelist read under DTIO
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78670 Jerry DeLisle changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Last reconfirmed||2016-12-05 CC||jvdelisle at gcc dot gnu.org Assignee|unassigned at gcc dot gnu.org |jvdelisle at gcc dot gnu.org Ever confirmed|0 |1 --- Comment #1 from Jerry DeLisle --- I will look at this one. Ian, thanks for the testing. We have had very little feedback on this new feature. Much appreciated. Yes technically invalid but I cab examine closer.