[Bug fortran/83079] ICE in gfc_widechar_to_char, at fortran/scanner.c:198

[anlauf at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83079

anlauf at gcc dot gnu.org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
   Target Milestone|--- |10.4
 Resolution|--- |FIXED

--- Comment #10 from anlauf at gcc dot gnu.org ---
Fixed on mainline for gcc-12, and on 11- and 10-branch.  Closing.

Thanks for the report!

[Bug fortran/83079] ICE in gfc_widechar_to_char, at fortran/scanner.c:198

[cvs-commit at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83079

--- Comment #9 from CVS Commits  ---
The releases/gcc-10 branch has been updated by Harald Anlauf
:

https://gcc.gnu.org/g:aa87c979d34bdea62586de79e8645fbddfa065b8

commit r10-10427-gaa87c979d34bdea62586de79e8645fbddfa065b8
Author: Harald Anlauf 
Date:   Tue Jan 11 22:06:10 2022 +0100

Fortran: fix ICE and wrong code with TRANSFER and CHARACTER(kind=4)

gcc/fortran/ChangeLog:

PR fortran/83079
* target-memory.c (gfc_interpret_character): Result length is
in bytes and thus depends on the character kind.
* trans-intrinsic.c (gfc_conv_intrinsic_transfer): Compute correct
string length for the result of the TRANSFER intrinsic and for
temporaries for the different character kinds.

gcc/testsuite/ChangeLog:

PR fortran/83079
* gfortran.dg/transfer_char_kind4.f90: New test.

(cherry picked from commit 29401b7b4581e9131e7057e263dcea8b40a6b5ab)

[Bug fortran/83079] ICE in gfc_widechar_to_char, at fortran/scanner.c:198

[cvs-commit at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83079

--- Comment #8 from CVS Commits  ---
The releases/gcc-11 branch has been updated by Harald Anlauf
:

https://gcc.gnu.org/g:a8c234519366b9a93a4bbc0717d609de27ccdc0e

commit r11-9487-ga8c234519366b9a93a4bbc0717d609de27ccdc0e
Author: Harald Anlauf 
Date:   Tue Jan 11 22:06:10 2022 +0100

Fortran: fix ICE and wrong code with TRANSFER and CHARACTER(kind=4)

gcc/fortran/ChangeLog:

PR fortran/83079
* target-memory.c (gfc_interpret_character): Result length is
in bytes and thus depends on the character kind.
* trans-intrinsic.c (gfc_conv_intrinsic_transfer): Compute correct
string length for the result of the TRANSFER intrinsic and for
temporaries for the different character kinds.

gcc/testsuite/ChangeLog:

PR fortran/83079
* gfortran.dg/transfer_char_kind4.f90: New test.

(cherry picked from commit 29401b7b4581e9131e7057e263dcea8b40a6b5ab)

[Bug fortran/83079] ICE in gfc_widechar_to_char, at fortran/scanner.c:198

[cvs-commit at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83079

--- Comment #7 from CVS Commits  ---
The master branch has been updated by Harald Anlauf :

https://gcc.gnu.org/g:29401b7b4581e9131e7057e263dcea8b40a6b5ab

commit r12-6604-g29401b7b4581e9131e7057e263dcea8b40a6b5ab
Author: Harald Anlauf 
Date:   Tue Jan 11 22:06:10 2022 +0100

Fortran: fix ICE and wrong code with TRANSFER and CHARACTER(kind=4)

gcc/fortran/ChangeLog:

PR fortran/83079
* target-memory.c (gfc_interpret_character): Result length is
in bytes and thus depends on the character kind.
* trans-intrinsic.c (gfc_conv_intrinsic_transfer): Compute correct
string length for the result of the TRANSFER intrinsic and for
temporaries for the different character kinds.

gcc/testsuite/ChangeLog:

PR fortran/83079
* gfortran.dg/transfer_char_kind4.f90: New test.

[Bug fortran/83079] ICE in gfc_widechar_to_char, at fortran/scanner.c:198

[anlauf at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83079

anlauf at gcc dot gnu.org changed:

   What|Removed |Added

   Assignee|unassigned at gcc dot gnu.org  |anlauf at gcc dot 
gnu.org
   Keywords||wrong-code
 Status|NEW |ASSIGNED

--- Comment #6 from anlauf at gcc dot gnu.org ---
Patch posted: https://gcc.gnu.org/pipermail/fortran/2022-January/057352.html

[Bug fortran/83079] ICE in gfc_widechar_to_char, at fortran/scanner.c:198

[anlauf at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83079

anlauf at gcc dot gnu.org changed:

   What|Removed |Added

 CC||anlauf at gcc dot gnu.org

--- Comment #5 from anlauf at gcc dot gnu.org ---
The testcase in comment#0 is fixed by:

diff --git a/gcc/fortran/target-memory.c b/gcc/fortran/target-memory.c
index af1c21047f6..9b5af8d1482 100644
--- a/gcc/fortran/target-memory.c
+++ b/gcc/fortran/target-memory.c
@@ -485,7 +485,7 @@ gfc_interpret_character (unsigned char *buffer, size_t
buffer_size,

   result->value.character.string[result->value.character.length] = '\0';

-  return result->value.character.length;
+  return size_character (result->value.character.length, result->ts.kind);
 }

[Bug fortran/83079] ICE in gfc_widechar_to_char, at fortran/scanner.c:198

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83079

--- Comment #4 from anlauf at gcc dot gnu.org ---
The following patch fixes the testcase in comment#3:

Index: gcc/fortran/trans-intrinsic.c
===
--- gcc/fortran/trans-intrinsic.c   (Revision 277989)
+++ gcc/fortran/trans-intrinsic.c   (Arbeitskopie)
@@ -8410,7 +8410,11 @@
   gfc_add_expr_to_block (>post, tmp);

   se->expr = tmpdecl;
-  se->string_length = fold_convert (gfc_charlen_type_node, dest_word_len);
+  tmp = fold_convert (gfc_charlen_type_node,
+ TYPE_SIZE_UNIT (gfc_get_char_type (expr->ts.kind)));
+  se->string_length = fold_build2_loc (input_location, TRUNC_DIV_EXPR,
+  gfc_charlen_type_node,
+  dest_word_len, tmp);
 }
   else
 {


I've tried to understand what happens when the MOLD argument is an array,
but got lost in mutually recursive functions in target-memory.c that seem
to try to convert char(kind=4) to default character, while I believe that
this should not happen.  Don't really understand that code, giving up.

[Bug fortran/83079] ICE in gfc_widechar_to_char, at fortran/scanner.c:198

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83079

anlauf at gcc dot gnu.org changed:

   What|Removed |Added

 CC||anlauf at gcc dot gnu.org

--- Comment #3 from anlauf at gcc dot gnu.org ---
(In reply to G. Steinmetz from comment #1)
> While these variants compile :
> $ cat z5.f90
> program p
>print *, transfer(4_'xy', 4_'a')
> end

This example works with constant arguments, but gives a wrong result
(including junk characters) if the arguments are replaced by variables.

  character(kind=4,len=2) :: xy = 4_'XY'
  character(kind=4,len=1) :: z  = 4_'Z'
  print *, transfer (xy,z)
end program

% gfc-9 z5a.f90 && ./a.out | cat -ev
 XYZ^@$

I have a patch for this one that regtests cleanly, but it does not
address the ICE in comment#0.

Investigating further.

[Bug fortran/83079] ICE in gfc_widechar_to_char, at fortran/scanner.c:198

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83079

Dominique d'Humieres  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2017-11-21
 Ever confirmed|0   |1

--- Comment #2 from Dominique d'Humieres  ---
Confirmed from 4.8 up to trunk (8.0).

[Bug fortran/83079] ICE in gfc_widechar_to_char, at fortran/scanner.c:198

[gs...@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83079

--- Comment #1 from G. Steinmetz  ---

While these variants compile :

$ cat z3.f90
program p
   print *, transfer('xy', ['a'])
end

$ cat z4.f90
program p
   print *, transfer(4_'xy', [4_'ab'])
end

$ cat z5.f90
program p
   print *, transfer(4_'xy', 4_'a')
end