[Bug ipa/63569] [5.0 Regression] Wrong code with volatile and ICF
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63569 --- Comment #11 from Martin Liška marxin at gcc dot gnu.org --- Author: marxin Date: Fri Dec 19 12:40:50 2014 New Revision: 218949 URL: https://gcc.gnu.org/viewcvs?rev=218949root=gccview=rev Log: Fix for PR ipa/63569. PR ipa/63569 * gcc.dg/ipa/pr63569.c: New test. PR ipa/63569 * ipa-icf-gimple.c (func_checker::compare_operand): Add missing comparison for volatile flag. Added: trunk/gcc/testsuite/gcc.dg/ipa/pr63569.c Modified: trunk/gcc/ChangeLog trunk/gcc/ipa-icf-gimple.c trunk/gcc/testsuite/ChangeLog
[Bug ipa/63569] [5.0 Regression] Wrong code with volatile and ICF
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63569 Martin Liška marxin at gcc dot gnu.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #12 from Martin Liška marxin at gcc dot gnu.org --- Fixed in 5.0.0.
[Bug ipa/63569] [5.0 Regression] Wrong code with volatile and ICF
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63569 Markus Trippelsdorf trippels at gcc dot gnu.org changed: What|Removed |Added CC||rguenth at gcc dot gnu.org --- Comment #10 from Markus Trippelsdorf trippels at gcc dot gnu.org --- *** Bug 64283 has been marked as a duplicate of this bug. ***
[Bug ipa/63569] [5.0 Regression] Wrong code with volatile and ICF
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63569 --- Comment #9 from Markus Trippelsdorf trippels at gcc dot gnu.org --- *** Bug 64211 has been marked as a duplicate of this bug. ***
[Bug ipa/63569] [5.0 Regression] Wrong code with volatile and ICF
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63569 Andrew Pinski pinskia at gcc dot gnu.org changed: What|Removed |Added CC||ktkachov at gcc dot gnu.org --- Comment #8 from Andrew Pinski pinskia at gcc dot gnu.org --- *** Bug 64148 has been marked as a duplicate of this bug. ***
[Bug ipa/63569] [5.0 Regression] Wrong code with volatile and ICF
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63569 Andrew Pinski pinskia at gcc dot gnu.org changed: What|Removed |Added CC||anton at samba dot org --- Comment #7 from Andrew Pinski pinskia at gcc dot gnu.org --- *** Bug 64090 has been marked as a duplicate of this bug. ***
[Bug ipa/63569] [5.0 Regression] Wrong code with volatile and ICF
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63569 Martin Liška marxin at gcc dot gnu.org changed: What|Removed |Added CC||marxin at gcc dot gnu.org --- Comment #4 from Martin Liška marxin at gcc dot gnu.org --- Hello. There's suggested patch on mailing list: https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01723.html. Reason why it hasn't been applied is that Richard prefers kind of refactoring for IPA ICF that will cover this case in purer way. Nevertheless, feel free to apply suggested patch if it fixes your issue? Thanks, Martin
[Bug ipa/63569] [5.0 Regression] Wrong code with volatile and ICF
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63569 --- Comment #5 from Markus Trippelsdorf trippels at gcc dot gnu.org --- (In reply to Martin Liška from comment #4) There's suggested patch on mailing list: https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01723.html. Reason why it hasn't been applied is that Richard prefers kind of refactoring for IPA ICF that will cover this case in purer way. Sorry, I just didn't notice the URL in the headers. Your patch fixes the issue for me. Is there any way to make progress on this issue? Could you address Richi's concerns?
[Bug ipa/63569] [5.0 Regression] Wrong code with volatile and ICF
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63569 --- Comment #6 from Martin Liška marxin at gcc dot gnu.org --- Problem is that IPA ICF contains compare_operand that is called recursively and handles all tree types. Richard correctly pointed that we should split the method to memory-related operand comparison and the rest (declarations,..). I hope I can send the path on Monday-Tuesday next week. Thanks, Martin
