[Bug ipa/64813] [5 Regression] 23_containers/unordered_map/requirements/explicit_instantiation/[2,4].cc iCEs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64813 --- Comment #23 from Yvan Roux yroux at gcc dot gnu.org --- Author: yroux Date: Mon Mar 23 09:55:34 2015 New Revision: 221590 URL: https://gcc.gnu.org/viewcvs?rev=221590root=gccview=rev Log: 2015-03-23 Yvan Roux yvan.r...@linaro.org Backport from trunk r220616. 2015-02-11 Martin Liska mli...@suse.cz PR ipa/64813 * cgraphunit.c (cgraph_node::expand_thunk): Do not create a return value for call to a function that is noreturn. Modified: branches/gcc-4_9-branch/gcc/ChangeLog branches/gcc-4_9-branch/gcc/cgraphunit.c
[Bug ipa/64813] [5 Regression] 23_containers/unordered_map/requirements/explicit_instantiation/[2,4].cc iCEs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64813 Martin Liška marxin at gcc dot gnu.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #22 from Martin Liška marxin at gcc dot gnu.org --- Fixed.
[Bug ipa/64813] [5 Regression] 23_containers/unordered_map/requirements/explicit_instantiation/[2,4].cc iCEs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64813 --- Comment #21 from Martin Liška marxin at gcc dot gnu.org --- Author: marxin Date: Wed Feb 11 13:33:47 2015 New Revision: 220616 URL: https://gcc.gnu.org/viewcvs?rev=220616root=gccview=rev Log: Handle noreturn function thunk creation. PR ipa/64813 * cgraphunit.c (cgraph_node::expand_thunk): Do not create a return value for call to a function that is noreturn. Modified: trunk/gcc/ChangeLog trunk/gcc/cgraphunit.c
[Bug ipa/64813] [5 Regression] 23_containers/unordered_map/requirements/explicit_instantiation/[2,4].cc iCEs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64813 --- Comment #20 from Dominique d'Humieres dominiq at lps dot ens.fr --- Full regtesting just completed. Unless pr64982 and https://gcc.gnu.org/ml/gcc-patches/2015-02/msg00550.html are masking some latent bug introduced by the patch, it does not seem to introduce any regression. Thanks.
[Bug ipa/64813] [5 Regression] 23_containers/unordered_map/requirements/explicit_instantiation/[2,4].cc iCEs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64813 --- Comment #17 from Martin Liška marxin at gcc dot gnu.org --- Created attachment 34702 -- https://gcc.gnu.org/bugzilla/attachment.cgi?id=34702action=edit Suggested patch
[Bug ipa/64813] [5 Regression] 23_containers/unordered_map/requirements/explicit_instantiation/[2,4].cc iCEs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64813 --- Comment #16 from Martin Liška marxin at gcc dot gnu.org --- Hello. Sorry for delay, I was away last week. Following patch should prevent a creation of return values for cases where the called function is noreturn. May I ask you for testing on a darwin machine? Thanks, Martin
[Bug ipa/64813] [5 Regression] 23_containers/unordered_map/requirements/explicit_instantiation/[2,4].cc iCEs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64813 --- Comment #19 from Dominique d'Humieres dominiq at lps dot ens.fr --- However I see the following regression (for both -m32 and -m64) FAIL: 22_locale/conversions/string/2.cc execution test It is pr64797 and not a regression due to the patch.
[Bug ipa/64813] [5 Regression] 23_containers/unordered_map/requirements/explicit_instantiation/[2,4].cc iCEs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64813
--- Comment #18 from Dominique d'Humieres dominiq at lps dot ens.fr ---
May I ask you for testing on a darwin machine?
I have bootstrapped revision r220534 with the patch. AFAICT the patch fixes the
failures reported in this PR (tested with
make -k check RUNTESTFLAGS=conformance.exp=2.cc
--target_board=unix'{-m32,-m64}'
and
make -k check RUNTESTFLAGS=conformance.exp=4.cc
--target_board=unix'{-m32,-m64}').
However I see the following regression (for both -m32 and -m64)
FAIL: 22_locale/conversions/string/2.cc execution test
The error is
Assertion failed: (werr == woutput), function test01, file
/opt/gcc/work/libstdc++-v3/testsuite/22_locale/conversions/string/2.cc, line
49.
Abort
Full regtesting scheduled later today.
[Bug ipa/64813] [5 Regression] 23_containers/unordered_map/requirements/explicit_instantiation/[2,4].cc iCEs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64813 Andrew Pinski pinskia at gcc dot gnu.org changed: What|Removed |Added Target Milestone|--- |5.0
[Bug ipa/64813] [5 Regression] 23_containers/unordered_map/requirements/explicit_instantiation/[2,4].cc iCEs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64813 --- Comment #15 from howarth at bromo dot med.uc.edu --- (In reply to Martin Liška from comment #12) I'been testing patch that does not create retval and return gimple statement. Any updates on the testing?
[Bug ipa/64813] [5 Regression] 23_containers/unordered_map/requirements/explicit_instantiation/[2,4].cc iCEs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64813 Jan Hubicka hubicka at gcc dot gnu.org changed: What|Removed |Added CC||hubicka at gcc dot gnu.org --- Comment #14 from Jan Hubicka hubicka at gcc dot gnu.org --- Either that or caling fixup_noreturn_call afterwards. Not producing return statement is probably better idea. I wonder how this worked on earlier trees, perhaps fixup_cfg pass was luckilly scheduled at a time we produce thunks?
[Bug ipa/64813] [5 Regression] 23_containers/unordered_map/requirements/explicit_instantiation/[2,4].cc iCEs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64813 John David Anglin danglin at gcc dot gnu.org changed: What|Removed |Added CC||danglin at gcc dot gnu.org --- Comment #13 from John David Anglin danglin at gcc dot gnu.org --- Also seen on hppa2.0w-hp-hpux11.11.
[Bug ipa/64813] [5 Regression] 23_containers/unordered_map/requirements/explicit_instantiation/[2,4].cc iCEs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64813
Martin Liška marxin at gcc dot gnu.org changed:
What|Removed |Added
Priority|P3 |P1
--- Comment #12 from Martin Liška marxin at gcc dot gnu.org ---
Problem is caused by a function pair where we decide to create a thunk.
Unfortunately, alias of the thunk is noreturn function, because of:
function ...
{
...
bb 8:
std::__throw_out_of_range (_Map_base::at);
}
I'been testing patch that does not create retval and return gimple statement.
Martin
[Bug ipa/64813] [5 Regression] 23_containers/unordered_map/requirements/explicit_instantiation/[2,4].cc iCEs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64813 Dominique d'Humieres dominiq at lps dot ens.fr changed: What|Removed |Added Summary|23_containers/unordered_map |[5 Regression] |/requirements/explicit_inst |23_containers/unordered_map |antiation/[2,4].cc iCEs |/requirements/explicit_inst ||antiation/[2,4].cc iCEs --- Comment #11 from Dominique d'Humieres dominiq at lps dot ens.fr --- It is a regression.
