[Bug libffi/40444] [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.
-- andreast at gcc dot gnu dot org changed: What|Removed |Added AssignedTo|unassigned at gcc dot gnu |andreast at gcc dot gnu dot |dot org |org Status|UNCONFIRMED |ASSIGNED Ever Confirmed|0 |1 Last reconfirmed|-00-00 00:00:00 |2009-06-16 07:33:36 date|| http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444
[Bug libffi/40444] [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.
--- Comment #2 from andreast at gcc dot gnu dot org 2009-06-16 07:38
---
Index: testsuite/lib/libffi-dg.exp
===
--- testsuite/lib/libffi-dg.exp (revision 148518)
+++ testsuite/lib/libffi-dg.exp (working copy)
@@ -187,6 +187,13 @@
lappend options additional_flags=-I${libffi_include}
-I${srcdir}/../include -I${libffi_include}/..
lappend options additional_flags=${libffi_link_flags}
+# Darwin needs a stack execution allowed flag.
+
+if { [istarget *-*-darwin9*] || [istarget *-*-darwin1*]
+|| [istarget *-*-darwin2*] } {
+ lappend options additional_flags=-Wl,-allow_stack_execute
+}
+
# If you're building the compiler with --prefix set to a place
# where it's not yet installed, then the linker won't be able to
# find the libgcc used by libffi.dylib. We could pass the
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444
[Bug libffi/40444] [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.
--- Comment #3 from dominiq at lps dot ens dot fr 2009-06-16 09:46 --- With the patch in comment #2 I get: === libffi tests === Schedule of variations: unix unix/-m64 Running target unix Using /sw/share/dejagnu/baseboards/unix.exp as board description file for target. Using /sw/share/dejagnu/config/unix.exp as generic interface file for target. Using /opt/gcc/gcc-4.5-work/libffi/testsuite/config/default.exp as tool-and-target-specific interface file. Running /opt/gcc/gcc-4.5-work/libffi/testsuite/libffi.call/call.exp ... Running /opt/gcc/gcc-4.5-work/libffi/testsuite/libffi.special/special.exp ... === libffi Summary for unix === # of expected passes1594 # of expected failures 10 # of unsupported tests 15 Running target unix/-m64 Using /sw/share/dejagnu/baseboards/unix.exp as board description file for target. Using /sw/share/dejagnu/config/unix.exp as generic interface file for target. Using /opt/gcc/gcc-4.5-work/libffi/testsuite/config/default.exp as tool-and-target-specific interface file. Running /opt/gcc/gcc-4.5-work/libffi/testsuite/libffi.call/call.exp ... FAIL: libffi.call/cls_dbls_struct.c -O0 -W -Wall output pattern test, is 1.0 0.0 1.0 2.0 ? should match 1.0 2.0 ?.0 2.0 FAIL: libffi.call/cls_dbls_struct.c -O2 output pattern test, is 1.0 0.0 1.0 2.0 ? should match 1.0 2.0 ?.0 2.0 FAIL: libffi.call/cls_dbls_struct.c -O3 output pattern test, is 1.0 0.0 1.0 2.0 ? should match 1.0 2.0 ?.0 2.0 FAIL: libffi.call/cls_dbls_struct.c -Os output pattern test, is 1.0 0.0 1.0 2.0 ? should match 1.0 2.0 ?.0 2.0 FAIL: libffi.call/cls_dbls_struct.c -O2 -fomit-frame-pointer output pattern test, is 1.0 0.0 1.0 2.0 ? should match 1.0 2.0 ?.0 2.0 Running /opt/gcc/gcc-4.5-work/libffi/testsuite/libffi.special/special.exp ... === libffi Summary for unix/-m64 === # of expected passes1589 # of unexpected failures5 # of expected failures 10 # of unsupported tests 15 === libffi Summary === # of expected passes3183 # of unexpected failures5 # of expected failures 20 # of unsupported tests 30 Thanks for the patch. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444
[Bug libffi/40444] [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.
--- Comment #4 from dominiq at lps dot ens dot fr 2009-06-16 09:50 --- libffi/testsuite/libffi.call/cls_dbls_struct.c is XFAILed for x86_64-*-linux-*. It should probably xfailed also for x86_64*darwin* and i686-apple-darwin* with -m64. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444
[Bug libffi/40444] [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.
--- Comment #5 from aph at gcc dot gnu dot org 2009-06-16 10:12 --- Thanks for the patch, Andreas. Please push upstream(s). -- aph at gcc dot gnu dot org changed: What|Removed |Added Last reconfirmed|2009-06-16 07:33:36 |2009-06-16 10:12:07 date|| http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444
[Bug libffi/40444] [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.
--- Comment #6 from andreast at gcc dot gnu dot org 2009-06-16 17:28 --- Subject: Bug 40444 Author: andreast Date: Tue Jun 16 17:28:29 2009 New Revision: 148542 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=148542 Log: 2009-06-16 Andreas Tobler a.tob...@schweiz.org PR libffi/40444 * testsuite/lib/libffi-dg.exp (libffi_target_compile): Add allow_stack_execute for Darwin. Modified: trunk/libffi/ChangeLog trunk/libffi/testsuite/lib/libffi-dg.exp -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444
[Bug libffi/40444] [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.
--- Comment #7 from andreast at gcc dot gnu dot org 2009-06-16 17:30 --- Fixed. -- andreast at gcc dot gnu dot org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444
[Bug libffi/40444] [4.5 Regression] libffi badly broken with -m64 by some revision between 148383 and 148472.
--- Comment #1 from aph at gcc dot gnu dot org 2009-06-15 15:47 --- Adding Andreas Tobler; perhaps he knows. -- aph at gcc dot gnu dot org changed: What|Removed |Added CC||andreast at gcc dot gnu dot ||org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40444
