[Bug libffi/70024] [5/6 Regression] libffi ABI change w/o SONAME bump

2020-02-25 Thread fw at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70024

Florian Weimer  changed:

   What|Removed |Added

 CC||fw at gcc dot gnu.org

--- Comment #10 from Florian Weimer  ---
Was this an ABI change anywhere but on Mach-O targets?

FFI_EXEC_TRAMPOLINE_TABLE is 0 on GNU/Linux, right?

[Bug libffi/70024] [5/6 Regression] libffi ABI change w/o SONAME bump

2019-12-19 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70024

--- Comment #9 from Jonathan Wakely  ---
comment 8 was meant to be for PR 70224

[Bug libffi/70024] [5/6 Regression] libffi ABI change w/o SONAME bump

2016-03-19 Thread law at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70024

--- Comment #8 from Jeffrey A. Law  ---
Author: law
Date: Wed Mar 16 16:58:12 2016
New Revision: 234262

URL: https://gcc.gnu.org/viewcvs?rev=234262&root=gcc&view=rev
Log:
PR rtl-optimization/70024
* reorg.c (relax_delay_slots): Pass right argument to CROSSING_JUMP_P.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/reorg.c

[Bug libffi/70024] [5/6 Regression] libffi ABI change w/o SONAME bump

2016-03-02 Thread rth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70024

Richard Henderson  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Richard Henderson  ---
FIXED for gcc6, WONTFIX for gcc5.

[Bug libffi/70024] [5/6 Regression] libffi ABI change w/o SONAME bump

2016-03-02 Thread rth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70024

--- Comment #6 from Richard Henderson  ---
Author: rth
Date: Thu Mar  3 01:40:29 2016
New Revision: 233926

URL: https://gcc.gnu.org/viewcvs?rev=233926&root=gcc&view=rev
Log:
PR libffi/70024

  * Makefile.am (libffi_version_script): Look in cwd for libffi.map.
  (libffi_version_dep, libffi.map-sun): Likewise.
  (libffi.map): New target.
  * libffi.map.in: Rename from libffi.map.  Add required defines,
  includes, and conditionals.

Added:
trunk/libffi/libffi.map.in
  - copied, changed from r233925, trunk/libffi/libffi.map
Removed:
trunk/libffi/libffi.map
Modified:
trunk/libffi/ChangeLog
trunk/libffi/Makefile.am
trunk/libffi/Makefile.in

[Bug libffi/70024] [5/6 Regression] libffi ABI change w/o SONAME bump

2016-03-02 Thread rth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70024

--- Comment #5 from Richard Henderson  ---
Author: rth
Date: Wed Mar  2 23:28:11 2016
New Revision: 233921

URL: https://gcc.gnu.org/viewcvs?rev=233921&root=gcc&view=rev
Log:
PR libffi/70024

  * Makefile.am (libffi_version_script): New.
  (libffi_version_dep): New.
  (libffi_version_info): New.
  (libffi_la_LDFLAGS): Include libffi_version_info, libffi_version_script.
  (libffi_la_DEPENDENCIES): Include libffi_version_dep.
  * acinclude.m4 (LIBAT_ENABLE, LIBAT_CHECK_LINKER_FEATURES): New.
  (LIBAT_ENABLE_SYMVERS, LIBAT_BUILD_VERSIONED_SHLIB): New.
  (LIBAT_BUILD_VERSIONED_SHLIB_GNU): New.
  (LIBAT_BUILD_VERSIONED_SHLIB_SUN): New.
  * configure.ac: Invoke LIBAT_ENABLE_SYMVERS.
  * libffi.map: New file.
  * libtool-version: Increase to 5.0.0.
  * Makefile.in, configure: Rebuild.
  * man/Makefile.in, testsuite/Makefile.in: Rebuild.

Added:
trunk/libffi/libffi.map
Modified:
trunk/libffi/ChangeLog
trunk/libffi/Makefile.am
trunk/libffi/Makefile.in
trunk/libffi/acinclude.m4
trunk/libffi/configure
trunk/libffi/configure.ac
trunk/libffi/include/Makefile.in
trunk/libffi/libtool-version
trunk/libffi/man/Makefile.in
trunk/libffi/testsuite/Makefile.in

[Bug libffi/70024] [5/6 Regression] libffi ABI change w/o SONAME bump

2016-03-02 Thread rth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70024

Richard Henderson  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|unassigned at gcc dot gnu.org  |rth at gcc dot gnu.org

[Bug libffi/70024] [5/6 Regression] libffi ABI change w/o SONAME bump

2016-03-02 Thread rguenther at suse dot de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70024

--- Comment #4 from rguenther at suse dot de  ---
On Tue, 1 Mar 2016, rth at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70024
> 
> Richard Henderson  changed:
> 
>What|Removed |Added
> 
>  Status|UNCONFIRMED |NEW
>Last reconfirmed||2016-03-01
>  CC||green at gcc dot gnu.org
>  Ever confirmed|0   |1
> 
> --- Comment #3 from Richard Henderson  ---
> That's my fault.
> 
> I believe I was planning to put off the soname bump until I'd
> also converted libffi to use symbol versioning, but then didn't
> finish that sub-project, leaving us in this unfortunate state.
> 
> Shall I simply do the version bump now, or also implement the versioning?

I believe that a bump at this point isn't too useful given the existing
breakage thus bumping together with adding the versioning would be
preferred (if you manage to complete that before GCC 6 - you have
about a month left).  Oh, and we should document the accidential breakage
in gcc-5/changes.html.

[Bug libffi/70024] [5/6 Regression] libffi ABI change w/o SONAME bump

2016-03-01 Thread rth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70024

Richard Henderson  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2016-03-01
 CC||green at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #3 from Richard Henderson  ---
That's my fault.

I believe I was planning to put off the soname bump until I'd
also converted libffi to use symbol versioning, but then didn't
finish that sub-project, leaving us in this unfortunate state.

Shall I simply do the version bump now, or also implement the versioning?

[Bug libffi/70024] [5/6 Regression] libffi ABI change w/o SONAME bump

2016-03-01 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70024

Jakub Jelinek  changed:

   What|Removed |Added

 CC||jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek  ---
Yeah, I'm afraid changing it in 4.9 or bumping soname in 5 is now too late.
We could bump the SONAME in 6.

[Bug libffi/70024] [5/6 Regression] libffi ABI change w/o SONAME bump

2016-03-01 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70024

Richard Biener  changed:

   What|Removed |Added

   Target Milestone|--- |5.4

--- Comment #1 from Richard Biener  ---
I suppose we can't do very much here apart from a) backporting the change to
4.9 (quite late), b) documenting the ABI change (at least), c) bumping the
SONAME (quite late)