[Bug libfortran/27964] Wrong line ends on windows (XP)
--- Comment #12 from dannysmith at users dot sourceforge dot net 2006-09-23 02:00 --- Fixed on trunk -- dannysmith at users dot sourceforge dot net changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27964
[Bug libfortran/27964] Wrong line ends on windows (XP)
-- dannysmith at users dot sourceforge dot net changed: What|Removed |Added AssignedTo|unassigned at gcc dot gnu |dannysmith at users dot |dot org |sourceforge dot net Status|NEW |ASSIGNED Last reconfirmed|2006-06-08 19:14:51 |2006-09-23 02:00:37 date|| http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27964
[Bug libfortran/27964] Wrong line ends on windows (XP)
--- Comment #11 from dannysmith at gcc dot gnu dot org 2006-09-23 01:57 --- Subject: Bug 27964 Author: dannysmith Date: Sat Sep 23 01:56:55 2006 New Revision: 117166 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=117166 Log: PR libfortran/27964 * configure.ac: Check for setmode() function. * configure: Regenerate. * config.h.in: Regenerate. * io/unix.c (output_stream): Force stdout to binary mode. (error_stream): Force stderr to binary mode. Modified: trunk/libgfortran/ChangeLog trunk/libgfortran/config.h.in trunk/libgfortran/configure trunk/libgfortran/configure.ac trunk/libgfortran/io/unix.c -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27964
[Bug libfortran/27964] Wrong line ends on windows (XP)
--- Comment #10 from jvdelisle at gcc dot gnu dot org 2006-09-13 00:21 --- Thanks for taking the time to figure this out. I just have not had the time to get setup to investigate. I am unassigning myself. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27964
[Bug libfortran/27964] Wrong line ends on windows (XP)
--- Comment #9 from dannysmith at users dot sourceforge dot net 2006-09-12
23:36 ---
The problem is that although all 'regular' files are opened as O_BINARY,
preconnected files stderr and stdout are already opened as default O_TEXT.
The simplest fix is just to force the mode of these preconnected files to
O_BINARY at initialisation, as below.
This needs more testing before I submit a formal patch, but it certainly fixes
a lot of gfortran mingw32 testsuite cases where stdout results are scanned.
The alternative would be to change each
#ifdef (HAVE_CRLF)
to
if (HAVE_CRLF) && is_regular_file(fd)
Index: io/unix.c
===
*** io/unix.c (revision 116838)
--- io/unix.c (working copy)
*** input_stream (void)
*** 1289,1294
--- 1289,1297
stream *
output_stream (void)
{
+ #if defined(HAVE_CRLF) && defined(O_BINARY)
+ setmode (fileno (stdout), O_BINARY);
+ #endif
return fd_to_stream (STDOUT_FILENO, PROT_WRITE);
}
*** output_stream (void)
*** 1299,1304
--- 1302,1310
stream *
error_stream (void)
{
+ #if defined(HAVE_CRLF) && defined(O_BINARY)
+ setmode (fileno (stderr), O_BINARY);
+ #endif
return fd_to_stream (STDERR_FILENO, PROT_WRITE);
}
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27964
[Bug libfortran/27964] Wrong line ends on windows (XP)
--- Comment #8 from jvdelisle at gcc dot gnu dot org 2006-09-04 23:11 --- Well I confirmed this is not on cygwin. Now I have to build a mingw version. Sorry this is taking so long. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27964
[Bug libfortran/27964] Wrong line ends on windows (XP)
--- Comment #7 from gay at sfu dot ca 2006-08-16 05:49 --- Subject: Re: Wrong line ends on windows (XP) On Wed, Aug 16, 2006 at 03:04:45AM -, jvdelisle at gcc dot gnu dot org wrote: > > > --- Comment #6 from jvdelisle at gcc dot gnu dot org 2006-08-16 03:04 > --- > OK, I have an XP box up and running. Now to get a build going here and I may > be able to look into this one. Was this with the cygwin or mingw versio that > had the problem, or both? > I observed it in the mingw version. Don't know if it happens with cygwin or not. Ian > > -- > > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27964 > > --- You are receiving this mail because: --- > You reported the bug, or are watching the reporter. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27964
[Bug libfortran/27964] Wrong line ends on windows (XP)
--- Comment #6 from jvdelisle at gcc dot gnu dot org 2006-08-16 03:04 --- OK, I have an XP box up and running. Now to get a build going here and I may be able to look into this one. Was this with the cygwin or mingw versio that had the problem, or both? -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27964
[Bug libfortran/27964] Wrong line ends on windows (XP)
--- Comment #5 from jvdelisle at gcc dot gnu dot org 2006-07-23 16:17 --- I don't think it's a curse, but its spooky. :) -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27964
[Bug libfortran/27964] Wrong line ends on windows (XP)
--- Comment #4 from fxcoudert at gcc dot gnu dot org 2006-07-23 13:17 --- My XP box died last week (is that a curse?) It's being taken care of, but I won't be able to work on it for some time. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27964
[Bug libfortran/27964] Wrong line ends on windows (XP)
--- Comment #3 from jvdelisle at gcc dot gnu dot org 2006-06-14 00:32 --- My XP box died. I can't do much with this now. -- jvdelisle at gcc dot gnu dot org changed: What|Removed |Added AssignedTo|jvdelisle at gcc dot gnu dot|unassigned at gcc dot gnu |org |dot org Status|ASSIGNED|NEW http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27964
[Bug libfortran/27964] Wrong line ends on windows (XP)
--- Comment #2 from fxcoudert at gcc dot gnu dot org 2006-06-08 21:26 --- No, go ahead if you have time (I'm buried deep into bounds-checking). I confirm this bug on MinGW, I think the problem might not appear on cygwin. -- fxcoudert at gcc dot gnu dot org changed: What|Removed |Added CC||fxcoudert at gcc dot gnu dot ||org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27964
