[Bug libfortran/91593] Implicit enum conversions in libgfortran/io/transfer.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91593 Jerry DeLisle changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #9 from Jerry DeLisle --- As far as I can tell, fixed on trunk.
[Bug libfortran/91593] Implicit enum conversions in libgfortran/io/transfer.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91593 --- Comment #8 from Eric Gallager --- (In reply to Jerry DeLisle from comment #7) > Author: jvdelisle > Date: Wed Oct 2 02:35:14 2019 > New Revision: 276439 > > URL: https://gcc.gnu.org/viewcvs?rev=276439=gcc=rev > Log: > 2019-10-01 Jerry DeLisle > > PR libfortran/91593 > * io/read.c (read_decimal): Cast constant to size_t to turn off > a bogus warning. > * io/write.c (btoa_big): Use memset in lieu of setting the null > byte in a string buffer to turn off a bogus warning. > > Modified: > trunk/libgfortran/ChangeLog > trunk/libgfortran/io/read.c > trunk/libgfortran/io/write.c Did this fix it?
[Bug libfortran/91593] Implicit enum conversions in libgfortran/io/transfer.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91593 --- Comment #7 from Jerry DeLisle --- Author: jvdelisle Date: Wed Oct 2 02:35:14 2019 New Revision: 276439 URL: https://gcc.gnu.org/viewcvs?rev=276439=gcc=rev Log: 2019-10-01 Jerry DeLisle PR libfortran/91593 * io/read.c (read_decimal): Cast constant to size_t to turn off a bogus warning. * io/write.c (btoa_big): Use memset in lieu of setting the null byte in a string buffer to turn off a bogus warning. Modified: trunk/libgfortran/ChangeLog trunk/libgfortran/io/read.c trunk/libgfortran/io/write.c
[Bug libfortran/91593] Implicit enum conversions in libgfortran/io/transfer.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91593 --- Comment #6 from Jerry DeLisle --- Author: jvdelisle Date: Sat Sep 28 19:14:47 2019 New Revision: 276255 URL: https://gcc.gnu.org/viewcvs?rev=276255=gcc=rev Log: 2019-09-28 Jerry DeLisle PR libfortran/91593 * io/io.h: Add gcc_unreachable(). * io/transfer.c (file_mode, current_mode, formatted_transfer_scalar_read, formatted_transfer_scalar_write, pre_position, next_record_r, next_record_w): Add and use FORMATTED_UNSPECIFIED to enumeration. Modified: trunk/libgfortran/ChangeLog trunk/libgfortran/io/io.h trunk/libgfortran/io/transfer.c
[Bug libfortran/91593] Implicit enum conversions in libgfortran/io/transfer.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91593 --- Comment #5 from Jerry DeLisle --- Looking back at the code I see we are translating from Front-end to run time regarding whether or not we actually are going to show the positive sign or not or suppress it the sign altogether in floating point writes. In this process we actually have three different enumumerators defined. I am going to analyze this a bit more since it "seems" that one ought to be able to do this all in one step at the right place. There is a comment about keeping things alligned so as to not break the ABI, so I would bet that as the standards evolved we had to evolve this code a bit. I will see what I can come up with that might make more sense and not break the ABI. (other than just doing a cast)
[Bug libfortran/91593] Implicit enum conversions in libgfortran/io/transfer.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91593 Jerry DeLisle changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Last reconfirmed||2019-09-04 Assignee|unassigned at gcc dot gnu.org |jvdelisle at gcc dot gnu.org Ever confirmed|0 |1 --- Comment #4 from Jerry DeLisle --- (In reply to Thomas Koenig from comment #3) > Jerry, I am away from my computer at the moment. > > Does zhis ring a bell? Does not specifically ring a bell, but I am very familair with the code and would be happy to fix it.
[Bug libfortran/91593] Implicit enum conversions in libgfortran/io/transfer.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91593 Thomas Koenig changed: What|Removed |Added CC||jvdelisle at gcc dot gnu.org, ||tkoenig at gcc dot gnu.org --- Comment #3 from Thomas Koenig --- Jerry, I am away from my computer at the moment. Does zhis ring a bell?
[Bug libfortran/91593] Implicit enum conversions in libgfortran/io/transfer.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91593 Jeffrey A. Law changed: What|Removed |Added CC||law at redhat dot com --- Comment #2 from Jeffrey A. Law --- And ideally once this is fixed we would reevaluate if -Wenum-conversion should be part of -Wall vs -Wextra.
[Bug libfortran/91593] Implicit enum conversions in libgfortran/io/transfer.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91593 --- Comment #1 from prathamesh3492 at gcc dot gnu.org --- Patch for PR78736 that triggers the warnings: https://gcc.gnu.org/ml/gcc-patches/2019-08/msg01938.html Thanks, Prathamesh
