[Bug libgcc/109670] [13/14 regression] Exception handling broken for 32-bit Windows
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109670 Xi Ruoyao changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED CC||xry111 at gcc dot gnu.org --- Comment #20 from Xi Ruoyao --- (In reply to Thomas Neumann from comment #19) > I think we can close this bug as fixed, but I do not have permissions to do > that. Closing.
[Bug libgcc/109670] [13/14 regression] Exception handling broken for 32-bit Windows
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109670 --- Comment #19 from Thomas Neumann --- I think we can close this bug as fixed, but I do not have permissions to do that.
[Bug libgcc/109670] [13/14 regression] Exception handling broken for 32-bit Windows
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109670 Mikael Pettersson changed: What|Removed |Added CC||mikpelinux at gmail dot com --- Comment #18 from Mikael Pettersson --- Since the fix has been backported to gcc-13 branch, can this be closed now?
[Bug libgcc/109670] [13/14 regression] Exception handling broken for 32-bit Windows
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109670 --- Comment #17 from CVS Commits --- The releases/gcc-13 branch has been updated by Thomas Neumann : https://gcc.gnu.org/g:7b21a74b41b30cd070f69523edf9583d1e287249 commit r13-7411-g7b21a74b41b30cd070f69523edf9583d1e287249 Author: Thomas Neumann Date: Wed May 10 12:33:49 2023 +0200 fix radix sort on 32bit platforms [PR109670] The radix sort uses two buffers, a1 for input and a2 for output. After every digit the role of the two buffers is swapped. When terminating the sort early the code made sure the output was in a2. However, when we run out of bits, as can happen on 32bit platforms, the sorted result was in a1, as we had just swapped a1 and a2. This patch fixes the problem by unconditionally having a1 as output after every loop iteration. This bug manifested itself only on 32bit platforms and even then only in some circumstances, as it needs frames where a swap is required due to differences in the top-most byte, which is affected by ASLR. The new logic was validated by exhaustive search over 32bit input values. libgcc/ChangeLog: PR libgcc/109670 * unwind-dw2-fde.c: Fix radix sort buffer management.
[Bug libgcc/109670] [13/14 regression] Exception handling broken for 32-bit Windows
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109670 --- Comment #16 from CVS Commits --- The master branch has been updated by Thomas Neumann : https://gcc.gnu.org/g:38e88d41f50d844f1404172657ef7e8372014ef6 commit r14-1515-g38e88d41f50d844f1404172657ef7e8372014ef6 Author: Thomas Neumann Date: Wed May 10 12:33:49 2023 +0200 fix radix sort on 32bit platforms [PR109670] The radix sort uses two buffers, a1 for input and a2 for output. After every digit the role of the two buffers is swapped. When terminating the sort early the code made sure the output was in a2. However, when we run out of bits, as can happen on 32bit platforms, the sorted result was in a1, as we had just swapped a1 and a2. This patch fixes the problem by unconditionally having a1 as output after every loop iteration. This bug manifested itself only on 32bit platforms and even then only in some circumstances, as it needs frames where a swap is required due to differences in the top-most byte, which is affected by ASLR. The new logic was validated by exhaustive search over 32bit input values. libgcc/ChangeLog: PR libgcc/109670 * unwind-dw2-fde.c: Fix radix sort buffer management.
[Bug libgcc/109670] [13/14 regression] Exception handling broken for 32-bit Windows
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109670 --- Comment #15 from Christoph Reiter --- (In reply to Thomas Neumann from comment #12) > Created attachment 55037 [details] > radix sort fix > > I could reproduce the problem, the radix sort did not behave correctly when > we ran out of bits, which can happen on 32bit platforms. The attached patch > fixes the problem. I can confirm that this fixes the issue for me.
[Bug libgcc/109670] [13/14 regression] Exception handling broken for 32-bit Windows
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109670 --- Comment #14 from LIU Hao --- (In reply to Thomas Neumann from comment #12) > Created attachment 55037 [details] > radix sort fix > > I could reproduce the problem, the radix sort did not behave correctly when > we ran out of bits, which can happen on 32bit platforms. The attached patch > fixes the problem. This fixes GDB for me.
[Bug libgcc/109670] [13/14 regression] Exception handling broken for 32-bit Windows
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109670 --- Comment #13 from LIU Hao --- I will test this later today.
[Bug libgcc/109670] [13/14 regression] Exception handling broken for 32-bit Windows
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109670 --- Comment #12 from Thomas Neumann --- Created attachment 55037 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55037=edit radix sort fix I could reproduce the problem, the radix sort did not behave correctly when we ran out of bits, which can happen on 32bit platforms. The attached patch fixes the problem.
[Bug libgcc/109670] [13/14 regression] Exception handling broken for 32-bit Windows
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109670 Eric Botcazou changed: What|Removed |Added CC||ebotcazou at gcc dot gnu.org Target Milestone|--- |13.2 Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Last reconfirmed||2023-05-09 Severity|normal |major Summary|Exception handling broken |[13/14 regression] |for 32bit Windows starting |Exception handling broken |with GCC 13 |for 32-bit Windows
