[Bug libgcc/82635] std::thread's join broken on FreeBSD with all GCCs >= 5

[andreast at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82635

Andreas Tobler  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #18 from Andreas Tobler  ---
Trunk and active branches are fixed.

[Bug libgcc/82635] std::thread's join broken on FreeBSD with all GCCs >= 5

[andreast at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82635

--- Comment #17 from Andreas Tobler  ---
Author: andreast
Date: Sun Nov  5 19:33:44 2017
New Revision: 254432

URL: https://gcc.gnu.org/viewcvs?rev=254432=gcc=rev
Log:
2017-11-05  Andreas Tobler  

Backport from mainline
2017-11-04  Andreas Tobler  

PR libgcc/82635
* config/i386/freebsd-unwind.h (MD_FALLBACK_FRAME_STATE_FOR): Use a
sysctl to determine whether we're in a trampoline.
Keep the pattern matching method for systems without
KERN_PROC_SIGTRAMP sysctl.

Modified:
branches/gcc-6-branch/libgcc/ChangeLog
branches/gcc-6-branch/libgcc/config/i386/freebsd-unwind.h

[Bug libgcc/82635] std::thread's join broken on FreeBSD with all GCCs >= 5

[andreast at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82635

--- Comment #16 from Andreas Tobler  ---
Author: andreast
Date: Sun Nov  5 19:30:41 2017
New Revision: 254431

URL: https://gcc.gnu.org/viewcvs?rev=254431=gcc=rev
Log:
2017-11-05  Andreas Tobler  

Backport from mainline
2017-11-04  Andreas Tobler  

PR libgcc/82635
* config/i386/freebsd-unwind.h (MD_FALLBACK_FRAME_STATE_FOR): Use a
sysctl to determine whether we're in a trampoline.
Keep the pattern matching method for systems without
KERN_PROC_SIGTRAMP sysctl.

Modified:
branches/gcc-7-branch/libgcc/ChangeLog
branches/gcc-7-branch/libgcc/config/i386/freebsd-unwind.h

[Bug libgcc/82635] std::thread's join broken on FreeBSD with all GCCs >= 5

[andreast at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82635

--- Comment #15 from Andreas Tobler  ---
Author: andreast
Date: Sat Nov  4 19:40:23 2017
New Revision: 254411

URL: https://gcc.gnu.org/viewcvs?rev=254411=gcc=rev
Log:
2017-11-04  Andreas Tobler  

PR libgcc/82635
* config/i386/freebsd-unwind.h (MD_FALLBACK_FRAME_STATE_FOR): Use a
sysctl to determine whether we're in a trampoline.
Keep the pattern matching method for systems without
KERN_PROC_SIGTRAMP sysctl.

Modified:
trunk/libgcc/ChangeLog
trunk/libgcc/config/i386/freebsd-unwind.h

[Bug libgcc/82635] std::thread's join broken on FreeBSD with all GCCs >= 5

[andreast at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82635

--- Comment #14 from Andreas Tobler  ---
The gcc5 branch is closed, so I can not commit there. In the ports tree we're
on gcc6 as default gcc. We still can build gcc5. I certainly can talk to Gerald
to make an exception or whatever and patch the gcc5 port.

[Bug libgcc/82635] std::thread's join broken on FreeBSD with all GCCs >= 5

[h2+bugs at fsfe dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82635

--- Comment #13 from Hannes Hauswedell  ---
(In reply to Andreas Tobler from comment #12)
> Will soon commit a fix, for gcc6/7/8 on FreeBSD > 9.3. Older gcc's and OS
> releases will not be supported by this fix.

Thanks a lot!

But is there no chance of getting a fix for gcc5? Not even via patch in the
FreeBSD port (if not doable via gcc5 trunk)?
Because we would need to selectively disable gcc5 then (while gcc49 and >5
would still work which is kind of akward).

[Bug libgcc/82635] std::thread's join broken on FreeBSD with all GCCs >= 5

[andreast at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82635

--- Comment #12 from Andreas Tobler  ---
Will soon commit a fix, for gcc6/7/8 on FreeBSD > 9.3. Older gcc's and OS
releases will not be supported by this fix.

[Bug libgcc/82635] std::thread's join broken on FreeBSD with all GCCs >= 5

[andreast at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82635

Andreas Tobler  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|unassigned at gcc dot gnu.org  |andreast at gcc dot 
gnu.org

--- Comment #11 from Andreas Tobler  ---
For the record, in gcc5 this one went in:
md_unwind_header=i386/freebsd-unwind.h
Before we had no MD_FALLBACK_FRAME_STATE_FOR.

Will investigate.

[Bug libgcc/82635] std::thread's join broken on FreeBSD with all GCCs >= 5

[h2+bugs at fsfe dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82635

--- Comment #10 from Hannes Hauswedell  ---
> Could you please tell us the FreeBSD version and arch you run on?
uname -ra

FreeBSD celegans.imp.fu-berlin.de 11.1-RELEASE FreeBSD 11.1-RELEASE #0 r321309:
Fri Jul 21 02:08:28 UTC 2017
r...@releng2.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64

For completeness, these are the GCC versions installed:
% pkg info | grep gcc
gcc-ecj-4.5Eclipse Java Compiler used to build GCC Java
gcc49-4.9.4_5  GNU Compiler Collection 4.9
gcc5-5.4.0_4   GNU Compiler Collection 5
gcc6-6.4.0_2   GNU Compiler Collection 6
gcc7-devel-7.2.1.s20171012 GNU Compiler Collection 7
gcc8-devel-8.0.0.s20171008 GNU Compiler Collection 8

gcc49-4.9.4_5 works, the later ones don't.

[Bug libgcc/82635] std::thread's join broken on FreeBSD with all GCCs >= 5

[andreast at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82635

--- Comment #9 from Andreas Tobler  ---
Could you please tell us the FreeBSD version and arch you run on?
uname -ra

[Bug libgcc/82635] std::thread's join broken on FreeBSD with all GCCs >= 5

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82635

Jonathan Wakely  changed:

   What|Removed |Added

 Status|WAITING |NEW
 CC||andreast at gcc dot gnu.org

--- Comment #8 from Jonathan Wakely  ---
Thanks for the info, I'll try to reproduce this on freebsd but I'll confirm it
anyway.

[Bug libgcc/82635] std::thread's join broken on FreeBSD with all GCCs >= 5

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82635

Andrew Pinski  changed:

   What|Removed |Added

  Component|c++ |libgcc

--- Comment #7 from Andrew Pinski  ---
Looks like the crash is inside libgcc.  Maybe the new libgcc is not fully
compatible with freebsd.