[Bug libgomp/80394] Empty OpenMP task is wrongly removed when optimizing

[amonakov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80394

Alexander Monakov  changed:

   What|Removed |Added

 CC||amonakov at gcc dot gnu.org

--- Comment #1 from Alexander Monakov  ---
omp-low.c: scan_omp_task () has:

1860   /* Ignore task directives with empty bodies.  */
1861   if (optimize > 0
1862   && empty_body_p (gimple_omp_body (stmt)))
1863 {
1864   gsi_replace (gsi, gimple_build_nop (), false);
1865   return;
1866 }

This was added to trunk with r136433 (OpenMP 3.0 merge), before the 'depend'
clause appeared in OpenMP 4.0.

[Bug libgomp/80394] Empty OpenMP task is wrongly removed when optimizing

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80394

Jakub Jelinek  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Last reconfirmed||2017-04-11
   Assignee|unassigned at gcc dot gnu.org  |jakub at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #2 from Jakub Jelinek  ---
Yeah, tasks with depend clause should not be optimized out

[Bug libgomp/80394] Empty OpenMP task is wrongly removed when optimizing

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80394

--- Comment #3 from Jakub Jelinek  ---
Created attachment 41174
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=41174&action=edit
gcc7-pr80394.patch

Untested fix.

[Bug libgomp/80394] Empty OpenMP task is wrongly removed when optimizing

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80394

--- Comment #4 from Jakub Jelinek  ---
Author: jakub
Date: Tue Apr 11 17:15:47 2017
New Revision: 246849

URL: https://gcc.gnu.org/viewcvs?rev=246849&root=gcc&view=rev
Log:
PR libgomp/80394
* omp-low.c (scan_omp_task): Don't optimize away empty tasks
if they have any depend clauses.

* testsuite/libgomp.c/pr80394.c: New test.

Added:
trunk/libgomp/testsuite/libgomp.c/pr80394.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/omp-low.c
trunk/libgomp/ChangeLog

[Bug libgomp/80394] Empty OpenMP task is wrongly removed when optimizing

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80394

--- Comment #5 from Jakub Jelinek  ---
Fixed on the trunk so far, backports queued. Thanks for the report.

[Bug libgomp/80394] Empty OpenMP task is wrongly removed when optimizing

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80394

--- Comment #6 from Jakub Jelinek  ---
Author: jakub
Date: Fri May  5 21:54:06 2017
New Revision: 247700

URL: https://gcc.gnu.org/viewcvs?rev=247700&root=gcc&view=rev
Log:
Backported from mainline
2017-04-11  Jakub Jelinek  

PR libgomp/80394
* omp-low.c (scan_omp_task): Don't optimize away empty tasks
if they have any depend clauses.

* testsuite/libgomp.c/pr80394.c: New test.

Added:
branches/gcc-6-branch/libgomp/testsuite/libgomp.c/pr80394.c
Modified:
branches/gcc-6-branch/gcc/ChangeLog
branches/gcc-6-branch/gcc/omp-low.c
branches/gcc-6-branch/libgomp/ChangeLog

[Bug libgomp/80394] Empty OpenMP task is wrongly removed when optimizing

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80394

--- Comment #7 from Jakub Jelinek  ---
Author: jakub
Date: Tue May 30 08:25:50 2017
New Revision: 248671

URL: https://gcc.gnu.org/viewcvs?rev=248671&root=gcc&view=rev
Log:
Backported from mainline
2017-04-11  Jakub Jelinek  

PR libgomp/80394
* omp-low.c (scan_omp_task): Don't optimize away empty tasks
if they have any depend clauses.

* testsuite/libgomp.c/pr80394.c: New test.

Added:
branches/gcc-5-branch/libgomp/testsuite/libgomp.c/pr80394.c
Modified:
branches/gcc-5-branch/gcc/ChangeLog
branches/gcc-5-branch/gcc/omp-low.c
branches/gcc-5-branch/libgomp/ChangeLog

[Bug libgomp/80394] Empty OpenMP task is wrongly removed when optimizing

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80394

Jakub Jelinek  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Jakub Jelinek  ---
Fixed.