[Bug libstdc++/52799] deque::emplace(iterator, ...) tries to call push_front(...), which doesn't exist
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52799 --- Comment #7 from GCC Commits --- The releases/gcc-12 branch has been updated by Jonathan Wakely : https://gcc.gnu.org/g:1bb2bfb5d984456f59b42228f06d4ad4976358e7 commit r12-10240-g1bb2bfb5d984456f59b42228f06d4ad4976358e7 Author: Jonathan Wakely Date: Thu Jun 8 12:19:26 2023 +0100 libstdc++: Improve tests for emplace member of sequence containers Our existing tests for std::deque::emplace, std::list::emplace and std::vector::emplace are poor. We only have compile tests for PR 52799 and the equivalent for a const_iterator as the insertion point. This fails to check that the value is actually inserted correctly and the right iterator is returned. Add new tests that cover the existing 52799.cc and const_iterator.cc compile-only tests, as well as verifying the effects are correct. libstdc++-v3/ChangeLog: * testsuite/23_containers/deque/modifiers/emplace/52799.cc: Removed. * testsuite/23_containers/deque/modifiers/emplace/const_iterator.cc: Removed. * testsuite/23_containers/list/modifiers/emplace/52799.cc: Removed. * testsuite/23_containers/list/modifiers/emplace/const_iterator.cc: Removed. * testsuite/23_containers/vector/modifiers/emplace/52799.cc: Removed. * testsuite/23_containers/vector/modifiers/emplace/const_iterator.cc: Removed. * testsuite/23_containers/deque/modifiers/emplace/1.cc: New test. * testsuite/23_containers/list/modifiers/emplace/1.cc: New test. * testsuite/23_containers/vector/modifiers/emplace/1.cc: New test. (cherry picked from commit 3ec1d76a359542ed4c8370390efa9ee9e25e757f)
[Bug libstdc++/52799] deque::emplace(iterator, ...) tries to call push_front(...), which doesn't exist
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52799 --- Comment #6 from CVS Commits --- The releases/gcc-13 branch has been updated by Jonathan Wakely : https://gcc.gnu.org/g:52997b14311726447850341ecaf286b68587ff32 commit r13-7505-g52997b14311726447850341ecaf286b68587ff32 Author: Jonathan Wakely Date: Thu Jun 8 12:19:26 2023 +0100 libstdc++: Improve tests for emplace member of sequence containers Our existing tests for std::deque::emplace, std::list::emplace and std::vector::emplace are poor. We only have compile tests for PR 52799 and the equivalent for a const_iterator as the insertion point. This fails to check that the value is actually inserted correctly and the right iterator is returned. Add new tests that cover the existing 52799.cc and const_iterator.cc compile-only tests, as well as verifying the effects are correct. libstdc++-v3/ChangeLog: * testsuite/23_containers/deque/modifiers/emplace/52799.cc: Removed. * testsuite/23_containers/deque/modifiers/emplace/const_iterator.cc: Removed. * testsuite/23_containers/list/modifiers/emplace/52799.cc: Removed. * testsuite/23_containers/list/modifiers/emplace/const_iterator.cc: Removed. * testsuite/23_containers/vector/modifiers/emplace/52799.cc: Removed. * testsuite/23_containers/vector/modifiers/emplace/const_iterator.cc: Removed. * testsuite/23_containers/deque/modifiers/emplace/1.cc: New test. * testsuite/23_containers/list/modifiers/emplace/1.cc: New test. * testsuite/23_containers/vector/modifiers/emplace/1.cc: New test. (cherry picked from commit 3ec1d76a359542ed4c8370390efa9ee9e25e757f)
[Bug libstdc++/52799] deque::emplace(iterator, ...) tries to call push_front(...), which doesn't exist
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52799 --- Comment #5 from CVS Commits --- The master branch has been updated by Jonathan Wakely : https://gcc.gnu.org/g:3ec1d76a359542ed4c8370390efa9ee9e25e757f commit r14-1645-g3ec1d76a359542ed4c8370390efa9ee9e25e757f Author: Jonathan Wakely Date: Thu Jun 8 12:19:26 2023 +0100 libstdc++: Improve tests for emplace member of sequence containers Our existing tests for std::deque::emplace, std::list::emplace and std::vector::emplace are poor. We only have compile tests for PR 52799 and the equivalent for a const_iterator as the insertion point. This fails to check that the value is actually inserted correctly and the right iterator is returned. Add new tests that cover the existing 52799.cc and const_iterator.cc compile-only tests, as well as verifying the effects are correct. libstdc++-v3/ChangeLog: * testsuite/23_containers/deque/modifiers/emplace/52799.cc: Removed. * testsuite/23_containers/deque/modifiers/emplace/const_iterator.cc: Removed. * testsuite/23_containers/list/modifiers/emplace/52799.cc: Removed. * testsuite/23_containers/list/modifiers/emplace/const_iterator.cc: Removed. * testsuite/23_containers/vector/modifiers/emplace/52799.cc: Removed. * testsuite/23_containers/vector/modifiers/emplace/const_iterator.cc: Removed. * testsuite/23_containers/deque/modifiers/emplace/1.cc: New test. * testsuite/23_containers/list/modifiers/emplace/1.cc: New test. * testsuite/23_containers/vector/modifiers/emplace/1.cc: New test.
[Bug libstdc++/52799] deque::emplace(iterator, ...) tries to call push_front(...), which doesn't exist
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52799 Paolo Carlini paolo.carlini at oracle dot com changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Last reconfirmed||2012-03-31 AssignedTo|unassigned at gcc dot |paolo.carlini at oracle dot |gnu.org |com Target Milestone|--- |4.7.1 Ever Confirmed|0 |1 --- Comment #1 from Paolo Carlini paolo.carlini at oracle dot com 2012-03-31 00:57:22 UTC --- Oh my, let's fix this for 4.7.1 too.
[Bug libstdc++/52799] deque::emplace(iterator, ...) tries to call push_front(...), which doesn't exist
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52799 --- Comment #3 from paolo at gcc dot gnu.org paolo at gcc dot gnu.org 2012-03-31 01:57:20 UTC --- Author: paolo Date: Sat Mar 31 01:57:14 2012 New Revision: 186036 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=186036 Log: 2012-03-30 Jeffrey Yasskin jyass...@gcc.gnu.org Paolo Carlini paolo.carl...@oracle.com PR libstdc++/52799 * include/bits/deque.tcc (emplace): Fix thinko, replace push_front - emplace_front, and likewise for *_back. * testsuite/23_containers/deque/modifiers/emplace/52799.cc: New. * testsuite/23_containers/list/modifiers/emplace/52799.cc: Likewise. * testsuite/23_containers/vector/modifiers/emplace/52799.cc: Likewise. Added: branches/gcc-4_7-branch/libstdc++-v3/testsuite/23_containers/deque/modifiers/emplace/ branches/gcc-4_7-branch/libstdc++-v3/testsuite/23_containers/deque/modifiers/emplace/52799.cc branches/gcc-4_7-branch/libstdc++-v3/testsuite/23_containers/list/modifiers/emplace/ branches/gcc-4_7-branch/libstdc++-v3/testsuite/23_containers/list/modifiers/emplace/52799.cc branches/gcc-4_7-branch/libstdc++-v3/testsuite/23_containers/vector/modifiers/emplace/ branches/gcc-4_7-branch/libstdc++-v3/testsuite/23_containers/vector/modifiers/emplace/52799.cc Modified: branches/gcc-4_7-branch/libstdc++-v3/ChangeLog branches/gcc-4_7-branch/libstdc++-v3/include/bits/deque.tcc
[Bug libstdc++/52799] deque::emplace(iterator, ...) tries to call push_front(...), which doesn't exist
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52799 --- Comment #2 from paolo at gcc dot gnu.org paolo at gcc dot gnu.org 2012-03-31 01:57:00 UTC --- Author: paolo Date: Sat Mar 31 01:56:55 2012 New Revision: 186035 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=186035 Log: 2012-03-30 Jeffrey Yasskin jyass...@gcc.gnu.org Paolo Carlini paolo.carl...@oracle.com PR libstdc++/52799 * include/bits/deque.tcc (emplace): Fix thinko, replace push_front - emplace_front, and likewise for *_back. * testsuite/23_containers/deque/modifiers/emplace/52799.cc: New. * testsuite/23_containers/list/modifiers/emplace/52799.cc: Likewise. * testsuite/23_containers/vector/modifiers/emplace/52799.cc: Likewise. Added: trunk/libstdc++-v3/testsuite/23_containers/deque/modifiers/emplace/ trunk/libstdc++-v3/testsuite/23_containers/deque/modifiers/emplace/52799.cc trunk/libstdc++-v3/testsuite/23_containers/list/modifiers/emplace/ trunk/libstdc++-v3/testsuite/23_containers/list/modifiers/emplace/52799.cc trunk/libstdc++-v3/testsuite/23_containers/vector/modifiers/emplace/ trunk/libstdc++-v3/testsuite/23_containers/vector/modifiers/emplace/52799.cc Modified: trunk/libstdc++-v3/ChangeLog trunk/libstdc++-v3/include/bits/deque.tcc
[Bug libstdc++/52799] deque::emplace(iterator, ...) tries to call push_front(...), which doesn't exist
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52799 Paolo Carlini paolo.carlini at oracle dot com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #4 from Paolo Carlini paolo.carlini at oracle dot com 2012-03-31 01:59:27 UTC --- Done.
