[Bug libstdc++/89022] Implement P0202R3 - C++20 Constexpr Modifiers to Functions in and Headers.

2019-10-31 Thread emsr at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89022

emsr at gcc dot gnu.org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from emsr at gcc dot gnu.org ---
We can declare victory on this one.

[Bug libstdc++/89022] Implement P0202R3 - C++20 Constexpr Modifiers to Functions in and Headers.

2019-10-30 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89022

--- Comment #4 from Jonathan Wakely  ---
Oh, and I removed __cpp_lib_constexpr from  today.

[Bug libstdc++/89022] Implement P0202R3 - C++20 Constexpr Modifiers to Functions in and Headers.

2019-10-30 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89022

--- Comment #3 from Jonathan Wakely  ---
(In reply to emsr from comment #2)
> I think we're done.
> The __cpp_lib_constexpr may not do anything or may not be in the newest
> drafts anymore.  We should probably kill it.  I was very confused as people
> were going back and forth about constexpr lib macros.

Yeah, it's pretty confusing!

> I still owe the patch for misc. constexpr bits.  That's not really this PR
> though (.  It's stuff like pair ctors, insert iterators, etc.

I think I did std::pair in r276154 (it was needed for Debug Mode which uses
std::pair in some algo checks).

I didn't touch the iterators though.

[Bug libstdc++/89022] Implement P0202R3 - C++20 Constexpr Modifiers to Functions in and Headers.

2019-10-30 Thread emsr at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89022

--- Comment #2 from emsr at gcc dot gnu.org ---
I think we're done.
The __cpp_lib_constexpr may not do anything or may not be in the newest drafts
anymore.  We should probably kill it.  I was very confused as people were going
back and forth about constexpr lib macros.

I still owe the patch for misc. constexpr bits.  That's not really this PR
though (.  It's stuff like pair ctors, insert iterators, etc.

[Bug libstdc++/89022] Implement P0202R3 - C++20 Constexpr Modifiers to Functions in and Headers.

2019-10-22 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89022

Jonathan Wakely  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Last reconfirmed||2019-10-22
   Assignee|unassigned at gcc dot gnu.org  |emsr at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #1 from Jonathan Wakely  ---
How much of this is left to do?

Are you waiting for me to review any patches?

I noticed we have this in the  header, but it's not defined by any
other headers:

#define __cpp_lib_constexpr 201711L

Should that also be defined in ?

The current C++20 draft says it has value 201811L.