[Bug libstdc++/98605] clang-tidy error parsing on libstdc++-v3

[redi at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98605

Jonathan Wakely  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Assignee|unassigned at gcc dot gnu.org  |redi at gcc dot gnu.org
   Last reconfirmed||2021-01-09
 Ever confirmed|0   |1

[Bug libstdc++/98605] clang-tidy error parsing on libstdc++-v3

[mizvekov at gmail dot com via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98605

--- Comment #1 from Matheus Izvekov  ---
By the way, FYII it is also possible to suppress clang-tidy specific
diagnostics on specific lines with a "comment pragma", like so (untested):

// NOLINT(bugprone-dangling-handle)
// NOLINTNEXTLINE(bugprone-dangling-handle)

This might be better than having the linter parse different code than the real
compiler, while avoiding these kinds of problems where its hard to test every
define combination.

[Bug libstdc++/98605] clang-tidy error parsing on libstdc++-v3

[redi at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98605

--- Comment #2 from Jonathan Wakely  ---
Yes, that seems preferable, thanks.

[Bug libstdc++/98605] clang-tidy error parsing on libstdc++-v3

[redi at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98605

--- Comment #3 from Jonathan Wakely  ---
(In reply to Matheus Izvekov from comment #0)
> This was caused by the following commit:
> 
> ```
> commit 018813c8994b7dceab1b7d999e9c09654a22ef50

I can't identify that commit. The one in the GCC tree is:

Author: Jonathan Wakely 
AuthorDate: Fri Oct 13 13:39:24 2017

PR libstdc++/82481 Suppress clang-tidy warnings

PR libstdc++/82481
* include/std/mutex (call_once): Suppress clang-tidy warnings about
dangling references.

From-SVN: r253724

[Bug libstdc++/98605] clang-tidy error parsing on libstdc++-v3

[redi at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98605

--- Comment #4 from Jonathan Wakely  ---
Doh, I missed out the actual commit hash. It was:

commit d1e85aa999ab87009fa02a5261754fbaa69206f2