[Bug middle-end/19454] [4.0 Regression] bad code generated with gcc.c-torture/execute/bf64-1.c at -O1

[jsm28 at gcc dot gnu dot org]

--- Additional Comments From jsm28 at gcc dot gnu dot org  2005-04-04 10:29 
---
Test now passes on 4.0 branch as well as mainline after patch was applied.

-- 
   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED
   Target Milestone|4.1.0   |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19454

[Bug middle-end/19454] [4.0 Regression] bad code generated with gcc.c-torture/execute/bf64-1.c at -O1

[cvs-commit at gcc dot gnu dot org]

--- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-04-01 
11:23 ---
Subject: Bug 19454

CVSROOT:/cvs/gcc
Module name:gcc
Branch: gcc-4_0-branch
Changes by: [EMAIL PROTECTED]   2005-04-01 11:23:08

Modified files:
gcc: ChangeLog combine.c 
gcc/config/i386: i386.c 

Log message:
2005-04-01  Paolo Bonzini  <[EMAIL PROTECTED]>

PR middle-end/19454
PR rtl-optimization/20600

* combine.c (gen_binary): Remove.
(known_cond, simplify_shift_const, find_split_point,
combine_simplify_rtx, simplify_if_then_else, simplify_set,
simplify_logical, expand_field_assignment, extract_left_shift,
force_to_mode, if_then_else_cond, apply_distributive_law,
simplify_and_const_int, simplify_shift_const, gen_lowpart_for_combine,
simplify_comparison, reversed_comparison): Replace with
simplify_gen_binary, simplify_gen_relational or
distribute_and_simplify_rtx.
(distribute_and_simplify_rtx): New function.

* config/i386/i386.c (ix86_decompose_address): Look inside SUBREGs
to fix addresses involving EBP and ESP.
(aligned_operand, legitimate_address_p, ix86_address_cost): Be prepared
for SUBREGed registers.
(legitimate_address_p): Accept SUBREGed registers.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=2.7592.2.107&r2=2.7592.2.108
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/combine.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.475.4.1&r2=1.475.4.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/i386/i386.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.795.6.1&r2=1.795.6.2



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19454

[Bug middle-end/19454] [4.0 Regression] bad code generated with gcc.c-torture/execute/bf64-1.c at -O1

[bonzini at gcc dot gnu dot org]

-- 
Bug 19454 depends on bug 20600, which changed state.

Bug 20600 Summary: [4.1 regression] failure for pass.c on x86_64-pc-linux-gnu
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20600

   What|Old Value   |New Value

 Status|NEW |RESOLVED
 Resolution||FIXED

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19454

[Bug middle-end/19454] [4.0 Regression] bad code generated with gcc.c-torture/execute/bf64-1.c at -O1

[bonzini at gcc dot gnu dot org]

--- Additional Comments From bonzini at gcc dot gnu dot org  2005-03-24 
17:44 ---
Added PR20600, since the patch causes that regression.  Both patches were
approved for 4.0 once the PR20600 patch is approved into mainline.

-- 
   What|Removed |Added

 AssignedTo|unassigned at gcc dot gnu   |bonzini at gcc dot gnu dot
   |dot org |org
 Status|NEW |ASSIGNED
   Last reconfirmed|2005-03-20 02:53:07 |2005-03-24 17:44:51
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19454

[Bug middle-end/19454] [4.0 Regression] bad code generated with gcc.c-torture/execute/bf64-1.c at -O1

[bonzini at gcc dot gnu dot org]

--- Additional Comments From bonzini at gcc dot gnu dot org  2005-03-21 
14:23 ---
I'm looking into why the patch fixes the change

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19454

[Bug middle-end/19454] [4.0 Regression] bad code generated with gcc.c-torture/execute/bf64-1.c at -O1

[jsm28 at gcc dot gnu dot org]

--- Additional Comments From jsm28 at gcc dot gnu dot org  2005-03-20 02:53 
---
These test failures are fixed on mainline by:

2005-03-01  Paolo Bonzini  <[EMAIL PROTECTED]>

* combine.c (gen_binary): Remove.
(known_cond, simplify_shift_const, find_split_point,
combine_simplify_rtx, simplify_if_then_else, simplify_set,
simplify_logical, expand_field_assignment, extract_left_shift,
force_to_mode, if_then_else_cond, apply_distributive_law,
simplify_and_const_int, simplify_shift_const, gen_lowpart_for_combine,
simplify_comparison, reversed_comparison): Replace with
simplify_gen_binary, simplify_gen_relational or
distribute_and_simplify_rtx.
(distribute_and_simplify_rtx): New function.

I haven't yet tested this patch with 4.0 branch to see if it fixes them there.


-- 
   What|Removed |Added

 CC||bonzini at gcc dot gnu dot
   ||org, jsm28 at gcc dot gnu
   ||dot org
 Status|UNCONFIRMED |NEW
 Ever Confirmed||1
   Last reconfirmed|-00-00 00:00:00 |2005-03-20 02:53:07
   date||
Summary|[4.0/4.1 Regression] bad|[4.0 Regression] bad code
   |code generated with gcc.c-  |generated with gcc.c-
   |torture/execute/bf64-1.c at |torture/execute/bf64-1.c at
   |-O1 |-O1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19454

[Bug middle-end/19454] [4.0 Regression] bad code generated with gcc.c-torture/execute/bf64-1.c at -O1

[pinskia at gcc dot gnu dot org]

--- Additional Comments From pinskia at gcc dot gnu dot org  2005-02-01 
18:43 ---
Removing target milestone per: 
 as it is known 
to not to effect primary/secondary targets.

-- 
   What|Removed |Added

   Target Milestone|4.0.0   |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19454

[Bug middle-end/19454] [4.0 Regression] bad code generated with gcc.c-torture/execute/bf64-1.c at -O1

[pinskia at gcc dot gnu dot org]

-- 
   What|Removed |Added

 CC||rth at gcc dot gnu dot org
   Keywords||wrong-code
Summary|bad code generated with |[4.0 Regression] bad code
   |gcc.c-torture/execute/bf64- |generated with gcc.c-
   |1.c at -O1  |torture/execute/bf64-1.c at
   ||-O1
   Target Milestone|--- |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19454