[Bug middle-end/21014] read-rtl.c:670: warning: missing sentinel in function call

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=21014

John David Anglin  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from John David Anglin  ---
This doesn't occur anymore.

[Bug middle-end/21014] read-rtl.c:670: warning: missing sentinel in function call

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=21014

--- Comment #6 from Eric Gallager  ---
(In reply to dave from comment #5)
> Subject: Re:  read-rtl.c:670: warning: missing sentinel in function call
> 
> >   result = concat ("(", cond1, ") && (", cond2, ")", NULL);
> > 
> > 
> > Looks like someone forgot the cast.  (well in most of the time there is a 
> > cast, oh well).
> 
> It looks like this could be fixed by including stddef.h after stdio.h
> in system.h.  stddef.h would then provide an appropriate define for NULL.
> Otherwise, stdio.h needs fixing.  The define for NULL in system.h is
> also probably inadequate if it's ever needed.
> 
> Dave

I see  already included in system.h

[Bug middle-end/21014] read-rtl.c:670: warning: missing sentinel in function call

[dave at hiauly1 dot hia dot nrc dot ca]

--- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  
2005-04-15 22:10 ---
Subject: Re:  read-rtl.c:670: warning: missing sentinel in function call

>   result = concat ("(", cond1, ") && (", cond2, ")", NULL);
> 
> 
> Looks like someone forgot the cast.  (well in most of the time there is a 
> cast, oh well).

It looks like this could be fixed by including stddef.h after stdio.h
in system.h.  stddef.h would then provide an appropriate define for NULL.
Otherwise, stdio.h needs fixing.  The define for NULL in system.h is
also probably inadequate if it's ever needed.

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21014

[Bug middle-end/21014] read-rtl.c:670: warning: missing sentinel in function call

[dave at hiauly1 dot hia dot nrc dot ca]

--- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  
2005-04-14 00:58 ---
Subject: Re:  read-rtl.c:670: warning: missing sentinel in function call

> >   result = concat ("(", cond1, ") && (", cond2, ")", NULL);
> > 
> > 
> > Looks like someone forgot the cast.  (well in most of the time there is a 
> > cast, oh well).
> 
> Casts definitely postdate vax-ultrix ;-)  Do we always need a cast in
> join_c_conditions?

Looking at /usr/include/sys/_null.h on HP-UX 11.11, it appears that
we only will get a cast if _ANSI_NULL_POINTER is defined.  Since we
don't define this, I'm not sure why this problem doesn't also occur
under HP-UX.

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21014

[Bug middle-end/21014] read-rtl.c:670: warning: missing sentinel in function call

[dave at hiauly1 dot hia dot nrc dot ca]

--- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  
2005-04-14 00:46 ---
Subject: Re:  read-rtl.c:670: warning: missing sentinel in function call

>   result = concat ("(", cond1, ") && (", cond2, ")", NULL);
> 
> 
> Looks like someone forgot the cast.  (well in most of the time there is a 
> cast, oh well).

Casts definitely postdate vax-ultrix ;-)  Do we always need a cast in
join_c_conditions?

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21014

[Bug middle-end/21014] read-rtl.c:670: warning: missing sentinel in function call

[pinskia at gcc dot gnu dot org]

--- Additional Comments From pinskia at gcc dot gnu dot org  2005-04-14 
00:30 ---
  result = concat ("(", cond1, ") && (", cond2, ")", NULL);


Looks like someone forgot the cast.  (well in most of the time there is a cast, 
oh well).

-- 
   What|Removed |Added

 Status|UNCONFIRMED |NEW
  Component|c   |middle-end
 Ever Confirmed||1
   Last reconfirmed|-00-00 00:00:00 |2005-04-14 00:30:19
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21014